Page MenuHomePhabricator
Create Task
Maniphest T55345

VisualEditor: Creating a new reference with blank content leads to insertion of a <ref/> tag in the wikitext
Closed, ResolvedPublic
Actions

Description

See https://pl.wikipedia.org/w/index.php?title=Wojnicz&diff=37347163&oldid=37312891 for an example - I'm not sure what the problem is, here, since that's a meaningless tag :/.

Version: unspecified
Severity: normal

Details

Reference
bz53345

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:49 AM
• bzimport added projects: VE-deploy-2013-08-29, VisualEditor-EditingTools.
• bzimport set Reference to bz53345.
Ironholds created this task.Aug 26 2013, 2:36 PM
Ironholds added a comment.Aug 27 2013, 4:33 PM

Looks like it's what happens when you insert a reference without typing anything into the box. Hit "insert reference", leave the main field blank, go immediately to the insert button, and... https://pl.wikipedia.org/w/index.php?title=Wikipedysta%3AOkeyes_%28WMF%29&diff=37370424&oldid=37257359

gerritbot added a comment.Aug 28 2013, 12:20 AM

Change 81438 had a related patch set uploaded by Esanders:
Disable inserting/changing references when surface widget is empty

https://gerrit.wikimedia.org/r/81438

gerritbot added a comment.Aug 28 2013, 12:23 AM

Change 81438 merged by jenkins-bot:
Disable inserting/changing references when surface widget is empty

https://gerrit.wikimedia.org/r/81438

Jdforrester-WMF added a comment.Aug 28 2013, 12:23 AM

Fixed in master; will be deployed on Thursday as part of the regular push.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL