Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to add a new writer #2901

Merged
merged 1 commit into from Jul 13, 2021
Merged

Document how to add a new writer #2901

merged 1 commit into from Jul 13, 2021

Conversation

MinchinWeb
Copy link
Contributor

c.f. #2899

There was nothing in the existing documentation about how to actually implement a custom writer. This adds a little bit (of documentation) to that end.

Pull Request Checklist

Resolves: #issue-number-here

  • [ n/a ] Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • [ n/a ] Added tests for changed code
  • Updated documentation for changed code

@MinchinWeb MinchinWeb mentioned this pull request Jul 9, 2021
Closed
2 tasks
avaris
avaris approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@avaris avaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@justinmayer
Copy link
Member

Thanks to @MinchinWeb for the contribution and to @avaris for reviewing. 🏅

@justinmayer justinmayer merged commit 0919507 into getpelican:master Jul 13, 2021
@MinchinWeb MinchinWeb deleted the writer-docs branch July 13, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avaris avaris avaris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MinchinWeb @justinmayer @avaris