Add MIME types for web fonts #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinchinWeb
force-pushed
the
mimetypes-webfonts
branch
from
2f779bd
to
18a210f
Compare
|
This would resolved by python/cpython#20199, when it is merged into the Python core. |
|
Well, either commits from another PR should not be here or these commit should go on to that PR instead. Now you're guaranteed to cause merge conflicts. |
MinchinWeb
force-pushed
the
mimetypes-webfonts
branch
from
18a210f
to
5803052
Compare
|
@avaris I've fixed the extra commits issue; sorry about that. Should be good now. |
avaris
reviewed
Oct 6, 2021
MinchinWeb
force-pushed
the
mimetypes-webfonts
branch
from
0ed5902
to
8f02df8
Compare
MinchinWeb
force-pushed
the
mimetypes-webfonts
branch
from
8f02df8
to
98372c9
Compare
avaris
approved these changes
Oct 7, 2021
|
Thanks to @MinchinWeb for the enhancement and to @avaris for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #2928, it seems Python doesn't recognize/return the proper MIME-type for webfonts. Firefox does seems to work fine either way (as opposed to CSS...), but this seemed simple and proper to fix.
Before:
After:
Pull Request Checklist
P.S. If this could be marked "hacktoberfest-accepted" (so it counts towards my Hacktoberfest Pull Requests), that would be appreciated!