Add Escape shortcut to hide adder
#3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
approved these changes
Jul 6, 2021
| it('hides the adder when `Escape` shortcut is pressed', () => { | ||
| adder.annotationsForSelection = ['ann1']; | ||
| showAdder(); | ||
| triggerShortcut('Escape'); |
There was a problem hiding this comment.
We're not terribly consistent about this in some test suites, but as a rule of thumb once tests exceed 4 or 5 lines I find it helps readability to separate the setup/action being tested/assertions (aka Arrange/Act/Assert), assuming there is a clear separation between these phases. In this case, that means adding new blank lines before and after the triggerShortcut call.
The adder now hides when the escape key is pressed. (WCAG 2.1 criterion 1.4.13)
Codecov Report
@@ Coverage Diff @@
## master #3553 +/- ##
=======================================
Coverage 98.60% 98.61%
=======================================
Files 211 211
Lines 7696 7701 +5
Branches 1749 1751 +2
=======================================
+ Hits 7589 7594 +5
Misses 107 107
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adder now hides when the escape key is pressed. (WCAG 2.1 criterion 1.4.13)
Note: Low priority
fixes hypothesis/product-backlog#1128
relates to hypothesis/product-backlog#1114