Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only submit on public annotation activity in Canvas #1352

Closed
7 tasks
chrisshaw opened this issue Apr 29, 2022 · 0 comments · Fixed by hypothesis/lms#3956
Closed
7 tasks

Only submit on public annotation activity in Canvas #1352

chrisshaw opened this issue Apr 29, 2022 · 0 comments · Fixed by hypothesis/lms#3956
Assignees
@lyzadanger
Labels
Frontend Issues that include frontend work product

Comments

@chrisshaw
Copy link

chrisshaw commented Apr 29, 2022 •
edited

As an instructor, I only want to see submissions when they occur with meaningful activity, so that I am not confused when I go into check the submission.

After completing hypothesis/lms#3647 (:tada:) we send submissions for highlights and private annotations. We should only send them for new annotations (or replies) and edited annotations (or replies).

Flow

After opening an assignment in Canvas...

  • When I add a highlight, I do not submit
  • When I add a private annotation, I do not submit
  • I continue posting publicly, and everything works as expected
    • When I add an annotation, I submit
    • When I add a second annotation, I do not submit
    • I close the app and re-open it. When I reply to my annotation, I submit
    • I close the app and re-open it again. When I edit my annotation, I submit
@chrisshaw chrisshaw changed the title Only submit on public annotation activity Only submit on public annotation activity in Canvas Apr 29, 2022
@lyzadanger lyzadanger added the Frontend Issues that include frontend work label May 3, 2022
@lyzadanger lyzadanger self-assigned this May 16, 2022
lyzadanger added a commit to hypothesis/lms that referenced this issue May 16, 2022
@lyzadanger
Canvas: Only submit for grading if annotation is shared
084a3ee 
Update grading submission such that an empty grading submission is only
made if annotation activity pertains to a shared annotation.

Fixes hypothesis/product-backlog#1352
Fixes hypothesis/client#4484
@lyzadanger lyzadanger mentioned this issue May 16, 2022
Merged
lyzadanger added a commit to hypothesis/lms that referenced this issue May 17, 2022
@lyzadanger
Canvas: Only submit for grading if annotation is shared
2c4c1cb 
Update grading submission such that an empty grading submission is only
made if annotation activity pertains to a shared annotation.

Fixes hypothesis/product-backlog#1352
Fixes hypothesis/client#4484
marcospri pushed a commit to hypothesis/lms that referenced this issue May 19, 2022
@lyzadanger @marcospri
Canvas: Only submit for grading if annotation is shared
91116af 
Update grading submission such that an empty grading submission is only
made if annotation activity pertains to a shared annotation.

Fixes hypothesis/product-backlog#1352
Fixes hypothesis/client#4484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyzadanger lyzadanger

Labels
Frontend Issues that include frontend work product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Canvas: Only submit for grading if annotation is shared hypothesis/lms
2 participants
@lyzadanger @chrisshaw