Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-context and share links made on EPUBs do not work as expected #1356

Open
mattdricker opened this issue May 6, 2022 · 1 comment
Open

In-context and share links made on EPUBs do not work as expected #1356

mattdricker opened this issue May 6, 2022 · 1 comment
Labels
bug S4

Comments

@mattdricker
Copy link

mattdricker commented May 6, 2022 •
edited by chrisshaw

Related

EPUBS

Related to #1356

Related to #709

PDFs

Related to #1358

Related to #1360

Bug report form

Reported by user https://app.hubspot.com/contacts/6291320/ticket/899698951/

Note that I haven't made an exhaustive survey of epub documents, but this issue occurs at at least 2 major providers: https://www.fulcrum.org/ & https://bookshelf.vitalsource.com/

Steps to reproduce

  1. Open a book at https://www.fulcrum.org/ E.g. https://www.fulcrum.org/epubs/0r967596b (note, they embed Hypothesis in their ereader)
  2. Annotate some text
  3. Note the share URL or the in-context URL from activity page

Expected behaviour

Share URL should open appropriate page and annotation in document.

Actual behaviour

The share or in-context URL points to a raw xhtml file, which is not expected or visitable by most users.

Additional details

You can see this on 2 annotation from May 6, 2022 I have posted to the Hypothesis Working group.
Screen Shot 2022-05-06 at 3 37 55 PM

One is located at https://bookshelf.vitalsource.com/reader/books/L-999-74211/epubcfi/6/4%5Bidloc_001.xhtml-itemref%5D!/4%5Beid12%5D/2%5Beid13%5D/2%5Beid14%5D
which provides a share URL of https://hyp.is/cEG9Us1zEeywc1MMZMsCiA/jigsaw.vitalsource.com/books/L-999-74211/epub/OPS/loc_001.xhtml

The other at https://www.fulcrum.org/epubs/0r967596b#/6/20[Chung-0010]!/4/2[ch01]/2[header0101]/2/2[p1]/1:0
which provides a share URL of https://hyp.is/Nbox1M1xEeywah9pdqCIiQ/www.fulcrum.org/epubs/0r967596b/OEBPS/Chung-0010.xhtml

A previous similar issue was reported here: #709

Notes

From related issue #1360 , this may be related to which URL we use
@chrisshaw chrisshaw added the bug label May 15, 2022
This was referenced Jun 13, 2022
Open
Open
Open
@robertknight
Copy link
Member

The problem has been solved for VitalSource, and we can apply the pattern to other ebook readers in future, as well as the migration tools that we developed for VitalSource. See the issues and project document linked on https://github.com/orgs/hypothesis/projects/96. Making this work requires ebook reader-specific changes, therefore what we did for VitalSource won't help Fulcrum.

We have a couple of options here:

  1. Redefine this issue to be specifically about Fulcrum
  2. Close this issue as completed for VitalSource, and open a new one for any other ebook providers that we want to roll this out to in future.

@nairiboo nairiboo added the S4 label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug S4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robertknight @chrisshaw @mattdricker @nairiboo