Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages should make it clear what field(s) have error(s) #10516

Closed
tublitzed opened this issue Apr 29, 2021 · 3 comments
Closed

Error messages should make it clear what field(s) have error(s) #10516

tublitzed opened this issue Apr 29, 2021 · 3 comments
Labels
component:user_profile neverstale state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.

Comments

@tublitzed
Copy link

Describe the problem and steps to reproduce it:

On this page: https://addons.mozilla.org/en-US/firefox/users/edit

I went to rename my username and got a "this field cannot be null" error at the top. No fields were highlighted. A bunch were empty though.

So...I filled them all in with a single character. Now, I see a "Ensure this field has at least 2 characters."

What field? As a user, I would have an easier time editing my account if I understood which fields had errors.

Guessing maybe we used to have field highlighting here and now it's missing?

What happened?

Errors with unexplained linkage to form fields.

What did you expect to happen?

Able to edit my profile without guessing which field has an error.

Anything else we should know?

Screen Shot 2021-04-29 at 5 33 01 PM
@willdurand
Copy link
Member

willdurand commented Apr 29, 2021 •
edited

I think you have privilege on AMO, seeing the "reviewer name" field. This is the field that throws the error because all other fields are optional (except display name). There should be an asterisk on the reviewer name but we probably missed that given that it does not appear for most users.

As for the error messages, I think we have issues for what you suggested. It likely requires some API work before we can update the UI, though.

@willdurand
Copy link
Member

Maybe related: #9217

@willdurand willdurand self-assigned this Jun 9, 2021
@willdurand willdurand removed their assignment Jun 22, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Jan 3, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:user_profile neverstale state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bobsilverberg @willdurand @tublitzed