Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how we are using User Agent strings #10584

Closed
willdurand opened this issue May 12, 2021 · 1 comment
Closed

Document how we are using User Agent strings #10584

willdurand opened this issue May 12, 2021 · 1 comment
Labels
component:documentation neverstale qa:not_needed state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.

Comments

@willdurand
Copy link
Member

willdurand commented May 12, 2021 •
edited

We should document how we are using User Agent strings in addons-frontend to have a better understanding of our dependency to UA strings in case UA strings change in the future.

For instance, we know it's mainly used for compatibility checks and this happens on the server when possible. Compatibility checks are used to determine whether an add-on can be installed on FF and the UI of a detail page can be updated to reflect this state (notices/warnings, install button, etc.). The "version" of the browser in the UA string is therefore important.

We also use UA strings for non-Firefox messages but we only need to know the OS and browser names.

Is there any other use case?
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. If you think this bug should stay open, please comment on the issue with further details. Thank you for your contributions.

@stale stale bot added the state:stale Issues marked as stale. These can be re-opened should there be plans to fix them. label Jan 3, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:documentation neverstale qa:not_needed state:stale Issues marked as stale. These can be re-opened should there be plans to fix them.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bobsilverberg @willdurand