New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag filter is not visible in the search results #10789
Comments
@eviljeff I filed this bug as a follow-up to your demo at the Add-ons Show and Tell. I cannot edit the project on this issue, but it should be associated with https://github.com/orgs/mozilla/projects/158 |
I don't think we expose all the possible filters on purpose, and we should probably not update the page title if the filter cannot be used without manually editing the URL. cc @jvillalobos |
we're going to be linking to the search pages with |
We should probably do that same thing we do for categories, where using the search box removes the category filter. |
Do you have some example urls? They only differences I see on a search vs. category page is we don't show the add-on type filter (because categories are already per add-on type) |
What I mean is this:
I suggest we do the same for tags. |
I'm going to aim to implement this in a similar way to category pages - with a specific url (e.g. https://addons.mozilla.org/firefox/extensions/tag/privacy/) that should be better for SEO. |
|
ha right, I think we need a new issue specific to that. Quoting @jvillalobos above:
It's only about adding some more localized strings (and tests). |
Yep, I'm aware - I started with the intention of having it under /extensions/ or /themes/ but I realised it was more like /search/, that isn't under an add-on type. |
and what @willdurand said about supporting more combinations - can we have a follow-up issue please? |
Filed #10847 as a follow up |
The list of search results can be filtered by tag, but this is not apparent from the UI.
For example, view the list of add-ons tagged
privacy
by visiting:https://addons.allizom.org/en-US/firefox/search/?tag=privacy
Search for something else, e.g. "privacy". The URL becomes
https://addons.allizom.org/en-US/firefox/search/?q=privacy&tag=privacy
Both pages are similar, except for the list of results. The visibility of the tag filter should be improved, e.g. by changing
N results found for "(query)"
to `N results found for "(query)" filtered by "(tag, optionally with link to full list of add-ons by tag)", and/or by showing the tag filter(s) in the "Filter results" section at the left.The text was updated successfully, but these errors were encountered: