Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag filter is not visible in the search results #10789

Closed
Rob--W opened this issue Jul 22, 2021 · 12 comments · Fixed by #10820
Closed

Tag filter is not visible in the search results #10789

Rob--W opened this issue Jul 22, 2021 · 12 comments · Fixed by #10820

Comments

@Rob--W
Copy link
Member

Rob--W commented Jul 22, 2021

The list of search results can be filtered by tag, but this is not apparent from the UI.

For example, view the list of add-ons tagged privacy by visiting:
https://addons.allizom.org/en-US/firefox/search/?tag=privacy
Search for something else, e.g. "privacy". The URL becomes
https://addons.allizom.org/en-US/firefox/search/?q=privacy&tag=privacy

Both pages are similar, except for the list of results. The visibility of the tag filter should be improved, e.g. by changing N results found for "(query)" to `N results found for "(query)" filtered by "(tag, optionally with link to full list of add-ons by tag)", and/or by showing the tag filter(s) in the "Filter results" section at the left.

@Rob--W
Copy link
Member Author

Rob--W commented Jul 22, 2021

@eviljeff I filed this bug as a follow-up to your demo at the Add-ons Show and Tell.

I cannot edit the project on this issue, but it should be associated with https://github.com/orgs/mozilla/projects/158

@eviljeff eviljeff added this to To do in Add-ons Q3 2021: Homepage Tag Shelves via automation Jul 22, 2021
@willdurand
Copy link
Member

I don't think we expose all the possible filters on purpose, and we should probably not update the page title if the filter cannot be used without manually editing the URL. cc @jvillalobos

@eviljeff
Copy link
Member

we're going to be linking to the search pages with ?tag=xxx in them soon, fwiw.

@jvillalobos
Copy link
Contributor

We should probably do that same thing we do for categories, where using the search box removes the category filter.

@eviljeff
Copy link
Member

We should probably do that same thing we do for categories, where using the search box removes the category filter.

Do you have some example urls? They only differences I see on a search vs. category page is we don't show the add-on type filter (because categories are already per add-on type)

@jvillalobos
Copy link
Contributor

What I mean is this:

I suggest we do the same for tags.

@eviljeff eviljeff self-assigned this Aug 3, 2021
@eviljeff
Copy link
Member

eviljeff commented Aug 3, 2021

I'm going to aim to implement this in a similar way to category pages - with a specific url (e.g. https://addons.mozilla.org/firefox/extensions/tag/privacy/) that should be better for SEO.

@eviljeff eviljeff added this to the 2021.08.12 milestone Aug 4, 2021
@eviljeff eviljeff moved this from To do to In progress in Add-ons Q3 2021: Homepage Tag Shelves Aug 5, 2021
This was referenced Aug 5, 2021
@eviljeff eviljeff modified the milestones: 2021.08.12, 2021.08.19 Aug 10, 2021
Add-ons Q3 2021: Homepage Tag Shelves automation moved this from In progress to Done Aug 11, 2021
@ioanarusiczki
Copy link

@eviljeff

@willdurand
Copy link
Member

Reading Tag filter is not visible in the search results #10789 (comment) , similar to a search result as addons-dev.allizom.org/en-US/firefox/extensions/category/photos-music-videos/?q=photos I tried for tags addons-dev.allizom.org/en-US/firefox/tag/ad%20blocker/?q=ad%20block. As mentioned above, I added the query manually since this is not directly supported. Message for the result is: 1 result found for "ad block" - should it be more detailed and specify the tag too?

ha right, I think we need a new issue specific to that. Quoting @jvillalobos above:

So, while it's possible to mix categories and search by manipulating URLs, it's not something we directly support (though for categories we do support more specific titles: 126 extensions found for "photos" in Photos, Music & Videos).

It's only about adding some more localized strings (and tests).

@eviljeff
Copy link
Member

* tag URLs won't work if /extensions/ is also added so perhaps the current format is expected but your comment mentioned this:
  https://addons.mozilla.org/firefox/extensions/tag/privacy/

Yep, I'm aware - I started with the intention of having it under /extensions/ or /themes/ but I realised it was more like /search/, that isn't under an add-on type.

@eviljeff
Copy link
Member

and what @willdurand said about supporting more combinations - can we have a follow-up issue please?

@AlexandraMoga
Copy link

Filed #10847 as a follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants