HomePhabricator

Raise ConfigException when using incorrect Column syntax

Tags
None
Referenced Files
None
Subscribers
None

Description

Raise ConfigException when using incorrect Column syntax

The syntax for the columns parameter is restricted,
only supporing Lxy, Dxy and Pxy (and qualifiers).

Using incorrect syntax resulted in an uncaught, scary exception [1].

Let's properly raise an exception in ColumnConfigMaker,
catch it in parse_config_properties and re-raise as ConfigException.

Bug: T284183

[1] <class 'AttributeError'> 'NoneType' object has no attribute 'get_key'

Details

Provenance
JeanFredAuthored on Oct 25 2021, 8:13 PM
Parents
R2566:5526cb378d58: Deprecate get_[qualifier|property]_info to use generalized queries
Branches
Unknown
Tags
Unknown
ChangeId
None