Page MenuHomePhabricator

Task rename notifications are hard to understand due to missing markup for old and new title
Closed, ResolvedPublic

Description

Screen Shot 2017-05-25 at 8.48.03 PM.png (80×2 px, 70 KB)

Task rename notifications used to have quotes around the old and new names. These went away with yesterday's update, which makes them harder to understand, especially with long titles.

Also the duplication of new titles ([User] renamed [T##### new name] from [old name] to [new name].) has always seemed unnecessary. Couldn't it just be something like [User] renamed [T##### new name] from [old name].?

Event Timeline

This got fixed by removing the duplication and using italic for the previous title.

This definitely doesn't seem to be fixed:

Screen Shot 2017-06-16 at 9.36.59 PM.png (68×2 px, 40 KB)

Aklapper renamed this task from Task rename notifications are hard to understand to Task rename notifications are hard to understand due to missing markup for old and new title.Jun 17 2017, 10:09 PM

This definitely doesn't seem to be fixed:

Which browser is that, and especially which broken font?

<a href="/p/Aklapper/" class="phui-handle phui-link-person">Aklapper</a> renamed this task from <span class="phui-timeline-value">Task rename notifications are hard to understand</span> to <span class="phui-timeline-value">Task rename notifications are hard to understand due to missing markup for old and new title</span>.

And .phui-timeline-value is defined as font-style: italic;.

I believe this will be resolved by the 2019 Week 13 upstream release. See https://secure.phabricator.com/D20310 for particulars and screenshots.

Closing as per last comment as that version is now deployed on phabricator.wikimedia.org. Please reopen if this is still a problem.