Page MenuHomePhabricator
Create Task
Maniphest T174018

Port Minerva's 7 Ruby-based browser tests to Selenium Node.js
Closed, DeclinedPublic
Actions

Description

Note: This task is large and it's not clear how to break it down. https://www.mediawiki.org/wiki/User_talk:Jdlrobson/Experiences_porting_Ruby_browser_tests_to_NodeJs provides a good summary of the problems we faced when trying to do this before. We may want to tackle one of these tests per time (to be created as part of analysis).

Background

MinervaNeue has7 browser test.
Minerva has been setup so that you can run browser tests using check experimental
A patch has been begun in WIP Port Minerva's browser tests to Selenium

Acceptance criteria

  • Rewrite all tests into Node.js
  • Make the experimental job the default. Drop the old Ruby job.

Details

SubjectRepoBranchLines +/-
Fixed search_loggedin.js Selenium browser testmediawiki/skins/MinervaNeuemaster+14 -15
jjb: rm selenium-MinervaNeue and selenium-QuickSurveysintegration/configmaster+0 -71
Daily Minerva Selenium Node.js jobintegration/configmaster+5 -0
WIP Port Minerva's browser tests to Seleniummediawiki/skins/MinervaNeuemaster+700 -453
QA: Speed up browser tests by not unnecessarily opting into betamediawiki/skins/MinervaNeuemaster+3 -4
QA: Remove test not adding valuemediawiki/skins/MinervaNeuemaster+0 -27
Run mediawiki-core-qunit-selenium-jessie for MinervaNeueintegration/configmaster+2 -0
Run Selenium tests for skinsmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT162936 Improve developer happiness in reading web maintained extensions
 DeclinedNoneT162256 [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions
 ResolvedJdforrester-WMFT225031 On CI Jenkins, audit worker labels and remove unused ones
 DeclinedNoneT174018 Port Minerva's 7 Ruby-based browser tests to Selenium Node.js
 ResolvedJdlrobsonT181509 [Spike 8hrs] Document missing (?) features of the Node.js automated browser testing stack
 ResolvedJdlrobsonT190710 Minerva Ruby and Node.js browser tests running side by side
 ResolvedNoneT179190 Run Selenium Cucumber tests in CI
 ResolvedawightT199116 Quibble should run `npm install` and `npm run selenium-test` for each extension/skin that has Selenium tests
 DuplicateLegoktmT225330 Commit package-lock.json files everywhere
 ResolvedhasharT229033 wdio-cucumber-framework fails on NodeJS due to fibers@2.x under nodejs10
 ResolvedzeljkofilipinT232495 selenium-daily-beta-CirrusSearch is broken
 ResolvedhasharT229065 Quibble extension selenium test fails with: gyp ERR! stack Error: Can't find Python executable "python", you can set the PYTHON env variable.
 OpenNoneT199939 Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature
 ResolvedPRODUCTION ERRORJdlrobsonT219920 CI tests disabled: Steps that require login are disabled and should be restored.
 ResolvedJdlrobsonT220658 Minerva browser tests must be configured to run on the mobile domain
 ResolvedJdrewniakT220659 Enable a MobileFrontend daily Selenium build
 OpenNoneT221579 Port "Page actions menu when anonymous.Receive notification message - Watchlist Icon" browser test to Node.js from Ruby
 OpenNoneT245250 Review MinervaNeue Selenium tests
 ResolvedNoneT246881 +2 for Edtadros for mediawiki/skins/MinervaNeue
 ResolvedzeljkofilipinT251543 MinervaNeue Selenium tests fail when targeting MediaWiki-Docker

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.Nov 28 2017, 10:34 AM
phuedx added a subtask: T181509: [Spike 8hrs] Document missing (?) features of the Node.js automated browser testing stack.Nov 28 2017, 2:33 PM
Jdlrobson moved this task from Triaged but Future to Needs Prioritization on the Web-Team-Backlog board.Nov 29 2017, 5:36 PM
zeljkofilipin moved this task from Deep work 🌊 to Q4 👔 on the User-zeljkofilipin board.Nov 29 2017, 6:36 PM
phuedx closed subtask T181509: [Spike 8hrs] Document missing (?) features of the Node.js automated browser testing stack as Resolved.Nov 29 2017, 6:40 PM
zeljkofilipin removed a project: User-zeljkofilipin.Nov 29 2017, 6:50 PM
• bmansurov unsubscribed.Dec 22 2017, 9:46 PM
Jdlrobson lowered the priority of this task from High to Medium.Feb 7 2018, 7:12 PM

Reflecting reality. Per https://www.mediawiki.org/wiki/User:Jdlrobson/Experiences_porting_Ruby_browser_tests_to_NodeJs (T181509) and the size of the browser test suite , we don't have the time to work on this right now.

Jdlrobson changed the task status from Open to Stalled.Feb 7 2018, 7:13 PM
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson changed the task status from Stalled to Open.Mar 26 2018, 4:43 PM
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson added a project: User-Jdlrobson.
gerritbot added a comment.Mar 26 2018, 6:25 PM

Change 421960 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] QA: Remove test not adding value

https://gerrit.wikimedia.org/r/421960

gerritbot added a project: Patch-For-Review.Mar 26 2018, 6:25 PM

Change 421961 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] QA: Speed up browser tests by not unnecessarily opting into beta

https://gerrit.wikimedia.org/r/421961

zeljkofilipin added a project: User-zeljkofilipin.Mar 27 2018, 11:30 AM
zeljkofilipin moved this task from Q4 👔 to Watching 📺 on the User-zeljkofilipin board.
gerritbot added a comment.Mar 27 2018, 1:44 PM

Change 421960 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] QA: Remove test not adding value

https://gerrit.wikimedia.org/r/421960

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Mar 27 2018, 2:00 PM
Jdlrobson renamed this task from Port Minerva's browser tests to Selenium Node.js to [EPIC] Port Minerva's browser tests to Selenium Node.js.Mar 27 2018, 4:49 PM
Jdlrobson added a project: Epic.
ovasileva subscribed.Mar 27 2018, 4:49 PM

Changing title for epic until we can split up the work more appropriately

ovasileva moved this task from Triaged but Future to Epics/Goals on the Web-Team-Backlog board.Mar 27 2018, 4:50 PM
gerritbot added a comment.Apr 5 2018, 2:37 PM

Change 421961 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] QA: Speed up browser tests by not unnecessarily opting into beta

https://gerrit.wikimedia.org/r/421961

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)); removed MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Apr 5 2018, 3:00 PM
gerritbot added a comment.Apr 10 2018, 4:31 PM

Change 373902 abandoned by Zfilipin:
WIP Port Minerva's browser tests to Selenium

Reason:
Replaced with https://gerrit.wikimedia.org/r/#/c/423648/

https://gerrit.wikimedia.org/r/373902

zeljkofilipin mentioned this in T190710: Minerva Ruby and Node.js browser tests running side by side.Apr 10 2018, 4:33 PM
Jdlrobson changed the status of subtask T190710: Minerva Ruby and Node.js browser tests running side by side from Open to Stalled.Jun 4 2018, 5:31 PM
zeljkofilipin moved this task from Watching 📺 to Backlog 🪒 on the User-zeljkofilipin board.Jun 15 2018, 12:08 PM
Jdlrobson removed a project: Patch-For-Review.Jun 27 2018, 8:38 PM
zeljkofilipin removed a project: User-zeljkofilipin.Jun 28 2018, 1:20 PM
zeljkofilipin changed the task status from Open to Stalled.Jun 28 2018, 1:22 PM

Blocked on T190710: Minerva Ruby and Node.js browser tests running side by side.

• Jhernandez unsubscribed.Jun 29 2018, 4:36 PM
zeljkofilipin changed the status of subtask T190710: Minerva Ruby and Node.js browser tests running side by side from Stalled to Open.Jul 6 2018, 4:43 PM
Jdlrobson mentioned this in T162936: Improve developer happiness in reading web maintained extensions.Jul 9 2018, 4:29 PM
zeljkofilipin mentioned this in T183162: Patches in Gerrit deleting Selenium+Ruby tests for repositories that still have them.Jul 13 2018, 12:05 PM
zeljkofilipin changed the status of subtask T190710: Minerva Ruby and Node.js browser tests running side by side from Open to Stalled.Jul 17 2018, 9:01 AM
Jdlrobson changed the status of subtask T190710: Minerva Ruby and Node.js browser tests running side by side from Stalled to Open.Apr 5 2019, 4:46 PM
Jdlrobson added a subtask: T199939: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature.Apr 5 2019, 10:44 PM
Jdlrobson mentioned this in T199939: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature.Apr 5 2019, 11:16 PM
Jdlrobson changed the task status from Stalled to Open.Apr 5 2019, 11:21 PM
Jdlrobson added a subtask: T219920: CI tests disabled: Steps that require login are disabled and should be restored..
zeljkofilipin added a project: User-zeljkofilipin.Apr 8 2019, 9:06 AM
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
gerritbot added a comment.Apr 8 2019, 11:57 PM

Change 502355 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[integration/config@master] Daily Minerva Selenium Node.js job

https://gerrit.wikimedia.org/r/502355

gerritbot added a project: Patch-For-Review.Apr 8 2019, 11:57 PM

Change 502356 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[integration/config@master] Run Node.js browser tests in MobileFrontend

https://gerrit.wikimedia.org/r/502356

gerritbot added a comment.Apr 9 2019, 8:56 PM

Change 502355 merged by jenkins-bot:
[integration/config@master] Daily Minerva Selenium Node.js job

https://gerrit.wikimedia.org/r/502355

Jdlrobson closed subtask T190710: Minerva Ruby and Node.js browser tests running side by side as Resolved.Apr 11 2019, 5:57 PM
Jdlrobson closed subtask T220658: Minerva browser tests must be configured to run on the mobile domain as Resolved.
greg unsubscribed.Apr 11 2019, 9:24 PM
Jdlrobson closed subtask T219920: CI tests disabled: Steps that require login are disabled and should be restored. as Resolved.May 1 2019, 8:39 PM
Jdlrobson closed subtask T220659: Enable a MobileFrontend daily Selenium build as Resolved.
Jdlrobson mentioned this in T220755: [Spike] Have a discussion around Minerva selenium browser test architecture.May 2 2019, 11:21 PM
zeljkofilipin removed a project: User-zeljkofilipin.May 10 2019, 10:49 AM
Jdlrobson mentioned this in T162256: [EPIC] Port Selenium tests from Ruby to Node.js on Reading Web extensions.Aug 1 2019, 8:22 PM
gerritbot added a comment.Oct 16 2019, 9:12 PM

Change 543697 had a related patch set uploaded (by Edward Tadros; owner: Edward Tadros):
[mediawiki/skins/MinervaNeue@master] Fixed search_loggedin.js Selenium browser test

https://gerrit.wikimedia.org/r/543697

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 16 2019, 9:12 PM
hashar mentioned this in T225031: On CI Jenkins, audit worker labels and remove unused ones.Dec 10 2019, 2:13 PM
hashar added a parent task: T225031: On CI Jenkins, audit worker labels and remove unused ones.
hashar mentioned this in T236576: Move all Wikimedia CI (WMCS integration project) instances from jessie to stretch.
gerritbot added a comment.Dec 12 2019, 2:00 PM

Change 556252 had a related patch set uploaded (by Hashar; owner: Jforrester):
[integration/config@master] jjb: rm selenium-MinervaNeue and selenium-QuickSurveys

https://gerrit.wikimedia.org/r/556252

gerritbot added a comment.Dec 12 2019, 2:02 PM

Change 556252 merged by jenkins-bot:
[integration/config@master] jjb: rm selenium-MinervaNeue and selenium-QuickSurveys

https://gerrit.wikimedia.org/r/556252

zeljkofilipin added a subtask: T245250: Review MinervaNeue Selenium tests.Feb 14 2020, 12:59 PM
Jdlrobson moved this task from Inbox to Blocked on the User-Jdlrobson board.Mar 2 2020, 10:48 PM
gerritbot added a comment.Apr 29 2020, 3:35 PM

Change 543697 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fixed search_loggedin.js Selenium browser test

https://gerrit.wikimedia.org/r/543697

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.31; 2020-05-05).Apr 29 2020, 4:00 PM
Jdlrobson mentioned this in T280901: MinervaNeue legacy ruby browser tests need to be updated to work on buster/ruby2.5.Apr 26 2021, 5:37 PM
Jdlrobson renamed this task from [EPIC] Port Minerva's browser tests to Selenium Node.js to Port Minerva's 7 Ruby-based browser tests to Selenium Node.js.Apr 26 2021, 6:54 PM
Jdlrobson removed a project: Epic.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Epics/Goals to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Apr 28 2021, 10:17 PM
Stashbot mentioned this in T177260: Rewrite disabled MobileFrontend browser tests to phpunit tests and Node.js browser tests.May 14 2021, 2:16 AM

Mentioned in SAL (#wikimedia-releng) [2021-05-14T02:16:53Z] <James_F> Zuul: [mediawiki/skins/MinervaNeue] Drop Ruby-based selenium job T174018 T177260 T280901

Jdforrester-WMF subscribed.May 14 2021, 2:21 AM

Note: These tests still exist in the repo, but are no longer run.

Jdlrobson moved this task from TODO to Tracking on the MinervaNeue board.Sep 3 2021, 5:12 PM
Jdlrobson edited projects, added MinervaNeue (Tracking); removed MinervaNeue.
zeljkofilipin added a project: Ruby.Sep 17 2021, 10:12 AM
Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog (Tracking) board.Sep 30 2021, 9:27 PM
LGoto removed a project: Web-Team-Backlog (Tracking).Nov 9 2021, 4:23 PM
zeljkofilipin added a project: User-zeljkofilipin.Apr 7 2022, 11:31 AM
zeljkofilipin added a subscriber: Edtadros.

@Jdlrobson @Edtadros Is this resolved by 776218?

zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.Apr 7 2022, 11:31 AM
Jdlrobson closed this task as Declined.Apr 7 2022, 2:41 PM

These never got ported so have been deleted. Edward has a spreadsheet if we ever want to restore them.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL