- the open product questions about the future of this feature in T24660 (should we show to anons) T204834 (should we show on pages without categories) or should we redesign it (T142124).
- its lack of unit tests (T205126)
- confusing behaviour (T224820)
- neglected longstanding bugs (T224819, T225556)
We should remove it.
In AMC mode we make categories available to users. A blue categories button shows at the bottom of the page and clicking it opens a category overlay that lists categories on the page in two tabs "content based" and "organizational"
This is a pleasant way to view categories on a mobile browser. On long lists however it can be hard to tell whether appropriate categories are available.
That said it has various problems and we are doing a bad job of maintaining it.
Removing this feature reduces our maintenance burden and adds support for editor gadgets that do a far better job than us.
TODO
Minerva changes
- Remove the code resources/skins.minerva.options/categories.js and the dependency to MobileFrontend
- The browser test tests/selenium/specs/category.js is removed (and associated code)
- The getCategoryButton code is removed inside includes/Skins/SkinMinerva.php
- Drop the call to hasCategoryLinks inside getSecondaryActions - $buttons['categories'] should never be set.
- SkinMinerva::getTemplateData should set the template value html-categories to empty string is hasCategoryLinks is true.
- Add {{{html-categories}}} to skin.mustache underneath the element #page-secondary-actions
MobileFrontend changes (phase 2)
- Remove src/mobile.startup/categoryOverlay.js
- Remove src/mobile.categories.overlays/ folder and associated code
- Remove associated i18n messages.
QA
Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain
In logged in / AMC: There is a category box at the bottom of the page
In logged in with AMC disabled: There are no category box at the bottom of the page.
When logged out: There are no category box at the bottom of the page.
QA Results - Beta
AC | Status | Details |
---|---|---|
1 | ✅ | T246049#7163795 |
2 | ❌ | T246049#7163795 |
3 | ✅ | T246049#7163795 |
QA Results - Beta
AC | Status | Details |
---|---|---|
1 | ✅ | T246049#7168407 |
2 | ✅ | T246049#7168407 |
3 | ✅ | T246049#7168407 |
QA Results - Prod
AC | Status | Details |
---|---|---|
1 | ✅ | T246049#7174093 |
2 | ✅ | T246049#7174093 |
3 | ✅ | T246049#7174093 |