Page MenuHomePhabricator
Create Task
Maniphest T247915

Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs stabilize API
Closed, ResolvedPublic
Actions

Description

boolean watch= was deprecated in favour of watchlist= way back in 1.17 (T24944), but FlaggedRevs still uses watch=.

Details

SubjectRepoBranchLines +/-
Update ApiStabilizeGeneral and ApiStabilizeProtect watchlist handlingmediawiki/extensions/FlaggedRevsmaster+65 -16
Customize query in gerrit

Related Objects

Event Timeline

Amorymeltzer created this task.Mar 18 2020, 1:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2020, 1:58 AM
Amorymeltzer triaged this task as Lowest priority.Mar 18 2020, 1:59 AM
DannyS712 subscribed.Mar 18 2020, 2:42 AM
DannyS712 claimed this task.Mar 18 2020, 2:57 AM
DannyS712 raised the priority of this task from Lowest to Medium.
DannyS712 added a project: MediaWiki-Action-API.

Specifically, ApiStabilizeGeneral and ApiStabilizeProtect need to be updated
See https://www.mediawiki.org/wiki/Special:Code/MediaWiki/r64197 for some background and migrations (also available at https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/88df448d362b1c331bfdb8de69d1818bf6e5316e%5E%21/)

Restricted Application added projects: User-DannyS712, Platform Engineering. · View Herald TranscriptMar 18 2020, 2:57 AM
gerritbot added a comment.Mar 18 2020, 2:58 AM

Change 580602 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Update ApiStabilizeGeneral and ApiStabilizeProtect watchlist handling

https://gerrit.wikimedia.org/r/580602

gerritbot added a project: Patch-For-Review.Mar 18 2020, 2:58 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Mar 18 2020, 3:07 AM
DannyS712 moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.
Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Mar 18 2020, 1:23 PM
Anomie moved this task from Inbox to External Code Review Needed on the Platform Team Workboards (Clinic Duty Team) board.
daniel moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (Clinic Duty Team) board.Apr 8 2020, 11:50 AM
DannyS712 added a project: User-notice.Apr 8 2020, 12:48 PM
DannyS712 moved this task from To Triage to Not ready to announce on the User-notice board.
CCicalese_WMF edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Team Workboards (Clinic Duty Team).Jul 31 2020, 5:04 PM
CCicalese_WMF moved this task from External Code Review Needed to External Code Review In Progress on the Platform Team Workboards (External Code Reviews) board.
gerritbot added a comment.Aug 29 2020, 2:40 AM

Change 580602 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Update ApiStabilizeGeneral and ApiStabilizeProtect watchlist handling

https://gerrit.wikimedia.org/r/580602

DannyS712 closed this task as Resolved.Aug 29 2020, 2:43 AM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Not ready to announce to To Triage on the User-notice board.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Aug 29 2020, 3:00 AM
Johan subscribed.Aug 31 2020, 2:08 PM

@DannyS712 How would you phrase this in Tech News?

(I see in Gerrit that there are no known callers (or am I misreading that comment?), if that's the case, which purpose do you think mentioning it serves? So I get the context here.)

DannyS712 added a comment.Aug 31 2020, 7:00 PM
In T247915#6423303, @Johan wrote:

@DannyS712 How would you phrase this in Tech News?

(I see in Gerrit that there are no known callers (or am I misreading that comment?), if that's the case, which purpose do you think mentioning it serves? So I get the context here.)

The two api modules used to have watch parameters to either watch the page, or do nothing. Now they have watchlist parameters, with the options being watch, unwatch, preferences (the default) and nochange, and the old watch parameters are deprecated.

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Sep 3 2020, 9:23 PM
Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Sep 8 2020, 12:53 PM
Krinkle renamed this task from Deprecate watch in favor of watchlist in stabilize API to Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs ApiStabilizeGeneral.Sep 9 2020, 2:56 PM
Krinkle renamed this task from Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs ApiStabilizeGeneral to Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs stabilize API.
Krinkle updated the task description. (Show Details)
Amorymeltzer added a comment.Sep 20 2020, 2:12 PM

FWIW, it looks apihelp-stabilize-param-watchlist needs adding to all the i18n pages. Presumably it can just copy the text used everywhere by apihelp-*-param-watchlist in core?

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL