⚓ T249674 Have all Wikimedia production extensions and skins in the CI gate

Subject	Repo	Branch	Lines +/-
zuul: [mediawiki/extensions/WikiLove] Add to gate	integration/config	master	+2 -0
Zuul: Add PageViewInfo and Graph to gated extensions	integration/config	master	+4 -0
Zuul: Add PageImages to the MediaWiki gated extension set	integration/config	master	+2 -0
Zuul: Add GrowthExperiments to the MediaWiki gated extension set	integration/config	master	+2 -0
Zuul: Add Disambiguator to the MediaWiki gated extension set	integration/config	master	+2 -0
gate: Add BetaFeatures	integration/config	master	+2 -0
layout: Add WikimediaMessages to the gate	integration/config	master	+2 -0
layout: Add Kartographer to the gate	integration/config	master	+2 -0

Status	Subtype	Assigned	Task
Open		None	T249674 Have all Wikimedia production extensions and skins in the CI gate
Resolved		Addshore	T204153 Add more Wikibase extensions to gatedextensions
Open		None	T204252 Have dependencies of gated extensions in the gate
Resolved	PRODUCTION ERROR	Reedy	T198653 Add AntiSpoof to shared extension gate
Duplicate		None	T200976 Wikibase CI: wmf-quibble-vendor-mysql-hhvm-docker job should include Scribunto
Resolved		Jdforrester-WMF	T125050 [Task] Add Scribunto to extension-gate in CI
Resolved		Jdforrester-WMF	T126670 Have CI set `$wgScribuntoDefaultEngine = 'luasandbox` to speed up parser tests
Resolved		None	T128191 Wikibase Scribunto tests are failing, with the tests depending on configuration
Resolved		hoo	T128245 Use $this->getEngine() instead of Scribunto::newDefaultEngine()
Resolved		• chasemp	T162166 For contintcloud either add RAM or Swap to the instances
Resolved		hashar	T202030 CI: Minerva PHPUnit tests should be included in shared extension gate job
Declined		None	T321864 Add CentralAuth to the gated extensions list
Open		None	T238492 Figure out which production extensions have conflicting tests and fix them
Resolved		Umherirrender	T235783 CentralAuth tests failing if GlobalPreferences is loaded
Open		None	T86930 Add i18n related extensions to the CI gate
Resolved		Jdforrester-WMF	T225068 Add a PHPUnit group to skip test on gated CI runs
Resolved		Jdforrester-WMF	T251276 Add TwoColConflict to the "gated" extensions list in core
Open		None	T292288 Add examples extension to the CI gate
Declined		kostajh	T333541 Add CentralAuth to gated extensions
Resolved		kostajh	T333534 Add PageTriage to gated extensions
Resolved		taavi	T342062 Add WikiLove to gated extensions

Jdforrester-WMF created this task.Apr 8 2020, 12:55 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptApr 8 2020, 12:55 AM

Jdforrester-WMF added subtasks: T204252: Have dependencies of gated extensions in the gate, T125050: [Task] Add Scribunto to extension-gate in CI, T204153: Add more Wikibase extensions to gatedextensions.Apr 8 2020, 12:57 AM

Jdforrester-WMF added a subtask: T238492: Figure out which production extensions have conflicting tests and fix them.Apr 8 2020, 1:16 AM

Jdforrester-WMF added a subtask: T86930: Add i18n related extensions to the CI gate.Apr 8 2020, 9:29 PM

Jdforrester-WMF mentioned this in T225068: Add a PHPUnit group to skip test on gated CI runs.Apr 8 2020, 9:55 PM

Change 587848 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Add Kartographer to the gate

https://gerrit.wikimedia.org/r/587848

gerritbot added a project: Patch-For-Review.Apr 9 2020, 7:01 PM

Change 587848 merged by jenkins-bot:
[integration/config@master] layout: Add Kartographer to the gate

https://gerrit.wikimedia.org/r/587848

Jdforrester-WMF updated the task description. (Show Details)Apr 9 2020, 7:26 PM

Change 587858 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: Add WikimediaMessages to the gate

https://gerrit.wikimedia.org/r/587858

Change 587858 merged by jenkins-bot:
[integration/config@master] layout: Add WikimediaMessages to the gate

https://gerrit.wikimedia.org/r/587858

Jdforrester-WMF updated the task description. (Show Details)Apr 9 2020, 7:44 PM

Maintenance_bot removed a project: Patch-For-Review.Apr 9 2020, 8:10 PM

Jdforrester-WMF closed subtask T125050: [Task] Add Scribunto to extension-gate in CI as Resolved.Apr 17 2020, 9:13 PM

hashar added a subtask: T251276: Add TwoColConflict to the "gated" extensions list in core.May 3 2020, 9:15 PM

Change 596707 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] gate: Add BetaFeatures

https://gerrit.wikimedia.org/r/596707

gerritbot added a project: Patch-For-Review.May 15 2020, 5:33 PM

Change 596707 merged by jenkins-bot:
[integration/config@master] gate: Add BetaFeatures

https://gerrit.wikimedia.org/r/596707

Mentioned in SAL (#wikimedia-releng) [2020-05-15T17:48:07Z] <James_F> Zuul: Add BetaFeatures to the gate T249674

Jdforrester-WMF updated the task description. (Show Details)May 15 2020, 6:04 PM

Maintenance_bot removed a project: Patch-For-Review.May 15 2020, 6:10 PM

Jdforrester-WMF closed subtask T251276: Add TwoColConflict to the "gated" extensions list in core as Resolved.May 15 2020, 6:56 PM

Jdforrester-WMF updated the task description. (Show Details)

For consideration for MW-on-K8s.

Change 655097 had a related patch set uploaded (by Jforrester; owner: C. Scott Ananian):
[integration/config@master] Zuul: Add Disambiguator to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/655097

gerritbot added a project: Patch-For-Review.Jan 8 2021, 6:07 PM

Jdforrester-WMF mentioned this in T272170: "FlaggablePageTest::testPageDataFromTitle" erroring on patches in it and its many dependent repos.Jan 16 2021, 6:32 PM

Addshore closed subtask T204153: Add more Wikibase extensions to gatedextensions as Resolved.Jan 22 2021, 9:26 PM

Addshore mentioned this in T204153: Add more Wikibase extensions to gatedextensions.

thcipriani edited projects, added Release-Engineering-Team (thcipriani-workboard-fiddling); removed Release-Engineering-Team (CI & Testing services).Apr 20 2021, 1:03 AM

thcipriani moved this task from thcipriani-workboard-fiddling to Seen (ARCHIVE) on the Release-Engineering-Team board.Apr 20 2021, 1:05 AM

thcipriani edited projects, added Release-Engineering-Team; removed Release-Engineering-Team (thcipriani-workboard-fiddling).

thcipriani edited projects, added Release-Engineering-Team (Seen); removed Release-Engineering-Team.Apr 20 2021, 3:23 PM

Change 655097 merged by jenkins-bot:

[integration/config@master] Zuul: Add Disambiguator to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/655097

Mentioned in SAL (#wikimedia-releng) [2021-05-11T23:32:01Z] <James_F> Zuul: Add Disambiguator to the MediaWiki gated extension set T237538 T249674

Jdforrester-WMF updated the task description. (Show Details)May 11 2021, 11:33 PM

Change 687769 had a related patch set uploaded (by Jforrester; author: Kosta Harlan):

[integration/config@master] Zuul: Add GrowthExperiments to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/687769

Change 687769 merged by jenkins-bot:

[integration/config@master] Zuul: Add GrowthExperiments to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/687769

Mentioned in SAL (#wikimedia-releng) [2021-05-12T16:00:48Z] <James_F> Zuul: Add GrowthExperiments to the MediaWiki gated extension set T247507 T249674

Stashbot mentioned this in T247507: Scale: deploy Growth features to 100 wikis.May 12 2021, 4:00 PM

kostajh updated the task description. (Show Details)May 12 2021, 4:59 PM

In T249674#7082525, @gerritbot wrote:

Change 687769 merged by jenkins-bot:

[integration/config@master] Zuul: Add GrowthExperiments to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/687769

It looks like there's a problem because SuggestedEditsTest.php assumes that PageViewInfo extension is present, but it's not in the gate. See e.g. https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php72-docker/63679/console with stacktrace:

11:47:54 1) GrowthExperiments\Tests\HomepageModules\SuggestedEditsTest::testNoTopicFiltersWhenTopicMatchingDisabled
11:47:54 Error: Call to undefined method Mock_PageViewService_963a7339::supports()
11:47:54 
11:47:54 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:701
11:47:54 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:418
11:47:54 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:156
11:47:54 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:137
11:47:54 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:264
11:47:54 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:97
11:47:54 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/HomepageModules/SuggestedEditsTest.php:42
11:47:54 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108

PageImages is also not in gate but GrowthExperiments has that defined as a dependency in integration/config.
cc @DLynch

Change 690004 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

https://gerrit.wikimedia.org/r/690004

Change 690028 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Add PageImages to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/690028

Change 690004 abandoned by Kosta Harlan:

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

Reason:

https://gerrit.wikimedia.org/r/690004

Change 690004 restored by Jforrester:

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

https://gerrit.wikimedia.org/r/690004

Change 690028 merged by jenkins-bot:

[integration/config@master] Zuul: Add PageImages to the MediaWiki gated extension set

https://gerrit.wikimedia.org/r/690028

Change 690004 merged by jenkins-bot:

[integration/config@master] Zuul: Add PageViewInfo and Graph to gated extensions

https://gerrit.wikimedia.org/r/690004

Mentioned in SAL (#wikimedia-releng) [2021-05-12T19:32:06Z] <James_F> Zuul: Add PageImages, PageViewInfo, and Graph to MediaWiki gated extension set T249674

Jdforrester-WMF updated the task description. (Show Details)May 12 2021, 7:36 PM

Inductiveload added a subtask: T292288: Add examples extension to the CI gate.Oct 1 2021, 11:30 AM

akosiaris closed subtask T238492: Figure out which production extensions have conflicting tests and fix them as Invalid.Jan 9 2023, 4:53 PM

Jdforrester-WMF reopened subtask T238492: Figure out which production extensions have conflicting tests and fix them as Open.Jan 9 2023, 5:01 PM

Jdforrester-WMF added a subtask: T333541: Add CentralAuth to gated extensions.Mar 30 2023, 12:45 PM

Jdforrester-WMF added a subtask: T333534: Add PageTriage to gated extensions.

kostajh closed subtask T333541: Add CentralAuth to gated extensions as Declined.Apr 19 2023, 2:23 PM

kostajh changed the status of subtask T333534: Add PageTriage to gated extensions from Open to In Progress.Apr 28 2023, 10:31 AM

taavi added a subtask: T342062: Add WikiLove to gated extensions.Jul 18 2023, 12:19 PM

Change 939290 had a related patch set uploaded (by Majavah; author: Majavah):

[integration/config@master] zuul: [mediawiki/extensions/WikiLove] Add to gate

https://gerrit.wikimedia.org/r/939290