Quibble should configure php 7.4+ built in web server to use multiple workers
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Aug 3 2020, 8:34 AM

Description

I have just found out that in PHP 7.4, the builtin webserver (php -S) supports multiple workers! From https://www.php.net/manual/en/features.commandline.webserver.php

Changelog

Version	Description
7.4.0	You can configure the built-in webserver to fork multiple workers in order to test code that requires multiple concurrent requests to the built-in webserver. Set the `PHP_CLI_SERVER_WORKERS` environment variable to the number of desired workers before starting the server. This is not supported on Windows.

It defaults to 1.

Details

Subject	Repo	Branch	Lines +/-
jjb: switch jobs to Quibble 1.2.0	integration/config	master	+30 -30
Release Quibble 1.2.0	integration/quibble	master	+25 -2
Support multiple workers in PHP 7.4+ web server	integration/quibble	master	+114 -7

Customize query in gerrit

Related Objects

Mentioned In: T292772: ERROR: setuptools==41.0.0 is used in combination with setuptools_scm>=6.x
T256402: Remove JUnit artefacts from Quibble jobs
T225218: Consider httpd for quibble instead of php built-in server
Mentioned Here: T256402: Remove JUnit artefacts from Quibble jobs
T292772: ERROR: setuptools==41.0.0 is used in combination with setuptools_scm>=6.x
rQUIBBLEbdabd84b30d6: Release Quibble 1.2.0
T225218: Consider httpd for quibble instead of php built-in server

Event Timeline

hashar created this task.Aug 3 2020, 8:34 AM

hashar mentioned this in T225218: Consider httpd for quibble instead of php built-in server.

awight subscribed.Aug 3 2020, 9:48 AM

kostajh awarded a token.Aug 13 2020, 11:39 AM

hashar claimed this task.Oct 13 2021, 12:18 PM

Change 730547 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Support multiple workers in PHP 7.4+ web server

https://gerrit.wikimedia.org/r/730547

gerritbot added a project: Patch-For-Review.Oct 13 2021, 3:10 PM

Change 730547 merged by jenkins-bot:

[integration/quibble@master] Support multiple workers in PHP 7.4+ web server

https://gerrit.wikimedia.org/r/730547

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2021, 10:10 AM

It could already be achieved by setting the PHP_CLI_SERVER_WORKERS environment variable and I went to add an option to Quibble: --web-php-workers WEB_PHP_WORKERS.

Change 734211 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/quibble@master] Release Quibble 1.2.0

https://gerrit.wikimedia.org/r/734211

gerritbot added a project: Patch-For-Review.Oct 25 2021, 9:38 AM

Change 734211 merged by jenkins-bot:

[integration/quibble@master] Release Quibble 1.2.0

https://gerrit.wikimedia.org/r/734211

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2021, 2:10 PM

Mentioned in SAL (#wikimedia-releng) [2021-10-27T16:51:54Z] <hashar> Tag Quibble 1.2.0 @ bdabd84 # T259456 T292772 T256402

Released in Quibble 1.2.0

I would expect this to trigger most of the same race conditions as the Apache+quibble configuration. But this was deployed successfully?

In T259456#7464288, @awight wrote:

I would expect this to trigger most of the same race conditions as the Apache+quibble configuration. But this was deployed successfully?

I don't see anything in integration/config using --web-php-workers so I think it is there, but not used. I'm also not sure this will trigger the same race conditions as Apache/PHP-FPM. I noted this somewhere (sorry, can't find it now) but it looks like when MediaWiki makes API requests to itself (done for Parsoid PHP), the same PHP thread that makes the request is also used to handle the request (so the multiple workers setup won't work for Parsoid integration), even when multiple workers are specified.

1.2.0 would still serve pages serially with the PHP builtin web server since --web-php-workers defaults to 1 and we do not set PHP_CLI_SERVER_WORKERS anyway.