Maniphest T281968

Remove language button from commons
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	ovasileva
	May 5 2021, 11:27 AM

Description

Background

For logged in users that have opted out of legacy vector, the language button should not appear on Commons or other wikis that have multiple languages within the same domain. The language switching functionality on Commons exists to switch the interface language and is controlled via the link at the top. The button introduced by the change linked to the Wikipedia links currently available in the sidebar, making it difficult to distinguish its functionality.

Acceptance criteria

Remove new language switcher from: Commons, Wikidata, Mediawiki, Wikispecies,

https://phabricator.wikimedia.org/T281968#7099849

QA Results - Beta

AC	Status	Details
1	✅	T281968#7099849
2	❓	T281968#7099849
3	❓	T281968#7099849
4	❓	T281968#7099849

Details

	Subject	Repo	Branch	Lines +/-
	Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies	operations/mediawiki-config	master	+18 -2

Customize query in gerrit

Related Objects

Mentioned In: T282211: iw links not displayed in the side menu if new vector layout is activated
Mentioned Here: rOMWC9209d9656077: Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies

Event Timeline

ovasileva created this task.May 5 2021, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2021, 11:27 AM

ovasileva triaged this task as High priority.May 5 2021, 11:28 AM

ovasileva moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ovasileva set the point value for this task to 2.May 5 2021, 5:22 PM

ovasileva moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

ovasileva updated the task description. (Show Details)May 6 2021, 10:47 AM

Jdrewniak claimed this task.May 6 2021, 1:02 PM

Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 685795 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[operations/mediawiki-config@master] Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies

https://gerrit.wikimedia.org/r/685795

gerritbot added a project: Patch-For-Review.May 6 2021, 1:36 PM

Jdrewniak removed Jdrewniak as the assignee of this task.May 6 2021, 1:36 PM

Jdrewniak moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Jdrewniak subscribed.

ovasileva mentioned this in T282211: iw links not displayed in the side menu if new vector layout is activated.May 7 2021, 9:09 AM

Change 685795 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies

https://gerrit.wikimedia.org/r/685795

Mentioned in SAL (#wikimedia-operations) [2021-05-10T11:26:56Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: 9209d96560777cf6747d57855c7b525e702664d7: Remove Vector language button from Commons, Wikidata, Mediawiki, Wikispecies (T281968) (duration: 00m 57s)

Maintenance_bot removed a project: Patch-For-Review.May 10 2021, 12:11 PM

Jdlrobson assigned this task to Edtadros.May 10 2021, 5:21 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Status: ❓
Environment: beta/xyzwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

For logged in users that have opted out of legacy vector, the language button should not appear on the following:

✅ AC1: Commons https://commons.wikimedia.beta.wmflabs.org/wiki/Commons:Welcome

Screen Shot 2021-05-19 at 7.17.15 PM.png (1×1 px, 576 KB)

❓ AC2: Wikidata https://wikidata.beta.wmflabs.org/wiki/Q500973

Screen Shot 2021-05-19 at 7.19.46 PM.png (1×1 px, 328 KB)

❓ AC3: Mediawiki https://www.mediawiki.org/wiki/Help:Editing_pages

Screen Shot 2021-05-19 at 7.23.29 PM.png (1×1 px, 514 KB)

❓ AC4: Wikispecies https://species.wikimedia.org/wiki/Michotamia_aurata

Screen Shot 2021-05-19 at 7.27.20 PM.png (1×1 px, 513 KB)

@Jdlrobson Is the page for AC2 a good example for testing or is there another page that would have languages in the sidebar? Regarding AC3 and AC4, I couldn't find a "beta" site. I took the screenshots anyways, but I'm not sure if those wikis have this patch.

Edtadros updated the task description. (Show Details)May 20 2021, 2:37 AM

Remove new language switcher from: Commons, Wikidata, Mediawiki, Wikispecies,

@Edtadros this looks correct.

@ovasileva: sign off question... can we:

update the description to explain why the change happened here so we can refer back to it
create a new ticket explaining the long-term solution here

The feature flag for the language button was envisioned as a temporary solution and loads double the CSS it needs to. Therefore this task has lead to product/technical debt. It's my opinion we can't sustainably support 2 treatments for languages in the future IMO, so it would be good to understand how we can pay this debt off before the end of the project.

ovasileva moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.May 21 2021, 8:10 AM

ovasileva updated the task description. (Show Details)May 21 2021, 8:14 AM

@Jdlrobson - added some background above. I think our main issue is that we have 2 treatments because we have 2 different sets of functionality for single language wikis and multiple language wikis:

These wikis do not have the same behavior as others. If we present a button at the top of the page, that button takes you to a different project (rather than a different language version).

Language switching is available at the top of these wikis. Here it controls the interface language of the wikis (rather than the language of the content)

Will discuss further with @alexhollender and set up a follow-up task

Resolving this for now and scheduled a discussion with @alexhollender on next steps

	F34460758: Screen Shot 2021-05-19 at 7.17.15 PM.png
	May 20 2021, 2:35 AM

	F34460760: Screen Shot 2021-05-19 at 7.19.46 PM.png
	May 20 2021, 2:35 AM

	F34460763: Screen Shot 2021-05-19 at 7.23.29 PM.png
	May 20 2021, 2:35 AM

	F34460769: Screen Shot 2021-05-19 at 7.27.20 PM.png
	May 20 2021, 2:35 AM

Remove language button from commons Closed, ResolvedPublic2 Estimated Story PointsActions