Page MenuHomePhabricator
Create Task
Maniphest T282899

[wmf.5] Add link: Unresponsive controls when context item overlaps templates
Closed, ResolvedPublic
Actions

Assigned To
• mewoph
Authored By
Etonkovidova
May 14 2021, 8:52 PM
Tags
Referenced Files
F34468231: Freezed_bnwiki_3.png
May 25 2021, 8:01 PM
F34468217: Freezed_bnwiki_2.png
May 25 2021, 8:01 PM
F34467734: addlink_infobox.gif
May 25 2021, 4:54 PM
F34466246: Screen Shot 2021-05-24 at 10.25.52 AM.png
May 24 2021, 5:27 PM
F34454209: Screen Shot 2021-05-14 at 1.08.01 PM.png
May 14 2021, 8:52 PM
F34454205: Screen Shot 2021-05-14 at 1.06.06 PM.png
May 14 2021, 8:52 PM
F34454217: Screen Shot 2021-05-14 at 1.15.05 PM.png
May 14 2021, 8:52 PM
Subscribers
Aklapper
Ankan_WMF
Etonkovidova
kostajh
• mewoph
MMiller_WMF
Tgr

Description

Testing was done with ge.utils.setUserVariant( 'linkrecommendation' )
The issue is encountered on viwiki much more frequent than on other pilot wikis (bnwiki, arwiki, and cswiki).

When a context item overlaps the info template, the controls ('Next', 'Yes') cannot be clicked. The Console doesn't display any errors.
The examples

viwiki
https://vi.wikipedia.org/w/index.php?title=Treasure_(b%C3%A0i_h%C3%A1t_c%E1%BB%A7a_Bruno_Mars)&veaction=edit
Screen Shot 2021-05-14 at 1.06.06 PM.png (1×1 px, 561 KB)
There is an additional issue with displaying template properties on hover-up (should be gone when wmf.5 patches will be deployed
https://vi.wikipedia.org/w/index.php?title=Carnotaurus&veaction=edit
Screen Shot 2021-05-14 at 1.08.01 PM.png (964×1 px, 856 KB)

One instance on arwiki

https://ar.wikipedia.org/w/index.php?title=العلاقات_الروسية_العراقية&veaction=edit&action=edit
Screen Shot 2021-05-14 at 1.15.05 PM.png (1×1 px, 341 KB)

Details

SubjectRepoBranchLines +/-
Add a link: Hide surface highlight overlaymediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.6+7 -4
Add a link: Hide surface highlight overlaymediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.7+7 -4
Add a link: Hide surface highlight overlaymediawiki/extensions/GrowthExperimentsmaster+7 -4
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.May 14 2021, 8:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2021, 8:52 PM
Etonkovidova moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 14 2021, 8:53 PM
Etonkovidova renamed this task from [testing task] Add link: Unresponsive controls when context item overlaps templates to [wmf.5] Add link: Unresponsive controls when context item overlaps templates .May 18 2021, 12:44 AM
Etonkovidova removed Etonkovidova as the assignee of this task.
Etonkovidova triaged this task as High priority.
Etonkovidova updated the task description. (Show Details)
Etonkovidova moved this task from QA to Incoming on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova added subscribers: kostajh, • mewoph, Tgr, MMiller_WMF.
Etonkovidova mentioned this in T278600: Pre-deployment QA: "Add a link".May 19 2021, 2:56 AM
Etonkovidova moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.May 20 2021, 9:47 PM
• mewoph claimed this task.May 24 2021, 5:15 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph moved this task from Backlog to May 24 – May 28 on the Add-Link board.
• mewoph added a comment.May 24 2021, 5:27 PM

With Infoboxes, the entire highlighted area is not clickable, not just link inspectors (annotations also can't be clicked)

Screen Shot 2021-05-24 at 10.25.52 AM.png (1×2 px, 1 MB)

gerritbot added a comment.May 24 2021, 7:07 PM

Change 693941 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/693941

gerritbot added a project: Patch-For-Review.May 24 2021, 7:07 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 24 2021, 7:07 PM
• mewoph added a comment.May 25 2021, 4:54 PM

With latest changes:

addlink_infobox.gif (1×1 px, 2 MB)

Ankan_WMF subscribed.May 25 2021, 8:01 PM

Same in bnwiki.
When the suggestion window is overlapping with the infobox:

Freezed_bnwiki_2.png (789×1 px, 417 KB)

Not overlapping with the infobox, but frozen. After hovering the cursor around the suggestion window, it shows the infobox's name sometimes (see the following figure); and most of the time it remains frozen, doesn't show anything.
Freezed_bnwiki_3.png (699×1 px, 436 KB)

Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 25 2021, 8:12 PM
gerritbot added a comment.May 25 2021, 8:29 PM

Change 693941 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/693941

Maintenance_bot removed a project: Patch-For-Review.May 25 2021, 9:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.May 25 2021, 9:33 PM
In T282899#7112503, @Ankan_WMF wrote:

Same in bnwiki.
When the suggestion window is overlapping with the infobox:

Freezed_bnwiki_2.png (789×1 px, 417 KB)

Not overlapping with the infobox, but frozen. After hovering the cursor around the suggestion window, it shows the infobox's name sometimes (see the following figure); and most of the time it remains frozen, doesn't show anything.
Freezed_bnwiki_3.png (699×1 px, 436 KB)

Yes, " Not overlapping with the infobox, but frozen" it was a part of the issue. The fix works in betalabs; moving to Test in Production.

gerritbot added a comment.May 26 2021, 8:04 AM

Change 695033 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695033

gerritbot added a project: Patch-For-Review.May 26 2021, 8:04 AM

Change 695034 had a related patch set uploaded (by Kosta Harlan; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695034

kostajh moved this task from May 24 – May 28 to Done / QA on the Add-Link board.May 26 2021, 8:38 AM
gerritbot added a comment.May 26 2021, 11:17 AM

Change 695033 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.7] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695033

gerritbot added a comment.May 26 2021, 11:17 AM

Change 695034 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.6] Add a link: Hide surface highlight overlay

https://gerrit.wikimedia.org/r/695034

Stashbot mentioned this in T283544: Add a link: both "Yes" and "No" can be selected.May 26 2021, 11:26 AM
Stashbot mentioned this in T282546: AddLink: Skipped all dialog throws exception on ve.init.target.tryTeardown.then on mobile.

Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:26:29Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.6/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 19s)

Stashbot added a comment.May 26 2021, 11:27 AM

Mentioned in SAL (#wikimedia-operations) [2021-05-26T11:27:45Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.7/extensions/GrowthExperiments/: GrowthExperiments backports (T283544; T282899; T282546) (duration: 01m 06s)

Maintenance_bot removed a project: Patch-For-Review.May 26 2021, 12:10 PM
Etonkovidova added a comment.May 26 2021, 11:24 PM

Tested in betalabs and `testwiki wmf.7. The task needs a quick check on group 2 pilot wikis.

Etonkovidova closed this task as Resolved.Jun 5 2021, 9:22 PM
In T282899#7117993, @Etonkovidova wrote:

Tested in betalabs and `testwiki wmf.7. The task needs a quick check on group 2 pilot wikis.

Checked on viwiki and arwiki (wmf.7).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL