Maniphest T284462

Horizon should get confirmation for shelve operations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	RoySmith
	Jun 7 2021, 2:23 PM

Tags

Referenced Files

None

Subscribers

Description

I was exploring the U/I at https://horizon.wikimedia.org/project/instances/43d3e9f2-b7d5-4a51-92b6-6a636839d66f/ and accidentally selected "Shelve Instance" from the menu, which started the shelve process (see also T284461).

For an operation like this, it should ask for confirmation before doing anything.

Related Objects

Mentioned In: T284461: spi-tools-host-1 has been in the process of shelving for a long time.
Mentioned Here: T284461: spi-tools-host-1 has been in the process of shelving for a long time.

Event Timeline

RoySmith created this task.Jun 7 2021, 2:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2021, 2:23 PM

MarcoAurelio added a project: Horizon.Jun 7 2021, 2:29 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-07T19:02:22Z] <andrew@deploy1002> Started deploy [horizon/deploy@6199b67]: disable shelve/unshelve T284462

Andrew mentioned this in T284461: spi-tools-host-1 has been in the process of shelving for a long time..Jun 7 2021, 7:04 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-07T19:07:16Z] <andrew@deploy1002> Finished deploy [horizon/deploy@6199b67]: disable shelve/unshelve T284462 (duration: 04m 53s)

I disabled this feature entirely; it's not something we can currently support.