⚓ T284587 ReleaseTaggerBot skipping some Tasks/Patches?

	Subject	Repo	Branch	Lines +/-
	Add test & fixed for mixed CRLF/LF messages	labs/tools/forrestbot	master	+177 -12

MarcoAurelio created this task.Jun 8 2021, 6:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2021, 6:02 PM

MarcoAurelio removed a subscriber: ReleaseTaggerBot.Jun 8 2021, 6:02 PM

Hmm, that doesn't look good:

forrestbot.log.2021-06-05:2021-06-05 15:00:13,036 - forrestbot - DEBUG - <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/698040>: skipping (SkipMailException('Project mediawiki/core\r is not being watched',))

Why on earth is there an \r there but not in many of the other changes?

In any case, should be relatively easy to fix. However need to figure out (a) whether other patches are affected, and (b) how to write a good test for this.

valhallasw triaged this task as High priority.Jun 12 2021, 6:29 PM

Change 699497 had a related patch set uploaded (by Merlijn van Deen; author: Merlijn van Deen):

[labs/tools/forrestbot@master] Add test & fixed for mixed CRLF/LF messages

https://gerrit.wikimedia.org/r/699497

gerritbot added a project: Patch-For-Review.Jun 12 2021, 7:08 PM

For (b): found a source email with the same issue -- the email has mixed CRLF and LF newlines which explains why things got confused. Created test + fix (see above). Will deploy this first, and will then investigate what I can find on other situations where the \r may have caused issues.

Change 699497 merged by jenkins-bot:

[labs/tools/forrestbot@master] Add test & fixed for mixed CRLF/LF messages

https://gerrit.wikimedia.org/r/699497

Deployed and re-enabled bot. Looking into the logs now.

Quite a list -- https://forrestbot.toolforge.org/cr.txt . Let's see if we can filter this a bit.

List seems to be the following:

Process finished with exit code 0

which I'll fix by opening a gazillion tabs :-)

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2021, 8:10 PM

Decided to use a script after realizing the number of clicks required for the manual approach. Should all be sorted now :-)

Note that I may have missed changes before 6 jun (which is the oldest log file).

My hunch is that this was introduced either through a Gerrit upgrade or through the Mailman3 upgrade for mediawiki-commits. The latter happened before 1 jun, which suggests there's at least a week of missing release note tags :-(. @Ladsgroup may know a more specific date of the switchover for the mw-commits mailing list.

Looks like there is nothing left to do here, can this taks be resolved?

In T284587#7153540, @valhallasw wrote:

Note that I may have missed changes before 6 jun (which is the oldest log file).

My hunch is that this was introduced either through a Gerrit upgrade or through the Mailman3 upgrade for mediawiki-commits. The latter happened before 1 jun, which suggests there's at least a week of missing release note tags :-(. @Ladsgroup may know a more specific date of the switchover for the mw-commits mailing list.

I'm so sorry I missed the ping with this. According T280322: Upgrade mailing lists from mailman2 to 3 in batches the aforementioned mailing list was in group A and was migrated in May 3. HTH

@valhallasw: Is there anything left to do in this task?

valhallasw mentioned this in T290905: Gerrit Reviewer Bot is unreliable.Sep 20 2021, 8:35 AM

No reply; assuming this can be closed. Please reopen if I'm wrong.

ReleaseTaggerBot skipping some Tasks/Patches?
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

ReleaseTaggerBot skipping some Tasks/Patches?Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

ReleaseTaggerBot skipping some Tasks/Patches?
Closed, ResolvedPublic
Actions