Page MenuHomePhabricator
Create Task
Maniphest T284597

PHP Notice: Undefined index: questions
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Notice: Undefined index: questions
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(137)
#0 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(137): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(347): GrowthExperiments\WelcomeSurvey->getQuestions(string)
#2 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurveyHooks.php(80): GrowthExperiments\WelcomeSurvey->getRedirectUrl(string)
#3 /srv/mediawiki/php-1.37.0-wmf.7/includes/HookContainer/HookContainer.php(160): GrowthExperiments\WelcomeSurveyHooks->onBeforeWelcomeCreation(string, string)
#4 /srv/mediawiki/php-1.37.0-wmf.7/includes/HookContainer/HookRunner.php(1032): MediaWiki\HookContainer\HookContainer->run(string, array)
#5 /srv/mediawiki/php-1.37.0-wmf.7/includes/specials/SpecialCreateAccount.php(157): MediaWiki\HookContainer\HookRunner->onBeforeWelcomeCreation(string, string)
#6 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/LoginSignupSpecialPage.php(357): SpecialCreateAccount->successfulAction(boolean)
#7 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/SpecialPage.php(646): LoginSignupSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/SpecialPageFactory.php(1390): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#10 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(917): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(551): MediaWiki->main()
#12 /srv/mediawiki/php-1.37.0-wmf.7/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.37.0-wmf.7/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}
Impact

There are 310 such errors recorded. For a user impact, I checked arwiki - it seems that Special:WelcomeSurvey page works as expected.

Notes

Couple of other errors re WelcomeSurvey.php.

(1) PHP Warning: Invalid argument supplied for foreach()

normalized_message
[{reqId}] {exception_url}   PHP Warning: Invalid argument supplied for foreach()
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(152)
#0 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(152): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(347): GrowthExperiments\WelcomeSurvey->getQuestions(string)
#2 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurveyHooks.php(80): GrowthExperiments\WelcomeSurvey->getRedirectUrl(string)
#3 /srv/mediawiki/php-1.37.0-wmf.7/includes/HookContainer/HookContainer.php(160): GrowthExperiments\WelcomeSurveyHooks->onBeforeWelcomeCreation(string, string)
#4 /srv/mediawiki/php-1.37.0-wmf.7/includes/HookContainer/HookRunner.php(1032): MediaWiki\HookContainer\HookContainer->run(string, array)
#5 /srv/mediawiki/php-1.37.0-wmf.7/includes/specials/SpecialCreateAccount.php(157): MediaWiki\HookContainer\HookRunner->onBeforeWelcomeCreation(string, string)
#6 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/LoginSignupSpecialPage.php(357): SpecialCreateAccount->successfulAction(boolean)
#7 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/SpecialPage.php(646): LoginSignupSpecialPage->execute(NULL)
#8 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/SpecialPageFactory.php(1390): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#10 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(917): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(551): MediaWiki->main()
#12 /srv/mediawiki/php-1.37.0-wmf.7/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.37.0-wmf.7/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}

(2) PHP Warning: in_array() expects parameter 2 to be array, null given

normalized_message
[{reqId}] {exception_url}   PHP Warning: in_array() expects parameter 2 to be array, null given
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(138)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(138): in_array(string, NULL)
#2 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurvey.php(347): GrowthExperiments\WelcomeSurvey->getQuestions(string)
#3 /srv/mediawiki/php-1.37.0-wmf.7/extensions/GrowthExperiments/includes/WelcomeSurveyHooks.php(80): GrowthExperiments\WelcomeSurvey->getRedirectUrl(string)
#4 /srv/mediawiki/php-1.37.0-wmf.7/includes/HookContainer/HookContainer.php(160): GrowthExperiments\WelcomeSurveyHooks->onBeforeWelcomeCreation(string, string)
#5 /srv/mediawiki/php-1.37.0-wmf.7/includes/HookContainer/HookRunner.php(1032): MediaWiki\HookContainer\HookContainer->run(string, array)
#6 /srv/mediawiki/php-1.37.0-wmf.7/includes/specials/SpecialCreateAccount.php(157): MediaWiki\HookContainer\HookRunner->onBeforeWelcomeCreation(string, string)
#7 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/LoginSignupSpecialPage.php(357): SpecialCreateAccount->successfulAction(boolean)
#8 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/SpecialPage.php(646): LoginSignupSpecialPage->execute(NULL)
#9 /srv/mediawiki/php-1.37.0-wmf.7/includes/specialpage/SpecialPageFactory.php(1390): SpecialPage->run(NULL)
#10 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#11 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(917): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.37.0-wmf.7/includes/MediaWiki.php(551): MediaWiki->main()
#13 /srv/mediawiki/php-1.37.0-wmf.7/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.37.0-wmf.7/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}

Details

Request URL
https://ar.wikipedia.org/w/index.php?title=*&returnto=*
SubjectRepoBranchLines +/-
wgWelcomeSurveyExperimentalGroups: Use new syntax in CS.phpoperations/mediawiki-configmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Jun 8 2021, 7:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2021, 7:26 PM
Etonkovidova added subscribers: kostajh, Tgr, • mewoph.Jun 8 2021, 7:35 PM
Etonkovidova updated the task description. (Show Details)Jun 8 2021, 7:52 PM
Etonkovidova added a subscriber: Urbanecm_WMF.
kostajh triaged this task as High priority.Jun 8 2021, 7:54 PM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF claimed this task.Jun 8 2021, 9:09 PM

I'll have a look tomorrow.

Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptJun 8 2021, 9:09 PM
Urbanecm_WMF moved this task from Untriaged to Engineering on the User-Urbanecm_WMF board.Jun 9 2021, 12:10 PM
Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.
Urbanecm_WMF closed this task as Resolved.Jun 9 2021, 12:18 PM

This was fixed with T284599 (caused by using an incorrect group for WS). This message does not get logged after this deploy AFAICS:

12:00	<urbanecm@deploy1002>	Synchronized wmf-config/InitialiseSettings.php: ac43baa: d185728: WelcomeSurveyExperimentalGroups: Use new syntax (T284599) (duration: 01m 19s)	[production]

Resolving.

Urbanecm_WMF merged a task: T284686: PHP Notice: Undefined index: questions.Jun 9 2021, 6:52 PM
Urbanecm_WMF added subscribers: thcipriani, Urbanecm.
Restricted Application removed a subscriber: Urbanecm. · View Herald TranscriptJun 9 2021, 6:52 PM
Urbanecm_WMF mentioned this in T284686: PHP Notice: Undefined index: questions.Jun 9 2021, 6:54 PM
kostajh reopened this task as Open.Jun 10 2021, 11:51 AM

I'm still seeing this in the logs for skwiki this morning https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-2021.06.10?id=5pf59HkBStjVNP_PQxVp

gerritbot added a comment.Jun 10 2021, 12:26 PM

Change 699198 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] wgWelcomeSurveyExperimentalGroups: Use new syntax in CS.php

https://gerrit.wikimedia.org/r/699198

gerritbot added a project: Patch-For-Review.Jun 10 2021, 12:26 PM
Urbanecm_WMF added a comment.Jun 10 2021, 12:28 PM

Good catch @kostajh. Uploaded a fix for it - forgot about the CS.php override. Note that this needs to be deployed ASAP – without this patch, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/698974 would cause survey to be displayed on wikis where our features are supposed to be in the dark mode.

Urbanecm_WMF mentioned this in T284735: PHP Warning: in_array() expects parameter 2 to be array, null given.Jun 10 2021, 12:30 PM
gerritbot added a comment.Jun 10 2021, 6:01 PM

Change 699198 merged by jenkins-bot:

[operations/mediawiki-config@master] wgWelcomeSurveyExperimentalGroups: Use new syntax in CS.php

https://gerrit.wikimedia.org/r/699198

Stashbot added a comment.Jun 10 2021, 6:05 PM

Mentioned in SAL (#wikimedia-operations) [2021-06-10T18:05:35Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: d26968c1c3b3f3e115ff37a9a138d225cabba25a: wgWelcomeSurveyExperimentalGroups: Use new syntax in CS.php (T284597; T284735) (duration: 01m 08s)

Urbanecm_WMF moved this task from Ready for Development to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 10 2021, 6:06 PM

Should no longer happen.

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2021, 6:10 PM
Urbanecm_WMF moved this task from Backlog to My Part Done on the User-Urbanecm_WMF (Engineering) board.Jun 10 2021, 6:24 PM
Etonkovidova closed this task as Resolved.Jun 10 2021, 9:53 PM
In T284597#7148441, @kostajh wrote:

I'm still seeing this in the logs for skwiki this morning https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-deploy-2021.06.10?id=5pf59HkBStjVNP_PQxVp

It seems that it was the last one. There were no errors after and WelcomeSurvey is presented when a user creates a new account (checked on bnwiki).

Etonkovidova mentioned this in T284599: [BUG] Welcome survey is not being shown to a new account in our experiment.Jun 10 2021, 9:58 PM
Krinkle moved this task from Untriaged to June 2021 on the Wikimedia-production-error board.Jun 12 2021, 5:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL