Page MenuHomePhabricator

The link to privacy policy in the survey panel in the ruwiki leads to the test domain
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?
After sending an answer in the survey panel I has got the link to the privacy policy. But this link leads to the test domain: https://example.org/privacy-policy.

What should have happened instead?:
This link should be lead to the real privacy policy.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Снимок экрана 2021-08-29 192505.png (819×1 px, 434 KB)
Снимок экрана 2021-08-29 194651.png (508×1 px, 28 KB)
Снимок экрана 2021-08-29 202537.png (255×871 px, 24 KB)

QA in beta cluster

This can skip QA in beta cluster as it can't be tested there.

QA

QA Results - Prod

ACStatusDetails
1T289941#7369047

Event Timeline

Hi @IEPCBM, thanks for taking the time to report this! Original strings come from the QuickSurveys codebase, which has the standard default message

"ext-quicksurveys-example-external-survey-privacy-policy": "Опрос предоставлен ExampleSurveyProvider. См. [//example.org/privacy-policy политику конфиденциальности]",

but that is not the exact message that you see either.
In theory a Wikimedia specific overwrite should exist in WikimediaMessages, something like:

"ext-quicksurveys-performance-internal-survey-privacy-policy": "Чтобы узнать больше, см. [https://foundation.wikimedia.org/wiki/Performance_Perception_Survey_Privacy_Statement политику конфиденциальности] данного опроса.",
Aklapper added a subscriber: FriedrickMILBarbarossa.

@FriedrickMILBarbarossa: Could you please stop adding project tags for no good reason? This isn't specific at all to Russian sites. Thanks a lot.

@FriedrickMILBarbarossa: Could you please stop adding project tags for no good reason? This isn't specific at all to Russian sites. Thanks a lot.

Hm, you might be right, although this task is still related to the Russian Wikipedia. Also, other language project tags that I added so far should be all correct (excluding only one wrongly added Chinese-Sites project tag back at the very beginning, see T163655).

Jdlrobson added subscribers: Jdforrester-WMF, Jdlrobson.

I can replicate this using https://ru.wikipedia.org/wiki/%D0%9F%D0%BE%D0%B6%D0%B0%D1%80%D0%BD%D1%8B%D0%B9_%D1%82%D1%80%D0%B0%D0%BA%D1%82%D0%BE%D1%80?quicksurvey=true&uselang=qqx

According to mw.config.get( 'wgEnabledQuickSurveys' ) It looks like there a performance survey last touched by @Jdforrester-WMF in fea69395e3 internal-survey-perceived-performance-survey:

The survey is not set up correctly.
It can be fixed by editing https://ru.wikipedia.org/w/index.php?title=MediaWiki:Ext-quicksurveys-survey-privacy-policy-default-text&action=edit

If the performance team is not using the survey, I suggest disabling it instead.

I can replicate this using https://ru.wikipedia.org/wiki/%D0%9F%D0%BE%D0%B6%D0%B0%D1%80%D0%BD%D1%8B%D0%B9_%D1%82%D1%80%D0%B0%D0%BA%D1%82%D0%BE%D1%80?quicksurvey=true&uselang=qqx

According to mw.config.get( 'wgEnabledQuickSurveys' ) It looks like there a performance survey last touched by @Jdforrester-WMF in fea69395e3 internal-survey-perceived-performance-survey:

That was just a config lift-and-shift; the original enablement for ruwiki was in 1226596c4b for the Performance team. Note that it's a bit of a mess – QuickSurveys's deployment was massively expanded with 794cd15949 for the Research team, and when that particular survey was disabled in 140aca08e3, the setting was left on, thus giving users the generic default performance survey instead. I assume this is likely a particular issue for the other wikis configured and which don't have an explicit survey (arwiki, dewiki, frwiki, hewiki, huwiki, nowiki, rowiki, ukwiki, zhwiki) as they weren't planned to have data collected (and maybe the data is just being ignored?). The ones that Performance added explicitly (enwiki/ruwiki/dewiki etc.) might also want dropping if the data isn't actively being used, yes.

The survey is not set up correctly.
It can be fixed by editing https://ru.wikipedia.org/w/index.php?title=MediaWiki:Ext-quicksurveys-survey-privacy-policy-default-text&action=edit

That's a quick fix, but over-riding that message on-wiki shouldn't be needed.

It looks like the message is trying to be over-ridden in Wikimedia messages but the message name is wrong: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikimediaMessages/+/refs/heads/master/i18n/wikimedia/en.json#337

This appears to be caused by the Vue port; this line should be reading the labels from config, shouldn't it?

If the performance team is not using the survey, I suggest disabling it instead.

Agreed.

Change 715836 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@master] Use privacyPolicy configuration

https://gerrit.wikimedia.org/r/715836

This appears to be caused by the Vue port; this line should be reading the labels from config, shouldn't it?

Thanks for pointing that out. I misread the qqx code. The above patch should take care of this problem. This extension really needs a UI...

Change 715836 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Use privacyPolicy configuration

https://gerrit.wikimedia.org/r/715836

Change 715808 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@wmf/1.37.0-wmf.21] Use privacyPolicy configuration

https://gerrit.wikimedia.org/r/715808

Change 715809 had a related patch set uploaded (by Jforrester; author: Jdlrobson):

[mediawiki/extensions/QuickSurveys@wmf/1.37.0-wmf.20] Use privacyPolicy configuration

https://gerrit.wikimedia.org/r/715809

ovasileva triaged this task as Medium priority.Sep 1 2021, 4:47 PM
ovasileva raised the priority of this task from Medium to High.
LGoto lowered the priority of this task from High to Medium.Sep 1 2021, 4:49 PM

The survey does not appear to be enabled for anyone (coverage is set to 0 so there's no need to backport this. it can wait on the train.

'ruwiki' => [
        // T187299
        [
                'enabled' => true,
                'type' => 'internal',
                'name' => 'perceived-performance-survey',
                'question' => 'ext-quicksurveys-performance-internal-survey-question',
                'answers' => [
                        'ext-quicksurveys-example-internal-survey-answer-positive',
                        'ext-quicksurveys-example-internal-survey-answer-neutral',
                        'ext-quicksurveys-example-internal-survey-answer-negative',
                ],
                'coverage' => 0.0,
                'platforms' => [
                        'desktop' => [ 'stable' ],
                ],
                'privacyPolicy' => 'ext-quicksurveys-performance-internal-survey-privacy-policy',
                'shuffleAnswersDisplay' => true,
        ],
],

Change 715809 abandoned by Jforrester:

[mediawiki/extensions/QuickSurveys@wmf/1.37.0-wmf.20] Use privacyPolicy configuration

Reason:

https://gerrit.wikimedia.org/r/715809

Change 715808 abandoned by Jforrester:

[mediawiki/extensions/QuickSurveys@wmf/1.37.0-wmf.21] Use privacyPolicy configuration

Reason:

https://gerrit.wikimedia.org/r/715808

Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: ruwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Blocked until 16th September
AC1: Check the link on https://ru.wikipedia.org/wiki/%D0%9F%D0%BE%D0%B6%D0%B0%D1%80%D0%BD%D1%8B%D0%B9_%D1%82%D1%80%D0%B0%D0%BA%D1%82%D0%BE%D1%80?quicksurvey=true doesn't point to example.org

Screen Recording 2021-09-21 at 6.51.29 AM.mov.gif (750×1 px, 627 KB)

Screen Recording 2021-09-21 at 6.50.58 AM.mov.gif (750×1 px, 652 KB)

Screen Shot 2021-09-21 at 6.54.44 AM.png (1×1 px, 655 KB)

Screen Shot 2021-09-21 at 6.54.28 AM.png (1×1 px, 663 KB)

Looks good, resolving