VipsScaler was used for thumbnailing especially large files, but is no longer used, we moved to Thumbor years ago and it uses vips too: T119184: Thumbor VIPS engine.
Special:VipsTest will disappear from wikis, but it's always explicitly been for testing.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T106123 Extensions needing to be removed from Wikimedia wikis | |||
| Resolved | Legoktm | T290802 Remove libvips-tools from mediawiki appservers | |||
| Open | None | T260504 Get rid of remaining non-Thumbor MediaWiki image scaling in WMF production | |||
| Open | Jdforrester-WMF | T290759 Undeploy VipsScaler from Wikimedia wikis | |||
| Open | None | T291014 Terminate all implicit use of VipsScaler code from Wikimedia production so we can remove it without breaking things this time |
Change 720355 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/mediawiki-config@master] Undeploy VipsScaler: I \u2013 Disable on all wikis
Change 720356 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/mediawiki-config@master] Undeploy VipsScaler: II \u2013 Don't load regardless of config
Change 720357 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/mediawiki-config@master] Undeploy VipsScaler: III \u2013 Don't set wmgUseVips, now ignored
Change 720358 had a related patch set uploaded (by Jforrester; author: Jforrester):
[operations/mediawiki-config@master] Undeploy VipsScaler: IV \u2013 Don't load the i18n
Change 720359 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/tools/release@master] Stop branching VipsScalar for Wikimedia production
Even with Thumbor, it is/was still being used for some thumbnails (in the current config) - T199938: VipsScaler broken for MediaWiki production (/usr/bin/vips: No such file)
I'm presuming Thumbor will handle them fine...
This should be disproven / confirmed that we have somehow integrated Thumbor in a lambda-like way into MediaWiki where it can process even media files that aren't yet in Swift, as shown to the user during the upload process. I thought this didn't exist, but maybe it does.
Change 720355 merged by jenkins-bot:
[operations/mediawiki-config@master] Undeploy VipsScaler: I \u2013 Disable on all wikis
Mentioned in SAL (#wikimedia-operations) [2021-09-13T19:52:22Z] <jforrester@deploy1002> Synchronized wmf-config/InitialiseSettings.php: T290759 Undeploy VipsScaler: I – Disable on all wikis (duration: 00m 57s)
Tim recently changed it so MediaWiki no longer thumbnails at all: T260504: Get rid of remaining non-Thumbor MediaWiki image scaling in WMF production. For vips specifically, I looked through exec.log before bringing it up that the only invocations of vips in the past 30 days was from Special:VipsTest.
One this is done should we revert https://gerrit.wikimedia.org/r/c/operations/puppet/+/446640/ if all calls to Vips are going to be done on the Thumbor hosts?
Yes, Reedy filed T290802: Remove libvips-tools from mediawiki appservers (parent task) for it.
Ack, thanks. I recall that task from last year but didn't know it had already been solved (as of Feb 2021). Neat. Consider my concern addressed.
Change 720356 merged by jenkins-bot:
[operations/mediawiki-config@master] Undeploy VipsScaler: II \u2013 Don't load regardless of config
Mentioned in SAL (#wikimedia-operations) [2021-09-13T23:41:14Z] <jforrester@deploy1002> Synchronized wmf-config/CommonSettings.php: T290759: Undeploy VipsScaler: II – Don't load regardless of config (duration: 00m 58s)
Change 720357 merged by jenkins-bot:
[operations/mediawiki-config@master] Undeploy VipsScaler: III \u2013 Don't set wmgUseVips, now ignored
Mentioned in SAL (#wikimedia-operations) [2021-09-13T23:45:31Z] <jforrester@deploy1002> Synchronized wmf-config/InitialiseSettings.php: T290759: Undeploy VipsScaler: III – Don't set wmgUseVips, now ignored (duration: 00m 58s)
Change 720358 merged by jenkins-bot:
[operations/mediawiki-config@master] Undeploy VipsScaler: IV \u2013 Don't load the i18n
Change 720359 merged by jenkins-bot:
[mediawiki/tools/release@master] Stop branching VipsScaler for Wikimedia production
Change 720974 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):
[operations/puppet@production] mediawiki::packages: remove libvips
After VipsScaler has been disabled on all wikis, we started seeing errors fetching thumbnails mimetype which is T290973 . It might be unrelated though.
Because of T291010: MediaWiki refuses to generate thumbnail URLs for large PNGs and TIFFs with "Error creating thumbnail: File with dimensions greater than 100 MP" and T290973: Error: Call to a member function getMimeType() on null we're going to put VipsScaler back for now, even though it wasn't actually shelling out to vips, its hooks were still doing other things that apparently we depend on. Those things need to be fixed but not by just seeing what breaks :/
I'll work on reploying it now.
Change 721092 had a related patch set uploaded (by Legoktm; author: Legoktm):
[mediawiki/core@wmf/1.37.0-wmf.23] Re-add VipsScaler
Change 721092 merged by Legoktm:
[mediawiki/core@wmf/1.37.0-wmf.23] Re-add VipsScaler
Mentioned in SAL (#wikimedia-operations) [2021-09-14T22:11:00Z] <legoktm@deploy1002> Started scap: Rebuild i18n for redeployment of VipsScaler (T290759)
Mentioned in SAL (#wikimedia-operations) [2021-09-14T22:34:49Z] <legoktm@deploy1002> Finished scap: Rebuild i18n for redeployment of VipsScaler (T290759) (duration: 23m 49s)
Change 721098 had a related patch set uploaded (by Legoktm; author: Legoktm):
[operations/mediawiki-config@master] Revert \"Undeploy VipsScaler: I, II & III\"
Change 721098 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert \"Undeploy VipsScaler: I, II & III\"
Change 720974 merged by Giuseppe Lavagetto:
[operations/puppet@production] mediawiki::packages: remove libvips
@Jdforrester-WMF: Per emails from Sep18 and Oct20 and https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup , I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!
Change 977250 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):
[operations/mediawiki-config@master] Disable VipsScaler in group0
Change 977250 merged by jenkins-bot:
[operations/mediawiki-config@master] Disable VipsScaler in group0
Mentioned in SAL (#wikimedia-operations) [2023-11-28T20:29:04Z] <ladsgroup@deploy2002> Started scap: Backport for [[gerrit:977250|Disable VipsScaler in group0 (T290759)]]
Mentioned in SAL (#wikimedia-operations) [2023-11-28T20:30:28Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:977250|Disable VipsScaler in group0 (T290759)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2023-11-28T20:39:13Z] <ladsgroup@deploy2002> Finished scap: Backport for [[gerrit:977250|Disable VipsScaler in group0 (T290759)]] (duration: 10m 08s)
This doesn't fail anymore https://test.wikipedia.org/w/index.php?title=User:Legoktm/sandbox&diff=prev&oldid=583704 but maybe because the image is in commons? Anyway, I make sure T291010#7353546 doesn't happen again before moving forward.