Page MenuHomePhabricator
Create Task
Maniphest T293851

Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
jjb: Switch all quibble PHP74 jobs to images using Wikimedia's not Sury's PHPintegration/configmaster+3 -3
dockerfiles: [quibble-buster-php74] Migrate from sury-php to Wikimedia PHPintegration/configmaster+18 -16
jjb: Switch to PHP 7.4 images with Wikimedia not Sury packageintegration/configmaster+11 -11
Docker: [php74] Switch PHP 7.4 from Sury to Wikimedia packageintegration/configmaster+55 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT248925 Make MediaWiki release tarball compatible with PHP 8.0
 ResolvedJdforrester-WMFT300463 Make PHP 8.0 voting on MW master
 ResolvedJdforrester-WMFT313563 Bump lcobucci/jwt & league/uri-components for php8
 ResolvedJdforrester-WMFT313564 Bump onoi/message-reporter in vendor.git to 1.4.2 for php 8 support
 ResolvedJdforrester-WMFT247658 Make Wikimedia Production MediaWiki compatible with PHP 7.4
 Resolved• toanT243590 Fix WikibaseDataModel CI for php 7.4
 ResolvedLucas_Werkmeister_WMDET316923 Restore skipped test in ReferenceListTest.php
 ResolvedJoeT318918 Undeploy patch to use old PHP serialization in PHP 7.4
 ResolvedJdforrester-WMFT264168 Drop PHP 7.2 support from Wikibase master branch, once Wikimedia production is on 7.4
 ResolvedLadsgroupT270740 Drop hacky support for doctrine/dbal class renaming
 InvalidNoneT303505 [S] Remove Deprecated methods "serialize" and "unserialize" after php production upgrade to PHP 7.4
 ResolvedReedyT251043 Cleanup css-sanitizer when it only requires PHP >= 7.4
 OpenNoneT166010 The Great Namespaceization Effort
 Resolved• tstarlingT277618 var_dump() on various objects writes gigabytes of data and takes minutes to run
 ResolvedJdforrester-WMFT261872 Drop PHP 7.2 & 7.3 support from MediaWiki master branch, once Wikimedia production is on 7.4
 ResolvedPRODUCTION ERRORLegoktmT293568 PHP Notice: Undefined offset in wikimedia/remex-html when rendering rest.php error page
 Resolved• tstarlingT297667 mysqli/mysqlnd memory leak
 ResolvedJoeT271736 Migrate WMF production from PHP 7.2 to PHP 7.4
 ResolvedJdforrester-WMFT293924 Also run PHP 7.4 jobs on wmf branch patches
 ResolvedJdforrester-WMFT293851 Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work
 ResolvedLegoktmT293449 Package php 7.4 for wikimedia production

Event Timeline

Jdforrester-WMF renamed this task from Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, once it exists to Re-build all CI images of PHP 7.4 from sury's package to Wikimedia's one, to assure us that it will work.Oct 20 2021, 2:38 AM
Jdforrester-WMF created this task.
Jdforrester-WMF added a subtask: T293449: Package php 7.4 for wikimedia production.
gerritbot added a comment.Oct 20 2021, 2:45 AM

Change 732112 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] [DNM] Docker: [php74] Switch PHP 7.4 from Sury to Wikimedia package

https://gerrit.wikimedia.org/r/732112

gerritbot added a project: Patch-For-Review.Oct 20 2021, 2:45 AM
Legoktm added a comment.Oct 20 2021, 5:23 PM

This would also be a good time to enable PHP 7.4 jobs on wmf/ branches.

thcipriani edited projects, added Release-Engineering-Team (Seen); removed Release-Engineering-Team.Oct 20 2021, 5:25 PM
thcipriani subscribed.

Let Release-Engineering-Team know when that patch is no longer DNM :D

Reedy added a parent task: T293924: Also run PHP 7.4 jobs on wmf branch patches.Oct 20 2021, 6:49 PM
Legoktm closed subtask T293449: Package php 7.4 for wikimedia production as Resolved.Oct 21 2021, 1:31 AM
gerritbot added a comment.Oct 25 2021, 7:21 PM

Change 732112 merged by jenkins-bot:

[integration/config@master] Docker: [php74] Switch PHP 7.4 from Sury to Wikimedia package

https://gerrit.wikimedia.org/r/732112

Stashbot added a comment.Oct 25 2021, 7:21 PM

Mentioned in SAL (#wikimedia-releng) [2021-10-25T19:21:43Z] <James_F> Docker: Publishing new php74 and cascaded images with PHP 7.4 from Wikimedia package T293851

gerritbot added a comment.Oct 25 2021, 7:28 PM

Change 734382 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Switch to PHP 7.4 images with Wikimedia not Sury package

https://gerrit.wikimedia.org/r/734382

Jdforrester-WMF closed this task as Resolved.Oct 25 2021, 8:13 PM
Jdforrester-WMF claimed this task.
gerritbot added a comment.Oct 25 2021, 8:14 PM

Change 734382 merged by jenkins-bot:

[integration/config@master] jjb: Switch to PHP 7.4 images with Wikimedia not Sury package

https://gerrit.wikimedia.org/r/734382

Legoktm reopened this task as Open.Nov 10 2021, 4:40 PM
Legoktm added a subscriber: hashar.

@hashar pointed out that quibble-buster-php74 is still using sury's images and got missed.

hashar added a comment.Nov 10 2021, 4:43 PM

We would need the Quibble images to be migrated as well, they are still using sury:

$ grep FROM dockerfiles/quibble-buster-php74/Dockerfile.template 
FROM {{ "sury-php" | image_tag }} AS sury-php

Which is more or less about replacing the sury APT by our component/php74.

Note that we have some additional use cases such as XDebug or pcov which would need packaging.

Daimona mentioned this in T243847: Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI.Nov 10 2021, 5:06 PM
hashar added a subtask: T243847: Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI.Nov 10 2021, 5:20 PM

We would need pcov which is used to generate coverage report and is way faster than XDebug for that purpose. I have made it a sub task: T243847: Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI

Legoktm closed subtask T243847: Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI as Resolved.Nov 10 2021, 7:23 PM

Both php7.4-xdebug and php7.4-pcov packages should be available now.

Daimona subscribed.Nov 10 2021, 7:35 PM
Daimona reopened subtask T243847: Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI as Open.Feb 7 2022, 2:47 PM
gerritbot added a comment.Mar 3 2022, 6:40 PM

Change 767861 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] [WIP] dockerfiles: [quibble-buster-php74] Migrate from sury-php to Wikimedia PHP

https://gerrit.wikimedia.org/r/767861

Jdforrester-WMF removed a subtask: T243847: Add pcov PHP extension to wikimedia apt (and upgrade from 1.0.6-4+wmf1~buster1 to 1.0.11) so it can be used in Wikimedia CI.Aug 9 2022, 7:18 PM
gerritbot added a comment.Aug 9 2022, 7:40 PM

Change 767861 merged by jenkins-bot:

[integration/config@master] dockerfiles: [quibble-buster-php74] Migrate from sury-php to Wikimedia PHP

https://gerrit.wikimedia.org/r/767861

Stashbot added a comment.Aug 9 2022, 7:42 PM

Mentioned in SAL (#wikimedia-releng) [2022-08-09T19:42:27Z] <James_F> Docker: Re-build and publish quibble-buster-php74 based on Wikimedia PHP not sury-php for T293851

gerritbot added a comment.Aug 9 2022, 8:40 PM

Change 821792 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Switch all quibble PHP74 jobs to images using Wikimedia's not Sury's PHP

https://gerrit.wikimedia.org/r/821792

Jdforrester-WMF closed this task as Resolved.Aug 9 2022, 8:53 PM
gerritbot added a comment.Aug 9 2022, 8:55 PM

Change 821792 merged by jenkins-bot:

[integration/config@master] jjb: Switch all quibble PHP74 jobs to images using Wikimedia's not Sury's PHP

https://gerrit.wikimedia.org/r/821792

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL