Page MenuHomePhabricator
Create Task
Maniphest T299827

Add gb_by_central_id column to globalblocks table
Closed, ResolvedPublic
Actions

Description

  1. The ALTER TABLEs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/+/f5e396266f288c9732bc8ed65709324a9b207be6/sql/mysql/patch-add-gb_by_central_id.sql
  2. Where to run those changes: centralauth database only
  3. When to run those changes: when dba has time
  4. If the schema change is backwards compatible: yes, only adds a nullable column
  5. If the schema change has been tested already on some of the test/beta wikis. Usually, as a last test, change should be applied to testwiki first: Tested locally
  6. If it involves new columns or tables, if the data should be made available on the labs replicas and/or dumps: Yes

Details

SubjectRepoBranchLines +/-
add_gb_by_central_id_T299827.py: Fixesoperations/software/schema-changesmaster+8 -11
add_gb_by_central_id_T299827.py: New schema changeoperations/software/schema-changesmaster+41 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Zabe created this task.Jan 22 2022, 1:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2022, 1:25 PM
Zabe added a parent task: T299371: Migrate globalblocks table to use central ids instead of usernames.Jan 22 2022, 1:25 PM
Stashbot added a comment.Jan 22 2022, 1:40 PM

Mentioned in SAL (#wikimedia-releng) [2022-01-22T13:40:31Z] <taavi> apply T299827 on deployment-prep centralauth database

• Marostegui claimed this task.Jan 24 2022, 5:41 AM
• Marostegui triaged this task as Medium priority.
• Marostegui moved this task from Triage to Ready on the DBA board.
gerritbot added a comment.Jan 24 2022, 5:58 AM

Change 756346 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/software/schema-changes@master] add_gb_by_central_id_T299827.py: New schema change

https://gerrit.wikimedia.org/r/756346

gerritbot added a project: Patch-For-Review.Jan 24 2022, 5:58 AM
• Marostegui added a comment.EditedJan 24 2022, 8:20 AM

@Zabe "If it involves new columns or tables, if the data should be made available on the labs replicas and/or dumps or not because they contain private or sensitive data: No" "no" meaning it doesn't contain private data or "no" it shouldn't be replicated to labs hosts.
I am assuming it is "No, there's no private data, so it can be replicated just as it is" but please confirm.
Thanks!

Zabe added a comment.Jan 24 2022, 9:18 AM
In T299827#7643591, @Marostegui wrote:

@Zabe "If it involves new columns or tables, if the data should be made available on the labs replicas and/or dumps or not because they contain private or sensitive data: No" "no" meaning it doesn't contain private data or "no" it shouldn't be replicated to labs hosts.
I am assuming it is "No, there's no private data, so it can be replicated just as it is" but please confirm.
Thanks!

Yes, it is meant as you assumed.

Ladsgroup subscribed.Jan 24 2022, 9:52 AM

Does centralauth get replicated to the cloud? I doubt that, let me check

• Marostegui added a comment.Jan 24 2022, 9:53 AM

Yes, it does.

gerritbot added a comment.Jan 24 2022, 10:23 AM

Change 756346 merged by Marostegui:

[operations/software/schema-changes@master] add_gb_by_central_id_T299827.py: New schema change

https://gerrit.wikimedia.org/r/756346

• Marostegui mentioned this in rSCHCH28d35a90480d: add_gb_by_central_id_T299827.py: New schema change.Jan 24 2022, 10:23 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 24 2022, 11:11 AM
• Marostegui moved this task from Ready to In progress on the DBA board.Jan 25 2022, 8:40 AM
• Marostegui added a comment.Jan 25 2022, 8:44 AM

I am going to start deploying this.

gerritbot added a comment.Jan 25 2022, 8:51 AM

Change 756948 had a related patch set uploaded (by Marostegui; author: Marostegui):

[operations/software/schema-changes@master] add_gb_by_central_id_T299827.py: Fixes

https://gerrit.wikimedia.org/r/756948

gerritbot added a project: Patch-For-Review.Jan 25 2022, 8:51 AM
gerritbot added a comment.Jan 25 2022, 9:37 AM

Change 756948 merged by Marostegui:

[operations/software/schema-changes@master] add_gb_by_central_id_T299827.py: Fixes

https://gerrit.wikimedia.org/r/756948

Stashbot added a comment.Jan 25 2022, 9:38 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T09:38:06Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1098:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19106 and previous config saved to /var/cache/conftool/dbconfig/20220125-093806-marostegui.json

• Marostegui mentioned this in rSCHCHe3be641260d1: add_gb_by_central_id_T299827.py: Fixes.Jan 25 2022, 9:38 AM
Stashbot added a comment.Jan 25 2022, 9:39 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T09:39:13Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19108 and previous config saved to /var/cache/conftool/dbconfig/20220125-093912-marostegui.json

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2022, 10:10 AM
Stashbot added a comment.Jan 25 2022, 10:24 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T10:24:27Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19116 and previous config saved to /var/cache/conftool/dbconfig/20220125-102426-marostegui.json

Stashbot added a comment.Jan 25 2022, 10:24 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T10:24:49Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1101:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19117 and previous config saved to /var/cache/conftool/dbconfig/20220125-102448-marostegui.json

Stashbot added a comment.Jan 25 2022, 11:21 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T11:21:12Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1101:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19126 and previous config saved to /var/cache/conftool/dbconfig/20220125-112111-marostegui.json

Stashbot added a comment.Jan 25 2022, 12:06 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T12:06:25Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1101:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19132 and previous config saved to /var/cache/conftool/dbconfig/20220125-120625-marostegui.json

Stashbot added a comment.Jan 25 2022, 12:06 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T12:06:34Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1127 (T299827)', diff saved to https://phabricator.wikimedia.org/P19133 and previous config saved to /var/cache/conftool/dbconfig/20220125-120632-marostegui.json

Stashbot added a comment.Jan 25 2022, 12:13 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T12:13:44Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1127 (T299827)', diff saved to https://phabricator.wikimedia.org/P19134 and previous config saved to /var/cache/conftool/dbconfig/20220125-121343-marostegui.json

Stashbot added a comment.Jan 25 2022, 12:58 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T12:58:57Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1127 (T299827)', diff saved to https://phabricator.wikimedia.org/P19141 and previous config saved to /var/cache/conftool/dbconfig/20220125-125857-marostegui.json

Stashbot added a comment.Jan 25 2022, 12:59 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T12:59:23Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1170:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19142 and previous config saved to /var/cache/conftool/dbconfig/20220125-125923-marostegui.json

Stashbot added a comment.Jan 25 2022, 1:00 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T13:00:33Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1170:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19143 and previous config saved to /var/cache/conftool/dbconfig/20220125-130032-marostegui.json

Stashbot added a comment.Jan 25 2022, 1:45 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T13:45:50Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1170:3317 (T299827)', diff saved to https://phabricator.wikimedia.org/P19154 and previous config saved to /var/cache/conftool/dbconfig/20220125-134547-marostegui.json

Stashbot added a comment.Jan 25 2022, 1:46 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T13:46:00Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1174 (T299827)', diff saved to https://phabricator.wikimedia.org/P19155 and previous config saved to /var/cache/conftool/dbconfig/20220125-134557-marostegui.json

Stashbot added a comment.Jan 25 2022, 1:47 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T13:47:05Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1174 (T299827)', diff saved to https://phabricator.wikimedia.org/P19156 and previous config saved to /var/cache/conftool/dbconfig/20220125-134704-marostegui.json

Stashbot added a comment.Jan 25 2022, 2:32 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T14:32:19Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1174 (T299827)', diff saved to https://phabricator.wikimedia.org/P19168 and previous config saved to /var/cache/conftool/dbconfig/20220125-143218-marostegui.json

Stashbot added a comment.Jan 25 2022, 2:32 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T14:32:32Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1158 (T299827)', diff saved to https://phabricator.wikimedia.org/P19169 and previous config saved to /var/cache/conftool/dbconfig/20220125-143232-marostegui.json

Stashbot added a comment.Jan 25 2022, 2:33 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T14:33:39Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1158 (T299827)', diff saved to https://phabricator.wikimedia.org/P19170 and previous config saved to /var/cache/conftool/dbconfig/20220125-143338-marostegui.json

Stashbot added a comment.Jan 25 2022, 3:18 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T15:18:53Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1158 (T299827)', diff saved to https://phabricator.wikimedia.org/P19180 and previous config saved to /var/cache/conftool/dbconfig/20220125-151852-marostegui.json

Stashbot added a comment.Jan 25 2022, 3:19 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T15:19:01Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1181 (T299827)', diff saved to https://phabricator.wikimedia.org/P19181 and previous config saved to /var/cache/conftool/dbconfig/20220125-151900-marostegui.json

Stashbot added a comment.Jan 25 2022, 3:20 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T15:20:07Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1181 (T299827)', diff saved to https://phabricator.wikimedia.org/P19182 and previous config saved to /var/cache/conftool/dbconfig/20220125-152006-marostegui.json

Stashbot added a comment.Jan 25 2022, 4:05 PM

Mentioned in SAL (#wikimedia-operations) [2022-01-25T16:05:22Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1181 (T299827)', diff saved to https://phabricator.wikimedia.org/P19195 and previous config saved to /var/cache/conftool/dbconfig/20220125-160522-marostegui.json

• Marostegui closed this task as Resolved.Jan 26 2022, 6:15 AM

This is all done

Zabe updated the task description. (Show Details)Feb 4 2022, 4:35 PM
Zabe closed subtask T300988: Recreate views for globalblocks table as Resolved.Jan 20 2024, 4:29 PM
Maintenance_bot moved this task from In progress to Done on the DBA board.Jan 20 2024, 5:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL