Install unzip in CI images again
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 9 2022, 5:30 PM

Description

Seen on https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php73-selenium-docker/13599/consoleFull during Composer stages

17:15:09 [37.4MiB/1.49s] As there is no 'unzip' nor '7z' command installed zip files are being unpacked using the PHP zip extension.
17:15:09 [37.4MiB/1.49s] This may cause invalid reports of corrupted archives. Besides, any UNIX permissions (e.g. executable) defined in the archives will be lost.
17:15:09 [37.4MiB/1.49s] Installing 'unzip' or '7z' may remediate them.

These feel new... Fallout from the image upgrades to Bullseye?

Details

	Subject	Repo	Branch	Lines +/-
	jjb: Update all quibble jobs to images with unzip	integration/config	master	+32 -32
	dockerfiles: [quibble-buster] Add unzip package (and cascade)	integration/config	master	+64 -1

Customize query in gerrit

Related Objects

Mentioned In: T250496: Install unzip
Mentioned Here: rCICFd92febf77269: dockerfiles: [mediawiki-phan-taint-check-demo] Install ext-zip and unzip
T250496: Install unzip

Event Timeline

Reedy created this task.Mar 9 2022, 5:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2022, 5:30 PM

Reedy updated the task description. (Show Details)Mar 9 2022, 5:31 PM

It's definitely a regression this time! See T250496: Install unzip

Reedy renamed this task from Install unzip in CI images? to Install unzip in CI images again.Mar 9 2022, 6:00 PM

The message can be found in integration/composer at 1.10.5 from two years ago. We run 2.1.8 now. The commit is https://github.com/composer/composer/commit/379d7691326304b91c250faabbf252f9e257c12f which is from 2016 and was in 1.0.0-beta1.

T250496 missed the Quibble images. We also added it to phan image with d92febf77269a3e9127089de9b54c3003373ea5c

I guess we can add unzip to dockerfiles/quibble-buster/Dockerfile.template.

Change 769517 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] dockerfiles: add unzip package to Quibble images

https://gerrit.wikimedia.org/r/769517

gerritbot added a project: Patch-For-Review.Mar 9 2022, 8:40 PM

Change 769517 merged by jenkins-bot:

[integration/config@master] dockerfiles: [quibble-buster] Add unzip package (and cascade)

https://gerrit.wikimedia.org/r/769517

Mentioned in SAL (#wikimedia-releng) [2022-03-10T14:26:35Z] <James_F> Docker: Publishing new versions of quibble-buster and cascade adding unzip for T250496 / T303417.

Change 769704 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] jjb: Update all quibble jobs to images with unzip

https://gerrit.wikimedia.org/r/769704

Change 769704 merged by jenkins-bot: