Page MenuHomePhabricator
Create Task
Maniphest T32033

stroke-dasharray in PNG thumbnails does not support spaces as separators
Closed, ResolvedPublic
Actions

Description

Author: rainald.koch

Description:
https://commons.wikimedia.org/wiki/File:Doppler_radar_cos_factor.svg looks fine in IE9 and Firefox but is not properly converted to PNG.

stroke-dasharray is used to draw an arc (section of a circle) and to mark initial parts of several straight lines.

<circle cx="70" cy="140" r="31" fill="none" stroke-dasharray="0 170.4 33 0" />

A full circle is drawn instead of drawing only the last 1/8 of the circle (315° to 360°, after a zero-length dash and a gap of 7/8 of the circumference).

<path d="M 10 10L200 10" stroke-dasharray="61.6 333" />
There are many dashes and gaps of equal lengths instead of only one dash on the beginning of the line and a subsequent gap beyond the end of the line.

#5110 is also on stroke-dasharray, closed as FIXED. Obviously, testing is carelessly neglected.
Opened again on 2016-01-30 (T32033#1983515)

Version: unspecified
Severity: normal

Details

Reference
bz30033

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:49 PM
• bzimport added a project: MediaWiki-File-management.
• bzimport set Reference to bz30033.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jul 24 2011, 12:41 AM
TheDJ added a comment.Jul 24 2011, 3:12 PM

well it apparently is fixed. Upstream. It's just that the rsvg software we use on the server hasn't been updated in years....

MarkAHershberger added a comment.Jul 25 2011, 11:04 PM
  • This bug has been marked as a duplicate of bug 24000 ***
• Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:27 AM
• Gilles added a project: Multimedia.
• Gilles moved this task from Untriaged to Done on the Multimedia board.
• Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM
Perhelion reopened this task as Open.Jan 30 2016, 1:28 AM
Perhelion updated the task description. (Show Details)
Perhelion set Security to None.
Restricted Application added a project: Commons. · View Herald TranscriptJan 30 2016, 1:28 AM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald Transcript
Perhelion subscribed.EditedJan 30 2016, 1:35 AM

As we can see on the initiation example the bug exist again.
Another example https://upload.wikimedia.org/wikipedia/commons/thumb/archive/6/62/20160130151712!Anne_Beadell_Highway_0116.svg/800px-Anne_Beadell_Highway_0116.svg.png
The blue dashed line should look like this https://commons.wikimedia.org/wiki/File:Anne_Beadell_Highway_0116.svg

The issue is simple that whitespaces as replacement for commas are not recognized.
is fine:

stroke-dasharray="120,20"

is not fine (but W3-conform)

stroke-dasharray="120 20"
Ricordisamoa subscribed.Jan 30 2016, 7:57 AM
JeanFred moved this task from Incoming to Thumbnail and file renderings on the Commons board.Jan 31 2016, 12:10 PM
Perhelion edited projects, added Wikimedia-SVG-rendering; removed Commons, Multimedia, MediaWiki-File-management.Jan 31 2016, 1:20 PM
Perhelion renamed this task from svg to png error with stroke-dasharray to SVG to PNG error with stroke-dasharray.Jan 31 2016, 1:25 PM
Perhelion updated the task description. (Show Details)
Aklapper renamed this task from SVG to PNG error with stroke-dasharray to stroke-dasharray in PNG thumbnails rendered with incorrect lengths/gaps.Mar 8 2016, 11:34 PM
Aklapper lowered the priority of this task from Medium to Low.
Ricordisamoa added a project: Upstream.Mar 9 2016, 2:54 AM

https://bugzilla.gnome.org/show_bug.cgi?id=762919#c1

Ricordisamoa renamed this task from stroke-dasharray in PNG thumbnails rendered with incorrect lengths/gaps to stroke-dasharray in PNG thumbnails does not support spaces as separators.Mar 9 2016, 2:55 AM
Ricordisamoa moved this task from Backlog to Patch proposed upstream on the Upstream board.
JoKalliauer subscribed.Dec 16 2017, 8:58 PM
Ricordisamoa moved this task from Patch proposed upstream to Patch merged upstream on the Upstream board.Feb 3 2018, 5:22 PM

https://gitlab.gnome.org/GNOME/librsvg/issues/136

JoKalliauer mentioned this in T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.Jul 22 2018, 10:26 AM
TheDJ added a comment.Aug 10 2018, 10:56 PM

Just a note that this is fixed in librsvg 2.42.2, just like T193352: Update librsvg to ≥2.42.3 (2.44.10)

Liuxinyu970226 subscribed.Oct 30 2018, 4:20 AM
Liuxinyu970226 awarded a token.Nov 11 2018, 12:23 PM
• Phabricator_maintenance removed a parent task: T10901: [DO NOT USE] SVG rasterisation and management on Wikimedia sites (tracking).Feb 22 2019, 3:15 PM
Aklapper added a parent task: T193352: Update librsvg to ≥2.42.3 (2.44.10).Mar 10 2019, 5:21 PM
JoKalliauer mentioned this in T243893: Test resvg on Beta Cluster.Jan 29 2020, 12:05 PM
AntiCompositeNumber removed a parent task: T193352: Update librsvg to ≥2.42.3 (2.44.10).May 14 2020, 4:10 AM
AntiCompositeNumber added a subtask: T193352: Update librsvg to ≥2.42.3 (2.44.10).
AntiCompositeNumber added a project: Thumbor.
AntiCompositeNumber moved this task from Backlog to Upstream on the Thumbor board.
MarkAHershberger unsubscribed.May 14 2020, 3:23 PM
AntiCompositeNumber moved this task from Upstream to Upstream (librsvg) on the Thumbor board.May 22 2020, 4:03 AM
toorich changed the status of subtask T193352: Update librsvg to ≥2.42.3 (2.44.10) from Stalled to Open.Jun 24 2020, 9:59 AM
Aklapper changed the status of subtask T193352: Update librsvg to ≥2.42.3 (2.44.10) from Open to Stalled.Jun 24 2020, 10:34 AM
JoKalliauer moved this task from Backlog to update librsvg on the Wikimedia-SVG-rendering board.Jun 30 2021, 3:07 PM
hnowlan closed subtask T193352: Update librsvg to ≥2.42.3 (2.44.10) as Resolved.May 17 2023, 11:36 AM
hnowlan subscribed.May 17 2023, 12:03 PM

This has been resolved as part of T193352

hnowlan closed this task as Resolved.May 17 2023, 12:03 PM
hnowlan claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL