Page MenuHomePhabricator

Krinkle (Timo Tijhof)
Principal Engineer (Wikimedia Performance)Administrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 4:41 AM (497 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Krinkle
LDAP User
Krinkle
MediaWiki User
Krinkle [ Global Accounts ]

(Photo by Niek Hidding.)

Recent Activity

Today

Krinkle closed T353144: [css-guards] Fix parsing of "when" conditions after selectors with a pseudo classes (e.g. "a:hover"), a subtask of T288498: Update less.php port to support Less.js 3.13 behaviours, as Resolved.
Fri, Apr 19, 3:40 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, MediaWiki-Platform-Team, Less.php, Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader
Krinkle closed T353144: [css-guards] Fix parsing of "when" conditions after selectors with a pseudo classes (e.g. "a:hover") as Resolved.
Fri, Apr 19, 3:40 PM · Patch-For-Review, MediaWiki-Platform-Team, Less.php

Yesterday

Krinkle added a project to T326705: Allow php-fpm to read environment variables from the system, not just from the fcgi request: MediaWiki-Platform-Team (Radar).
Thu, Apr 18, 11:04 PM · MediaWiki-Platform-Team (Radar), MW-on-K8s, serviceops
Krinkle added a comment to T362532: Avoid "missing topic" warning on non-discussion pages.

@Esanders I vaguely recall a series of older DT tasks about the problems with DT using wgExtraSignatureNamespaces in this way to make a seemingly final decision that a page is a talk page when there are numerous indicators to the contrary, and/or requesting for ways to create a way to either opt-in or opt-out from that decision.

Thu, Apr 18, 11:00 PM · DiscussionTools
Krinkle added a comment to T362908: Update Fresh's version of Node 18 from 18.17.0 to 18.20.2.

To RelEng: The way we usually structure these tasks is to link to the previous one for the same purpose (Fresh) and track "Create image" as the subtask.

Thu, Apr 18, 5:17 PM · Release-Engineering-Team, Fresh
Krinkle updated the task description for T362908: Update Fresh's version of Node 18 from 18.17.0 to 18.20.2.
Thu, Apr 18, 4:34 PM · Release-Engineering-Team, Fresh
Krinkle added a parent task for T331181: Create WMF CI images and jobs for Node.js 18: T362908: Update Fresh's version of Node 18 from 18.17.0 to 18.20.2.
Thu, Apr 18, 4:34 PM · Continuous-Integration-Infrastructure
Krinkle added a subtask for T362908: Update Fresh's version of Node 18 from 18.17.0 to 18.20.2: T331181: Create WMF CI images and jobs for Node.js 18.
Thu, Apr 18, 4:34 PM · Release-Engineering-Team, Fresh
Krinkle updated the task description for T362908: Update Fresh's version of Node 18 from 18.17.0 to 18.20.2.
Thu, Apr 18, 4:33 PM · Release-Engineering-Team, Fresh
Krinkle added a project to T362908: Update Fresh's version of Node 18 from 18.17.0 to 18.20.2: Release-Engineering-Team.
Thu, Apr 18, 4:33 PM · Release-Engineering-Team, Fresh
Krinkle added a comment to T362901: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value.

Actually, it seems the above patch did not fix the issue.

Thu, Apr 18, 3:34 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Structured-Data-Backlog, GlobalUsage, Wikimedia-production-error
Krinkle added a comment to T362901: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value.

We have also:

Thu, Apr 18, 3:27 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Structured-Data-Backlog, GlobalUsage, Wikimedia-production-error
Krinkle updated subscribers of T362901: UnexpectedValueException: Wikimedia\Rdbms\InsertQueryBuilder::execute can't have empty $rows value.
July 2023:
Thu, Apr 18, 3:26 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, Structured-Data-Backlog, GlobalUsage, Wikimedia-production-error

Wed, Apr 17

Krinkle added a comment to T330525: Migrate Wikidata off of Blazegraph.

FYI: Periodic updates about this topic appear to be posted to https://www.wikidata.org/wiki/Wikidata:SPARQL_query_service/WDQS_backend_update#Current_status, including several updates since the filing of this task, and the last one was a few days ago.

Wed, Apr 17, 7:14 PM · Wikidata, Wikidata-Query-Service
Krinkle updated the task description for T330525: Migrate Wikidata off of Blazegraph.
Wed, Apr 17, 7:12 PM · Wikidata, Wikidata-Query-Service
Krinkle updated the task description for T330525: Migrate Wikidata off of Blazegraph.
Wed, Apr 17, 7:10 PM · Wikidata, Wikidata-Query-Service
Krinkle added a comment to T354968: Use recommended code coverage annotation method in PHPUnit tests.

Nice to see that upstream now recommends the same! I've been supporting this for a while with similar changes and similar reasoning in these commits:

Wed, Apr 17, 1:01 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Test-Coverage

Tue, Apr 16

Krinkle added a comment to T175146: JobQueue: Unify JobRunner entry points.

Why do you think that endpoint should be removed first? I thin the order doesn't matter...

Tue, Apr 16, 6:05 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
Krinkle renamed T352862: [css-3.less test case] Add support for /deep/ selector from Add support for /deep/ selector (css-3 test case) to [css-3.less test case] Add support for /deep/ selector.
Tue, Apr 16, 1:43 PM · MediaWiki-Platform-Team, Less.php
Krinkle closed T352862: [css-3.less test case] Add support for /deep/ selector, a subtask of T288498: Update less.php port to support Less.js 3.13 behaviours, as Resolved.
Tue, Apr 16, 1:30 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, MediaWiki-Platform-Team, Less.php, Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader
Krinkle closed T352862: [css-3.less test case] Add support for /deep/ selector as Resolved.
Tue, Apr 16, 1:30 PM · MediaWiki-Platform-Team, Less.php

Mon, Apr 15

Krinkle triaged T350094: Enable verbose logging without installing the WikimediaDebug extension as Medium priority.
Mon, Apr 15, 3:27 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Platform-Team, MediaWiki-Debug-Logger, observability
Krinkle updated the task description for T261462: Migrate OAuth extension back from wikimedia/oauth2-server fork to upstream.
Mon, Apr 15, 3:25 PM · MediaWiki-extensions-OAuth, MediaWiki-Platform-Team, serviceops, Technical-Debt, Upstream
Krinkle removed a parent task for T261462: Migrate OAuth extension back from wikimedia/oauth2-server fork to upstream: T255034: Wikimedia API Gateway Long-term Use.
Mon, Apr 15, 3:24 PM · MediaWiki-extensions-OAuth, MediaWiki-Platform-Team, serviceops, Technical-Debt, Upstream
Krinkle renamed T261462: Migrate OAuth extension back from wikimedia/oauth2-server fork to upstream from [API Gateway] Migrate away from wikimedia/oauth2-server fork to upstream to Migrate OAuth extension back from wikimedia/oauth2-server fork to upstream.
Mon, Apr 15, 3:24 PM · MediaWiki-extensions-OAuth, MediaWiki-Platform-Team, serviceops, Technical-Debt, Upstream
Krinkle removed a subtask for T255034: Wikimedia API Gateway Long-term Use: T261462: Migrate OAuth extension back from wikimedia/oauth2-server fork to upstream.
Mon, Apr 15, 3:24 PM · serviceops, Platform Engineering Roadmap, Epic, Platform Team Workboards (Epics), Platform Team Initiatives (API Gateway)
Krinkle triaged T362216: Unable to set JavaScript breakpoints in gadget code when using ?debug=1 as Medium priority.
Mon, Apr 15, 3:18 PM · Developer Productivity, MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Krinkle assigned T362216: Unable to set JavaScript breakpoints in gadget code when using ?debug=1 to Hokwelum.

I'll take this one with Hannah to look at next week.

Mon, Apr 15, 3:18 PM · Developer Productivity, MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Krinkle added a project to T359436: StatsLib equivalent of PerDbNameStatsdDataFactory: MediaWiki-Platform-Team (Radar).
Mon, Apr 15, 3:08 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Patch-For-Review, MediaWiki-libs-Stats
Krinkle moved T362343: Fix failing less-2.5.3/css.less test from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Mon, Apr 15, 2:38 PM · MediaWiki-Platform-Team, Less.php
Krinkle moved T362341: Fix failing less-2.5.3/variables.less test from Inbox, needs triage to Soon on the MediaWiki-Platform-Team board.
Mon, Apr 15, 2:38 PM · MediaWiki-Platform-Team, Less.php, Technical-Debt
Krinkle added a comment to T362331: SessionBackend: remove dependency on Kask/Cassandra.

Maybe. You raised a good point, though, about avoiding reading from MultiWriteBag and ReplicatedBag by design does not (completely) avoid that. Maybe an optional "read" option in MultiWriteBag would be more useful to us.

Mon, Apr 15, 1:39 PM · MediaWiki-Platform-Team
Krinkle updated the task description for T362532: Avoid "missing topic" warning on non-discussion pages.
Mon, Apr 15, 1:24 PM · DiscussionTools
Krinkle created T362532: Avoid "missing topic" warning on non-discussion pages.
Mon, Apr 15, 1:23 PM · DiscussionTools

Sun, Apr 14

Krinkle added a comment to T275033: MessageCache generates high number of memcache GETs for nonexistent messages.

Fandom hotpatch related to this:
https://github.com/Wikia/mediawiki/commit/026bf08a8f8d75a4051360833cbae75fedec7f45

Sun, Apr 14, 10:52 PM · Wikimedia-Performance-recommendation, MediaWiki-Internationalization
Krinkle added a comment to T362480: Introduces the notion of modules into the REST API framework.

As does ResourceLoader, for its resource bundles.

Sun, Apr 14, 6:45 PM · Patch-For-Review, Documentation, MW-Interfaces-Team, MediaWiki-REST-API
Krinkle added a comment to T175146: JobQueue: Unify JobRunner entry points.

@daniel Is the REST API safe to remove from the EventBus extension? We may want to do that first.

Sun, Apr 14, 6:06 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration

Sat, Apr 13

Krinkle added a comment to T359168: Knowledge sharing MWP - SRE O11Y mw.track().

Notes from meeting:

Sat, Apr 13, 11:14 AM · SRE Observability (FY2023/2024-Q4), MediaWiki-Platform-Team, Observability-Metrics
Krinkle updated the task description for T359168: Knowledge sharing MWP - SRE O11Y mw.track().
Sat, Apr 13, 10:58 AM · SRE Observability (FY2023/2024-Q4), MediaWiki-Platform-Team, Observability-Metrics
Krinkle updated the task description for T359168: Knowledge sharing MWP - SRE O11Y mw.track().
Sat, Apr 13, 10:55 AM · SRE Observability (FY2023/2024-Q4), MediaWiki-Platform-Team, Observability-Metrics

Fri, Apr 12

Quiddity awarded P4469 IBrokeWikipediaList a Love token.
Fri, Apr 12, 11:55 PM
Krinkle awarded T325480: defer javascript instead of async for better performance a Love token.
Fri, Apr 12, 9:27 PM · MediaWiki-Platform-Team, Performance-Team (Radar), MediaWiki-ResourceLoader
Krinkle added a comment to T175146: JobQueue: Unify JobRunner entry points.

@daniel Are you thinking about IP subnets as protection mechanism because you prefer it, or because you think it's what we use today? Of the 5 job runners in the task description, number 4 used this mechanism. However that one (runJobs.php) has not been in use for several years. I've updated the task description to clarify this.

Fri, Apr 12, 4:51 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
Krinkle updated the task description for T175146: JobQueue: Unify JobRunner entry points.
Fri, Apr 12, 4:49 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
Krinkle updated the task description for T175146: JobQueue: Unify JobRunner entry points.
Fri, Apr 12, 4:48 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
Krinkle updated the task description for T175146: JobQueue: Unify JobRunner entry points.
Fri, Apr 12, 4:48 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
Krinkle updated the task description for T175146: JobQueue: Unify JobRunner entry points.
Fri, Apr 12, 4:48 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
Krinkle added a comment to T107254: Closed tickets in Bugzilla migrated without a closing date.

@valerio.bozzolan The SQL statements and comments appear in contradiction. For every comment that says "Skipped bug X - state was REOPENED" there is in fact a real update statement that does exactly what the comment says it doesn't. Is this intentional?

Fri, Apr 12, 4:39 PM · DevRel-November-2015, Phabricator, Bugzilla-Migration, wikimedia.biterg.io
Krinkle renamed T362335: Decide on MediaWiki session store at WMF (2024) from Decide where to store Session Data to Decide on MediaWiki session store at WMF (2024).
Fri, Apr 12, 2:53 PM · MediaWiki-Platform-Team

Thu, Apr 11

Krinkle edited projects for T341319: RecentChanges: Improve performance of Special:RecentChanges rendering , added: MediaWiki-Platform-Team (Radar); removed MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).
Thu, Apr 11, 9:12 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Krinkle updated subscribers of T341319: RecentChanges: Improve performance of Special:RecentChanges rendering .
Thu, Apr 11, 8:52 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Krinkle added a comment to T341319: RecentChanges: Improve performance of Special:RecentChanges rendering .

Change 938220 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/core@master] PermissionManager: Avoid restrictions lookup for unsupported actions

https://gerrit.wikimedia.org/r/938220

Thu, Apr 11, 8:50 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Krinkle added a comment to T362331: SessionBackend: remove dependency on Kask/Cassandra.

One option would be to use ReplicatedBagOStuff combined with MultiWriteBagOStuff. Write to both. Read from one. This would, however, mean that, the resulting stack is four levels of bagostuffs, given that SessionBackend wraps it as well:

Thu, Apr 11, 8:34 PM · MediaWiki-Platform-Team
Krinkle added a project to T336250: Decrease wgWatchersMaxAge to 30 days, and display this on `action=info`: MediaWiki-Platform-Team (Radar).
Thu, Apr 11, 12:13 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), User-notice, Community-Wishlist-Survey-2023, MediaWiki-General, Wikimedia Wishathon
Krinkle added a comment to T325480: defer javascript instead of async for better performance.

@Sophivorus I'm curious about what benefit you expect in this case. Can you describe (or e.g. draw on a devtools network screenshot) what activities you expect would move or shrink in the timeline?

Thu, Apr 11, 12:13 AM · MediaWiki-Platform-Team, Performance-Team (Radar), MediaWiki-ResourceLoader

Tue, Apr 9

Krinkle added a comment to T361070: Performance review of CommunityConfiguration.

@Urbanecm_WMF From the code documentation, I understand IConfigurationProvider to be the main entrypoint. However, I could not find an example of this in the extensions tests. Could you add a high-level integration test to demonstrate how it would be used? That would make it easier to check which parts will become used in the critical path, and which not.

Tue, Apr 9, 8:51 PM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, CommunityConfiguration, Growth-Team, MediaWiki-Platform-Team
Krinkle added a comment to T359643: Get rid of the /srv/mediawiki/php symbolic link.

I understand the redirect is limited to mediawiki.org, but by redirecting, the URL that ends up in circulation will become inevitably the destination, which then promotes the generic URL that can easily be mistaken for that on another wiki, or even be attempted as "correct" as users try to help themselves by using the "right" one (with questions about which one to use in a cross-wiki context).

Tue, Apr 9, 8:29 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Release-Engineering-Team (Now this 🫠), MediaWiki-libs-Mime, MediaWiki-Platform-Team (Radar), Scap
Krinkle added a comment to T359643: Get rid of the /srv/mediawiki/php symbolic link.

@dancy Are you proposing a redirect in general, or only for appservers? (Is this easier than a rewrite?)

Tue, Apr 9, 7:50 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Release-Engineering-Team (Now this 🫠), MediaWiki-libs-Mime, MediaWiki-Platform-Team (Radar), Scap
Krinkle assigned T353146: [import.less fixture] Importing files with url() in nested files doesn’t import files to Hokwelum.
Tue, Apr 9, 4:54 PM · MediaWiki-Platform-Team, Less.php

Mon, Apr 8

Krinkle closed T361035: [Regression] CSS import with variable name no longer works, a subtask of T288498: Update less.php port to support Less.js 3.13 behaviours, as Resolved.
Mon, Apr 8, 10:39 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Patch-For-Review, MediaWiki-Platform-Team, Less.php, Design-System-Team, Technical-Debt, MediaWiki-ResourceLoader
Krinkle closed T361035: [Regression] CSS import with variable name no longer works as Resolved.
Mon, Apr 8, 10:39 AM · Patch-For-Review, MediaWiki-Platform-Team, Regression, Less.php
Krinkle updated the task description for T361035: [Regression] CSS import with variable name no longer works.
Mon, Apr 8, 10:31 AM · Patch-For-Review, MediaWiki-Platform-Team, Regression, Less.php
Krinkle added a comment to T352913: session_write_close failure in PHPSessionHandlerTest under php8.3.

It appears to me that the immediate failure here is that the session directory at /var/lib/php/sessions is not writable (ie it doesn't exist and the "nobody" user in CI isn't allowed to create it).

Mon, Apr 8, 3:25 AM · MediaWiki-Platform-Team, PHP 8.3 support, MediaWiki-Core-AuthManager
Krinkle committed rPSMTefc15c564de6: Keep HTML for Firefox runs (authored by Peter).
Keep HTML for Firefox runs
Mon, Apr 8, 3:13 AM
Krinkle committed rPSMT89d13fd551f3: Move Browsertime Chrome setup to Browsertime section. (authored by Peter).
Move Browsertime Chrome setup to Browsertime section.
Mon, Apr 8, 3:13 AM

Sat, Apr 6

Krinkle closed T337161: Make PHPUnit dataProvider static in OAuth tests as Resolved.
Sat, Apr 6, 11:38 PM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-extensions-OAuth
Krinkle closed T337161: Make PHPUnit dataProvider static in OAuth tests, a subtask of T332865: PHPUnit data providers should be simple static functions that return plain data, as Resolved.
Sat, Apr 6, 11:36 PM · MW-1.41-notes (1.41.0-wmf.20; 2023-08-01), Patch-For-Review, MediaWiki-General

Fri, Apr 5

Krinkle closed T361899: Let codesearch-frontend reques to local Hound instances directly as Resolved.
Fri, Apr 5, 8:09 PM · Patch-For-Review, VPS-project-Codesearch
Krinkle added a comment to T361899: Let codesearch-frontend reques to local Hound instances directly.

I've tested this locally on codesearch8 by using iptables-save and iptables-restore and adding

Fri, Apr 5, 3:20 AM · Patch-For-Review, VPS-project-Codesearch
Krinkle updated the task description for T361899: Let codesearch-frontend reques to local Hound instances directly.
Fri, Apr 5, 3:19 AM · Patch-For-Review, VPS-project-Codesearch
Krinkle added a comment to T361899: Let codesearch-frontend reques to local Hound instances directly.

Thank you @cmooney, that's amazing. That rule is very specific to just port 3002. That explains a few other things I was struggling with.

Fri, Apr 5, 3:13 AM · Patch-For-Review, VPS-project-Codesearch

Thu, Apr 4

Krinkle updated subscribers of T361899: Let codesearch-frontend reques to local Hound instances directly.

@cmooney suggested I run these commamds for some detail:

  • iptables -L -v --line -n
  • iptables -L -v --line -n -t nat
  • ip netns list

1root@codesearch8:~# iptables -L -v --line -n
2Chain INPUT (policy DROP 96 packets, 5200 bytes)
3num pkts bytes target prot opt in out source destination
41 3036K 4107M ACCEPT all -- * * 0.0.0.0/0 0.0.0.0/0 state RELATED,ESTABLISHED
52 212K 13M ACCEPT all -- lo * 0.0.0.0/0 0.0.0.0/0
63 0 0 ACCEPT all -- * * 0.0.0.0/0 0.0.0.0/0 PKTTYPE = multicast
74 0 0 DROP tcp -- * * 0.0.0.0/0 0.0.0.0/0 state NEW tcp flags:!0x17/0x02
85 2 168 ACCEPT icmp -- * * 0.0.0.0/0 0.0.0.0/0
96 15097 906K ACCEPT tcp -- * * 172.16.5.238 0.0.0.0/0 tcp dpt:3002
107 0 0 ACCEPT tcp -- * * 172.16.5.200 0.0.0.0/0 tcp dpt:3002
118 1 60 ACCEPT all -- * * 172.16.6.65 0.0.0.0/0
129 1 60 ACCEPT all -- * * 172.16.0.229 0.0.0.0/0
1310 1 60 ACCEPT tcp -- * * 172.16.1.220 0.0.0.0/0 tcp dpt:22
1411 8 472 ACCEPT tcp -- * * 172.16.3.145 0.0.0.0/0 tcp dpt:22
1512 0 0 ACCEPT tcp -- * * 172.16.5.168 0.0.0.0/0 tcp dpt:22
1613 0 0 ACCEPT tcp -- * * 172.16.4.160 0.0.0.0/0 tcp dpt:22
1714 0 0 ACCEPT tcp -- * * 172.16.2.249 0.0.0.0/0 tcp dpt:22
1815 0 0 ACCEPT tcp -- * * 172.16.1.220 0.0.0.0/0 tcp dpt:22
1916 5164 1694K DROP udp -- * * 0.0.0.0/0 255.255.255.255 udp spt:67 dpt:68
2017 91 5000 NFLOG all -- * * 0.0.0.0/0 0.0.0.0/0 limit: avg 1/sec burst 5 nflog-prefix "[fw-in-drop]"
21
22Chain FORWARD (policy DROP 0 packets, 0 bytes)
23num pkts bytes target prot opt in out source destination
241 15M 24G DOCKER-USER all -- * * 0.0.0.0/0 0.0.0.0/0
252 15M 24G DOCKER-ISOLATION-STAGE-1 all -- * * 0.0.0.0/0 0.0.0.0/0
263 7608K 23G ACCEPT all -- * docker0 0.0.0.0/0 0.0.0.0/0 ctstate RELATED,ESTABLISHED
274 14998 900K DOCKER all -- * docker0 0.0.0.0/0 0.0.0.0/0
285 6885K 1146M ACCEPT all -- docker0 !docker0 0.0.0.0/0 0.0.0.0/0
296 0 0 ACCEPT all -- docker0 docker0 0.0.0.0/0 0.0.0.0/0
30
31Chain OUTPUT (policy ACCEPT 0 packets, 0 bytes)
32num pkts bytes target prot opt in out source destination
33
34Chain DOCKER-INGRESS (0 references)
35num pkts bytes target prot opt in out source destination
36
37Chain DOCKER-USER (1 references)
38num pkts bytes target prot opt in out source destination
391 15M 24G RETURN all -- * * 0.0.0.0/0 0.0.0.0/0
40
41Chain DOCKER (1 references)
42num pkts bytes target prot opt in out source destination
431 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.3 tcp dpt:6080
442 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.5 tcp dpt:6080
453 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.7 tcp dpt:6080
464 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.8 tcp dpt:6080
475 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.9 tcp dpt:6080
486 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.10 tcp dpt:6080
497 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.11 tcp dpt:6080
508 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.13 tcp dpt:6080
519 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.14 tcp dpt:6080
5210 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.15 tcp dpt:6080
5311 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.6 tcp dpt:6080
5412 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.16 tcp dpt:6080
5513 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.17 tcp dpt:6080
5614 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.18 tcp dpt:6080
5715 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.20 tcp dpt:6080
5816 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.19 tcp dpt:6080
5917 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.12 tcp dpt:6080
6018 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.21 tcp dpt:6080
6119 0 0 ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.4 tcp dpt:6080
6220 10295 618K ACCEPT tcp -- !docker0 docker0 0.0.0.0/0 172.17.0.2 tcp dpt:80
63
64Chain DOCKER-ISOLATION-STAGE-1 (1 references)
65num pkts bytes target prot opt in out source destination
661 6885K 1146M DOCKER-ISOLATION-STAGE-2 all -- docker0 !docker0 0.0.0.0/0 0.0.0.0/0
672 15M 24G RETURN all -- * * 0.0.0.0/0 0.0.0.0/0
68
69Chain DOCKER-ISOLATION-STAGE-2 (1 references)
70num pkts bytes target prot opt in out source destination
711 0 0 DROP all -- * docker0 0.0.0.0/0 0.0.0.0/0
722 6885K 1146M RETURN all -- * * 0.0.0.0/0 0.0.0.0/0
73
74
75root@codesearch8:~# iptables -L -v --line -n -t nat
76Chain PREROUTING (policy ACCEPT 612K packets, 39M bytes)
77num pkts bytes target prot opt in out source destination
781 30163 1810K DOCKER all -- * * 0.0.0.0/0 0.0.0.0/0 ADDRTYPE match dst-type LOCAL
79
80Chain INPUT (policy ACCEPT 0 packets, 0 bytes)
81num pkts bytes target prot opt in out source destination
82
83Chain POSTROUTING (policy ACCEPT 447K packets, 27M bytes)
84num pkts bytes target prot opt in out source destination
851 592K 37M MASQUERADE all -- * !docker0 172.17.0.0/16 0.0.0.0/0
862 0 0 MASQUERADE tcp -- * * 172.17.0.3 172.17.0.3 tcp dpt:6080
873 0 0 MASQUERADE tcp -- * * 172.17.0.5 172.17.0.5 tcp dpt:6080
884 0 0 MASQUERADE tcp -- * * 172.17.0.7 172.17.0.7 tcp dpt:6080
895 0 0 MASQUERADE tcp -- * * 172.17.0.8 172.17.0.8 tcp dpt:6080
906 0 0 MASQUERADE tcp -- * * 172.17.0.9 172.17.0.9 tcp dpt:6080
917 0 0 MASQUERADE tcp -- * * 172.17.0.10 172.17.0.10 tcp dpt:6080
928 0 0 MASQUERADE tcp -- * * 172.17.0.11 172.17.0.11 tcp dpt:6080
939 0 0 MASQUERADE tcp -- * * 172.17.0.13 172.17.0.13 tcp dpt:6080
9410 0 0 MASQUERADE tcp -- * * 172.17.0.14 172.17.0.14 tcp dpt:6080
9511 0 0 MASQUERADE tcp -- * * 172.17.0.15 172.17.0.15 tcp dpt:6080
9612 0 0 MASQUERADE tcp -- * * 172.17.0.6 172.17.0.6 tcp dpt:6080
9713 0 0 MASQUERADE tcp -- * * 172.17.0.16 172.17.0.16 tcp dpt:6080
9814 0 0 MASQUERADE tcp -- * * 172.17.0.17 172.17.0.17 tcp dpt:6080
9915 0 0 MASQUERADE tcp -- * * 172.17.0.18 172.17.0.18 tcp dpt:6080
10016 0 0 MASQUERADE tcp -- * * 172.17.0.20 172.17.0.20 tcp dpt:6080
10117 0 0 MASQUERADE tcp -- * * 172.17.0.19 172.17.0.19 tcp dpt:6080
10218 0 0 MASQUERADE tcp -- * * 172.17.0.12 172.17.0.12 tcp dpt:6080
10319 0 0 MASQUERADE tcp -- * * 172.17.0.21 172.17.0.21 tcp dpt:6080
10420 0 0 MASQUERADE tcp -- * * 172.17.0.4 172.17.0.4 tcp dpt:6080
10521 0 0 MASQUERADE tcp -- * * 172.17.0.2 172.17.0.2 tcp dpt:80
106
107Chain OUTPUT (policy ACCEPT 432K packets, 27M bytes)
108num pkts bytes target prot opt in out source destination
1091 15 972 DOCKER all -- * * 0.0.0.0/0 !127.0.0.0/8 ADDRTYPE match dst-type LOCAL
110
111Chain DOCKER-INGRESS (0 references)
112num pkts bytes target prot opt in out source destination
113
114Chain DOCKER (2 references)
115num pkts bytes target prot opt in out source destination
1161 57 3468 RETURN all -- docker0 * 0.0.0.0/0 0.0.0.0/0
1172 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6082 to:172.17.0.3:6080
1183 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6091 to:172.17.0.5:6080
1194 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6090 to:172.17.0.7:6080
1205 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6098 to:172.17.0.8:6080
1216 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6088 to:172.17.0.9:6080
1227 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6089 to:172.17.0.10:6080
1238 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6096 to:172.17.0.11:6080
1249 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6084 to:172.17.0.13:6080
12510 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6086 to:172.17.0.14:6080
12611 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6095 to:172.17.0.15:6080
12712 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6097 to:172.17.0.6:6080
12813 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6085 to:172.17.0.16:6080
12914 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6087 to:172.17.0.17:6080
13015 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6094 to:172.17.0.18:6080
13116 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6093 to:172.17.0.20:6080
13217 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6092 to:172.17.0.19:6080
13318 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6080 to:172.17.0.12:6080
13419 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6081 to:172.17.0.21:6080
13520 0 0 DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:6083 to:172.17.0.4:6080
13621 10297 618K DNAT tcp -- !docker0 * 0.0.0.0/0 0.0.0.0/0 tcp dpt:3003 to:172.17.0.2:80
137
138
139root@codesearch8:~# ip netns list
140root@codesearch8:~#
141

Thu, Apr 4, 11:20 PM · Patch-For-Review, VPS-project-Codesearch
Krinkle updated the task description for T361899: Let codesearch-frontend reques to local Hound instances directly.
Thu, Apr 4, 11:20 PM · Patch-For-Review, VPS-project-Codesearch
Krinkle created P59607 T361899 codesearch8 firewall.
Thu, Apr 4, 11:18 PM
Krinkle created T361899: Let codesearch-frontend reques to local Hound instances directly.
Thu, Apr 4, 11:17 PM · Patch-For-Review, VPS-project-Codesearch
Seb35 awarded T361379: generateSitemap: Uninitialized string offset 0 a Like token.
Thu, Apr 4, 3:15 PM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-Platform-Team, MW-1.41-release, MediaWiki-Maintenance-system
Krinkle moved T361070: Performance review of CommunityConfiguration from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Thu, Apr 4, 2:06 AM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, CommunityConfiguration, Growth-Team, MediaWiki-Platform-Team
Krinkle updated the task description for T361070: Performance review of CommunityConfiguration.
Thu, Apr 4, 12:05 AM · MW-1.43-notes (1.43.0-wmf.2; 2024-04-23), Patch-For-Review, CommunityConfiguration, Growth-Team, MediaWiki-Platform-Team

Wed, Apr 3

Krinkle added a comment to T361412: Write PHPUnit tests for excimer-ui-client (WikimediaDebug).

@lmata Code review for the main patch.

Wed, Apr 3, 6:55 PM · SRE Observability (FY2023/2024-Q4), Patch-For-Review, MediaWiki-Platform-Team (Radar), WikimediaDebug
Krinkle committed rODIT11ab9d8cb33c: php82-sssd: add php-yaml.
php82-sssd: add php-yaml
Wed, Apr 3, 11:10 AM
Krinkle added a comment to T361577: Error: Typed property MediaWiki\Rest\RequestBase::$parsedBody must not be accessed before initialization.

Looks like new breakage from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1012690 that exposed the unitialized field ... and seems like Ammarpad's fix should do it. Added @BPirkle and @daniel as reviewers.

Huh, I wonder why this issue didn't show up in CI.

Wed, Apr 3, 1:56 AM · MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), Patch-For-Review, MW-Interfaces-Team, MediaWiki-REST-API, Wikimedia-production-error

Tue, Apr 2

Krinkle added a project to T181545: "Other review tools" is not working when JS is disabled on desktop: MediaWiki-Recent-changes.
Tue, Apr 2, 4:04 PM · MediaWiki-Recent-changes, Growth-Team-Filtering, Growth-Team, Edit-Review-Improvements-Integrated-Filters
Krinkle added a comment to T163492: With $wgReadOnly set and when $wgSessionCacheType = CACHE_DB, ApiQueryTokens will return invalid tokens.

@Tgr BagOStuff will indeed not throw an exception when writes fail, but it does support error detection and error handling. E.g. SqlBagOStuff->set() willl return false if the database write failed for any reason, including if it was read-only.

Tue, Apr 2, 3:56 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff, MediaWiki-Core-AuthManager
Krinkle added a project to T340105: PHP-based alternative to wikimedia/service-template-node: MediaWiki-Engineering.

This is relevant to an issue we discussed at the offsite last month around offering teams the option to migrate legacy Node.js services to e.g. the new MediaWiki REST API (extension) and/or a standalone PHP service (if indeed it qualifies to be its own service, under latest SRE guideance at https://www.mediawiki.org/wiki/Wikimedia_services_policy and T239856).

Tue, Apr 2, 3:07 PM · MediaWiki-Engineering, service-template-node, API Guidelines, Kubernetes

Mon, Apr 1

Krinkle created T361457: Install php-yaml in Toolforge images.
Mon, Apr 1, 4:25 AM · Patch-For-Review, Toolforge (Software install/update)

Sat, Mar 30

Krinkle assigned T337161: Make PHPUnit dataProvider static in OAuth tests to Tgr.

Assigning to @Tgr per comment at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/910803.

Sat, Mar 30, 4:15 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-extensions-OAuth
Krinkle added a project to T337161: Make PHPUnit dataProvider static in OAuth tests: MediaWiki-Platform-Team.
Sat, Mar 30, 4:13 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MediaWiki-Platform-Team, Patch-For-Review, MediaWiki-extensions-OAuth
Krinkle added a project to T361419: DatabaseTest::testCriticalSectionErrorSelect fails locally, yet passes with php-xdebug enabled: MediaWiki-libs-RequestTimeout.

Given that php-xdebug, by definition, cannot be used to debug this problem, time to sprint some print, wfBacktrace, and var_dump:

Sat, Mar 30, 3:49 AM · MediaWiki-libs-RequestTimeout, MW-Interfaces-Team, MediaWiki-libs-Rdbms
Krinkle created T361419: DatabaseTest::testCriticalSectionErrorSelect fails locally, yet passes with php-xdebug enabled.
Sat, Mar 30, 3:45 AM · MediaWiki-libs-RequestTimeout, MW-Interfaces-Team, MediaWiki-libs-Rdbms
Krinkle added a comment to T328919: Upgrade to PHPUnit 10.

One feature I particularly like in PHPUnit 10, is the ability to pass multiple directories or files to phpunit. I've considered it a bug not to have this, in particular because the command is completely silent about the subsequent arguments, e.g. you can run phpunit tests/includes/ResourceLoader/* today and it would "succeed" with a bunch of meaningless dots, having actually only executed the first file that bash expanded the star to.

Sat, Mar 30, 2:24 AM · MediaWiki-Core-Tests
Krinkle added a comment to T349298: "wikipage.content" JS hook: $content should be consistent on live previews.

@Od1n Is there a functional problem here in terms of what a gadget is able to do or observe?

Sat, Mar 30, 2:03 AM · MediaWiki-Platform-Team (Radar), MediaWiki-User-Interface, JavaScript
Krinkle triaged T361379: generateSitemap: Uninitialized string offset 0 as High priority.
Sat, Mar 30, 1:38 AM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.25; 2024-04-02), MediaWiki-Platform-Team, MW-1.41-release, MediaWiki-Maintenance-system
Krinkle closed T116129: Give us some errors or something when the LESS parsing fails as Resolved.
Sat, Mar 30, 1:35 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, MediaWiki-ResourceLoader, MediaWiki-Platform-Team, Less.php
Krinkle added a comment to T116129: Give us some errors or something when the LESS parsing fails.

I applied these two mistakes locally in my MediaWiki checkout, to observe the behaviour as of today:

Sat, Mar 30, 1:35 AM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), Patch-For-Review, MediaWiki-ResourceLoader, MediaWiki-Platform-Team, Less.php
Krinkle moved T361035: [Regression] CSS import with variable name no longer works from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Sat, Mar 30, 1:14 AM · Patch-For-Review, MediaWiki-Platform-Team, Regression, Less.php
Krinkle triaged T361035: [Regression] CSS import with variable name no longer works as High priority.
Sat, Mar 30, 1:14 AM · Patch-For-Review, MediaWiki-Platform-Team, Regression, Less.php
Krinkle renamed T209394: Use sniff or phan rule to detect violations of Stable interface policy (@internal, @deprecated, @stable etc.) from Use sniff or phan rule to detect violations of Stable interface policy (@internal, @stable etc.) to Use sniff or phan rule to detect violations of Stable interface policy (@internal, @deprecated, @stable etc.).
Sat, Mar 30, 12:27 AM · phan, MediaWiki-Core-Tests
Krinkle awarded T209394: Use sniff or phan rule to detect violations of Stable interface policy (@internal, @deprecated, @stable etc.) a Orange Medal token.
Sat, Mar 30, 12:26 AM · phan, MediaWiki-Core-Tests
Krinkle awarded T135155: Create an adapter that implements SiteLookup on top of InterwikiLookup a Orange Medal token.
Sat, Mar 30, 12:19 AM · [DEPRECATED] wdwb-tech (Freezer 🥶), Patch-Needs-Improvement, User-Ladsgroup, Wikidata, MediaWiki-Site-system, MediaWiki-Interwiki
Krinkle added a comment to T361407: Add short-to-type aliases for <syntaxhighlight> and <syntaxhighlight inline>.

<pre> is indeed processed in wikitext similar to many Markdown implementations, with "nowiki"-like treatment applied.

Sat, Mar 30, 12:14 AM · Patch-For-Review, SyntaxHighlight