Page MenuHomePhabricator

Yaron_Koren (Yaron Koren)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 14 2014, 3:01 AM (493 w, 3 h)
Availability
Available
LDAP User
Yaron Koren
MediaWiki User
Unknown

Recent Activity

Mon, Apr 15

Yaron_Koren committed rEMDO760e10ddf4b1: Version 1.2.1.
Version 1.2.1
Mon, Apr 15, 7:36 PM
Yaron_Koren closed T362545: Inline editing of files no longer works in Gerrit as Invalid.

@Paladox - oh! How strange. I had tried clearing the browser cache several times before, but now when I tried it again, it did seem to solve the problem. Given that it works for everyone, it seems safe to close this. I guess I'll mark it as "Invalid". Thanks to everyone for your help.

Mon, Apr 15, 3:57 PM · Gerrit
Yaron_Koren created T362545: Inline editing of files no longer works in Gerrit.
Mon, Apr 15, 3:44 PM · Gerrit

Wed, Apr 10

Yaron_Koren closed T292237: ReplaceText Doxygen failure as Resolved.

I guess that's good enough evidence for me... I'm closing this as "Resolved". @Krinkle and everyone else - thank you for looking into this! Of course, if this is still an issue, feel free to re-open it.

Wed, Apr 10, 5:02 PM · Doxygen, MediaWiki-extensions-ReplaceText

Mon, Apr 8

Yaron_Koren added a comment to T292237: ReplaceText Doxygen failure.

@Reedy (or anyone else) - can this be closed?

Mon, Apr 8, 3:12 PM · Doxygen, MediaWiki-extensions-ReplaceText

Thu, Apr 4

Yaron_Koren closed T353094: Cargo adds unnecessary JS config vars to all pages as Resolved.
Thu, Apr 4, 4:03 PM · MediaWiki-extensions-Cargo

Wed, Apr 3

Yaron_Koren created T361743: Add InlineComments extension to translatewiki.net.
Wed, Apr 3, 8:00 PM · Patch-For-Review, translatewiki.net
Yaron_Koren closed T355947: Change "Mark resolved" wording in InlineComments to something more accurate as Resolved.
Wed, Apr 3, 7:48 PM · Patch-For-Review, MediaWiki-extensions-InlineComments
Yaron_Koren closed T113209: "Modifying Page failed" error when saving, using Semantic Forms & Translate as Resolved.

I'm pretty sure this is no longer a bug, 9 years later, though feel free to re-open if anyone is still seeing this problem.

Wed, Apr 3, 2:13 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T344057: Values dependent on does not reset linked input value on change as Declined.

I'm closing this, based on the above reasoning - I don't think this change is a good idea.

Wed, Apr 3, 2:07 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms
Yaron_Koren moved T148883: Gracefully handle broken ExternalData services from Backlog to Not ED on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:07 PM · Sustainability (Incident Followup), MediaWiki-extensions-ExternalData, Maps (Kartographer)
Yaron_Koren moved T259743: Add `ext-mongodb` to the testing environment from Backlog to Not ED on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:06 PM · MediaWiki-extensions-ExternalData, Continuous-Integration-Config
Yaron_Koren moved T282499: Consider whether Parsoid will support forced linear parsing. from Backlog to Not ED on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:06 PM · MediaWiki-extensions-ExternalData, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), MediaWiki-extensions-Variables, Parsoid, MediaWiki-Parser
Yaron_Koren moved T324173: Drop use of utf8_encode and utf8_decode, deprecated in PHP 8.2 from Backlog to Not ED on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:05 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), BlueSpice, MediaWiki-extensions-DocBookExport, MediaWiki-extensions-ExternalData, MediaWiki-extensions-LDAPProvider, MediaWiki-extensions-Page_Forms, MediaWiki-extensions-WebDAV, PHP 8.2 support
Yaron_Koren moved T287937: Enable importing data from Microsoft Excel files in ExternalData from Backlog to Data sources on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:04 PM · MediaWiki-extensions-ExternalData
Yaron_Koren moved T293325: Enable use of ShellBox in {{#get_program_data:}} from Backlog to Data sources on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:03 PM · Shellbox, MediaWiki-extensions-ExternalData
Yaron_Koren moved T295953: Enable callable shell command generator for {{#get_program_data:}} from Backlog to Data sources on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:03 PM · MediaWiki-extensions-ExternalData
Yaron_Koren moved T326463: Add SMW and Cargo queries as types of data sources to External Data from Backlog to Data sources on the MediaWiki-extensions-ExternalData board.
Wed, Apr 3, 1:03 PM · MediaWiki-extensions-ExternalData

Tue, Apr 2

Yaron_Koren committed rEFLD5e56851c57e8: Upgrade Mermaid to latest version, 10.9.0.
Upgrade Mermaid to latest version, 10.9.0
Tue, Apr 2, 2:16 PM
Yaron_Koren closed T358360: Mermaid upgrade needed as Resolved.

It looks like this works, post-upgrade!

Tue, Apr 2, 1:34 PM · Patch-For-Review, MediaWiki-extensions-FlexDiagrams

Mon, Apr 1

Yaron_Koren committed rEWANa874080273b2: Remove unnecessary comment in ReviewHandler.php.
Remove unnecessary comment in ReviewHandler.php
Mon, Apr 1, 8:04 PM
Yaron_Koren committed rEWAN6925e11d6ede: Add missing field declarations to various classes.
Add missing field declarations to various classes
Mon, Apr 1, 7:15 PM
Yaron_Koren closed T361458: "PHP Deprecated: Automatic conversion of false to array is deprecated" on Special:RunQuery as Resolved.

That's great to hear! Thanks for reporting the problem also. I'm closing this now.

Mon, Apr 1, 4:26 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms, PHP 8.1 support
Yaron_Koren added a comment to T361458: "PHP Deprecated: Automatic conversion of false to array is deprecated" on Special:RunQuery.

@Nikerabbit - could you see if this patch fixes the problem for you?

Mon, Apr 1, 3:20 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms, PHP 8.1 support

Mar 26 2024

Yaron_Koren added a comment to T358890: Deleting the last inline comments should restore the page to default display.

Well, that fits into T355948.

Mar 26 2024, 11:07 PM · Patch-For-Review, MediaWiki-extensions-InlineComments
Yaron_Koren added a comment to T358890: Deleting the last inline comments should restore the page to default display.

You could create a separate task for this patch, or just have no task for the patch - not every patch needs an associated task.

Mar 26 2024, 2:29 AM · Patch-For-Review, MediaWiki-extensions-InlineComments
Yaron_Koren added a comment to T358890: Deleting the last inline comments should restore the page to default display.

@Rockingpenny4 - this seems like a useful change, but is it related to the original bug/task?

Mar 26 2024, 1:29 AM · Patch-For-Review, MediaWiki-extensions-InlineComments
Yaron_Koren added a comment to T355942: Add user mentions to InlineComments.

I think using a 3rd party autocompletion library is the better option, if it's possible - using VisualEditor would be somewhat of a hack.

Mar 26 2024, 1:18 AM · MediaWiki-extensions-InlineComments

Mar 22 2024

Yaron_Koren closed T360777: Possibility to set a default value to the page name as Invalid.

Yes, you can use the "default value=" parameter - see here:

Mar 22 2024, 9:02 PM · MediaWiki-extensions-Page_Forms

Mar 21 2024

Yaron_Koren committed rEMDO22de0f14b235: Remove use of Action::$page, removed in MW 1.40.
Remove use of Action::$page, removed in MW 1.40
Mar 21 2024, 2:45 PM

Mar 19 2024

Yaron_Koren added a comment to T360397: Null not handled properly.

That's great to hear!

Mar 19 2024, 5:31 PM · MediaWiki-extensions-ExternalData
Yaron_Koren added a comment to T360397: Null not handled properly.

Could it be that that's just a file permissions problem? I don't see how any of the recent changes to External Data would cause that error. The fact that the Data Transfer extension gives the same error also seems very suspicious.

Mar 19 2024, 5:14 PM · MediaWiki-extensions-ExternalData
Yaron_Koren closed T360355: parser output not trimmed anymore for show on select mapping templates/$option_div_pair as Resolved.

That's great to hear! Closing this now.

Mar 19 2024, 5:00 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T301364: Toolbar should hide when VE area not in viewport.

@Nischayn22 - could it be that the fix for T341904 fixed this as well?

Mar 19 2024, 4:47 PM · MediaWiki-extensions-VEForAll
Yaron_Koren closed T341904: Toolbar at the top wrongly positioned as Resolved.
Mar 19 2024, 4:46 PM · MediaWiki-extensions-VEForAll
Yaron_Koren added a comment to T341904: Toolbar at the top wrongly positioned.

That's great to hear! @Lkvrsfld - thanks again. I assume this can be closed now.

Mar 19 2024, 4:45 PM · MediaWiki-extensions-VEForAll
Yaron_Koren committed rEVFAf43d0bd88d06: Fix "toolbar on top" positioning - fix by Lkvrsfld.
Fix "toolbar on top" positioning - fix by Lkvrsfld
Mar 19 2024, 3:15 PM

Mar 18 2024

Yaron_Koren closed T355943: Add date and time to newly-created comments in InlineComments as Resolved.

I think this can be closed. @Rockingpenny4 - thank you for your help with this!

Mar 18 2024, 9:37 PM · Patch-For-Review, MediaWiki-extensions-InlineComments
Yaron_Koren added a comment to T360355: parser output not trimmed anymore for show on select mapping templates/$option_div_pair .

@Schtom - I implemented the fix in a slightly different way; please let me know if this fix works for you.

Mar 18 2024, 9:30 PM · MediaWiki-extensions-Page_Forms

Mar 15 2024

Yaron_Koren closed T360125: Posibility to create 1 form that create 2 different page as Resolved.

I'm closing this, assuming there's nothing more to discuss about it...

Mar 15 2024, 2:02 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T360155: Cargo does not rename hierarchy table names when a replacement table is switched in as Resolved.

@TK-999 - thank you for finding, and diagnosing, the problem! It was a pretty big bug. I assume this can be closed now.

Mar 15 2024, 2:00 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T356436: Improve InlineComments extension.

@Rockingpenny4 - sorry for the delay. Your proposal looks good! Impressive previous experience. You can of course add a few more completed patches to the "Contributions to Wikimedia" section now.

Mar 15 2024, 1:58 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren closed T294002: Replace deprecated Content::getParserOutput calls to new one in DocBookExport extension. as Resolved.

@GladwinJ - thank you!

Mar 15 2024, 1:34 PM · MediaWiki-extensions-DocBookExport, Platform Team Workboards (MW Expedition)
Yaron_Koren closed T283702: Replace Content::getNativeData() calls with TextContent::getText() in DocBookExport as Resolved.

@GladwinJ - thank you!

Mar 15 2024, 1:34 PM · MediaWiki-extensions-DocBookExport
Yaron_Koren closed T283702: Replace Content::getNativeData() calls with TextContent::getText() in DocBookExport, a subtask of T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. , as Resolved.
Mar 15 2024, 1:34 PM · Patch-Needs-Improvement, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Platform Engineering (Icebox), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Technical-Debt, User-Daniel, MediaWiki-ContentHandler
Yaron_Koren moved T356436: Improve InlineComments extension from Backlog to Google Summer of Code 2024 on the MediaWiki-extensions-InlineComments board.
Mar 15 2024, 1:04 AM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren moved T359760: GSOC(2024) Proposal for Improve InlineComments extension from Backlog to Google Summer of Code 2024 on the MediaWiki-extensions-InlineComments board.
Mar 15 2024, 1:03 AM · Google-Summer-of-Code (2024), MediaWiki-extensions-InlineComments
Yaron_Koren moved T359771: GSoC 2024 proposal - Improve InlineComments extension from Backlog to Google Summer of Code 2024 on the MediaWiki-extensions-InlineComments board.
Mar 15 2024, 1:03 AM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren moved T359976: {GSOC 2024 Project Proposal}-Improve InlineComments Extension from Backlog to Google Summer of Code 2024 on the MediaWiki-extensions-InlineComments board.
Mar 15 2024, 1:03 AM · Google-Summer-of-Code (2024), MediaWiki-extensions-InlineComments
Yaron_Koren added a watcher for MediaWiki-extensions-InlineComments: Yaron_Koren.
Mar 15 2024, 1:03 AM

Mar 14 2024

Yaron_Koren added a comment to T360125: Posibility to create 1 form that create 2 different page.

No, there's no way to do that.

Mar 14 2024, 7:09 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T360090: Error: Typed property Parser::$mOutputType must not be accessed before initialization as Resolved.

Great!

Mar 14 2024, 6:21 PM · MediaWiki-Parser, MediaWiki-extensions-Page_Forms
Yaron_Koren closed T356000: PageForms: performance issue for values from namespace field as Resolved.

Closing again - though feel free to re-open it.

Mar 14 2024, 2:56 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T360090: Error: Typed property Parser::$mOutputType must not be accessed before initialization.

@Nikerabbit - could you let me know if the additional line in this patch fixes the problem?

Mar 14 2024, 1:38 PM · MediaWiki-Parser, MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T355950: Add "inlinecomments-view" permission.

I just read through your proposal. It looks good!

Mar 14 2024, 1:05 PM · MediaWiki-extensions-InlineComments

Mar 13 2024

Yaron_Koren added a comment to T282499: Consider whether Parsoid will support forced linear parsing..

Right, yes - Cargo has something similar too, where you can query values in the order in which they appear on the page, but it's already unreliable, even with linear parsing.

Mar 13 2024, 10:57 PM · MediaWiki-extensions-ExternalData, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), MediaWiki-extensions-Variables, Parsoid, MediaWiki-Parser
Yaron_Koren added a comment to T282499: Consider whether Parsoid will support forced linear parsing..

There isn't really the concept of an order of operations for either extension, as far as I can think.

Mar 13 2024, 9:09 PM · MediaWiki-extensions-ExternalData, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), MediaWiki-extensions-Variables, Parsoid, MediaWiki-Parser
Yaron_Koren added a comment to T282499: Consider whether Parsoid will support forced linear parsing..

Just to chime in, I don't believe Cargo or Semantic MediaWiki will have any issues with the non-linear aspect of Parsoid. (SMW does have an issue with the "::" syntax, but that's a separate thing.)

Mar 13 2024, 8:33 PM · MediaWiki-extensions-ExternalData, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), MediaWiki-extensions-Variables, Parsoid, MediaWiki-Parser
Yaron_Koren closed T359635: Can't create field tag default with transcluding MediaWiki balise as Resolved.

Well... that's an okay solution. I still think it's possible, somehow, to create a <noinclude> substitute that works directly in the template. But if you got this working, then I guess there is no longer a Page Forms issue.

Mar 13 2024, 2:53 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T355950: Add "inlinecomments-view" permission as Resolved.

@Solaris22 - thank you for your work on this!

Mar 13 2024, 1:39 PM · MediaWiki-extensions-InlineComments

Mar 12 2024

Yaron_Koren added a comment to T359748: Autocompletion on external URL not working if there are multiple results.

@Nikerabbit - please let me know if the new code works for you.

Mar 12 2024, 1:58 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T355943: Add date and time to newly-created comments in InlineComments.

@Rockingpenny4 - wow, this looks great! Yes, a patch would be great to see.

Mar 12 2024, 12:13 AM · Patch-For-Review, MediaWiki-extensions-InlineComments

Mar 11 2024

Yaron_Koren added a comment to T341904: Toolbar at the top wrongly positioned.

@Lkvrsfld - thanks for this fix, and please see the corresponding patch I created. Does this look correct - is it just this one line?

Mar 11 2024, 9:33 PM · MediaWiki-extensions-VEForAll
Yaron_Koren added a comment to T356436: Improve InlineComments extension.

Your proposal looks good, including your past experience and set of programming skills - I can't think of anything that needs to be added.

Mar 11 2024, 9:27 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren closed T359704: Pages with _rowID instead of _pageID shows error message when #cargo_query as Resolved.

@KloudZ - thanks for diagnosing this problem. I think the patch I checked in fixed the problem; feel free to re-open this if not.

Mar 11 2024, 9:03 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T356436: Improve InlineComments extension.

@Jatinder190124 - thank you for the proposal; we will carefully evaluate every proposal we receive, including yours.

Mar 11 2024, 6:05 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren closed T359749: The ReplaceText special page aliases for zh-hans needs to be changed as Resolved.

@XiaofeiTM233 - thank you for this patch.

Mar 11 2024, 5:57 PM · MediaWiki-extensions-ReplaceText

Mar 10 2024

Yaron_Koren added a comment to T355948: Make InlineComments sidebar creation more skin-neutral.

I hope it can be done with a single file, yes.

Mar 10 2024, 9:07 PM · MediaWiki-extensions-InlineComments
Yaron_Koren updated subscribers of T356436: Improve InlineComments extension.

Hi - one unfortunate aspect of the Google Summer of Code is that, most of the time, by the time you find out whether you have been accepted or not to a particular project, it's too late to apply for a different one. I have always tried to avoid that happening to applicants, so my plan was always to pick someone as soon as possible. Brian and I have now done that, and we have chosen @Jayanthvikashs as the student for this project. That means the other five of you who completed microtasks will have to find another project, if you are still interested in doing the Google Summer of Code this year. It is too bad, because many of you seemed to have both the technical skills and the enthusiasm to be able to do a good job on this project; but unfortunately we can only select one student. Hopefully your effort will not have been wasted, and you can point to the task(s) you did (or are currently doing) when applying for a different project, whether it's for the Wikimedia Foundation (ideally) or elsewhere. (Certainly your effort was not wasted in terms of your code contributions to MediaWiki extensions!) Sorry, and good luck.

Mar 10 2024, 2:49 AM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)

Mar 8 2024

Yaron_Koren added a comment to T359635: Can't create field tag default with transcluding MediaWiki balise.

Okay - it seems to me that the ideal situation would be that the category call goes into the template - but does not apply to the template itself, but does apply to any page that calls that template, but does not apply to any page that transcludes one of those pages. :)

Mar 8 2024, 6:00 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren closed T342955: RSS: Parse wikitext in description field as Resolved.

I think this is done now! @Jayanthvikashs - thank you for your help with this.

Mar 8 2024, 5:42 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T359635: Can't create field tag default with transcluding MediaWiki balise.

I assume by "balise", you mean "tag". But why not put this category tag into the template, rather than on each page?

Mar 8 2024, 3:47 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

Impressive! Thanks. (And I hope they get merged in!)

Mar 8 2024, 1:06 AM · MediaWiki-extensions-AdminLinks

Mar 7 2024

Yaron_Koren closed T359519: php 8.1 deprecated error for forms with page name formula and empty fields as Resolved.

I assume this is fixed now. Thanks for reporting it!

Mar 7 2024, 5:09 PM · MediaWiki-extensions-Page_Forms
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

Sure, it would be great to see your other contributions. Where can we see them?

Mar 7 2024, 1:00 PM · MediaWiki-extensions-AdminLinks

Mar 6 2024

Yaron_Koren added a comment to T356436: Improve InlineComments extension.

Hi everyone - there are six people who have completed, or are currently working on, a microtask for this project. We plan to select someone from among these six applicants. If you are not one of these six, it is unfortunately too late for you to take this project; please find a different GSoC project to apply for.

Mar 6 2024, 7:29 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren added a comment to T356436: Improve InlineComments extension.

@Rockingpenny4 - interesting ideas. I just looked again at how Google Docs does it. As far as I can tell, InlineComments does let you delete comments in basically the same way Google Docs does - in Google Docs, you can either mark a whole thread as resolved, or delete a whole thread - the effect of both is the same, and I don't know what the difference is. In InlineComments, you can click the "Mark resolved" button, which also does the same thing - maybe the name of that button should change, but the functionality is the same, I think.

Mar 6 2024, 5:17 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren added a comment to T353094: Cargo adds unnecessary JS config vars to all pages.

The key to this bug is "pages where they're not used".

Mar 6 2024, 4:36 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T353094: Cargo adds unnecessary JS config vars to all pages.

No.

Mar 6 2024, 2:40 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T353094: Cargo adds unnecessary JS config vars to all pages.

I discovered that three of these six global JS variables are no longer actually getting used anywhere, so I removed them in fdbbb72c559c. That still leaves three variables, though, that should be subject to this new logic.

Mar 6 2024, 2:35 AM · MediaWiki-extensions-Cargo

Mar 5 2024

Yaron_Koren renamed T358360: Mermaid upgrade needed from CSS styling error to Mermaid upgrade needed.
Mar 5 2024, 8:36 PM · Patch-For-Review, MediaWiki-extensions-FlexDiagrams
Yaron_Koren added a comment to T358360: Mermaid upgrade needed.

@Akaibu1 - I just looked into this; the problem seems to be the "&" in there, not the CSS stuff. I'm guessing that this was a bug in the Mermaid version used in Flex Diagrams (10.2.1) which has since been fixed.

Mar 5 2024, 8:36 PM · Patch-For-Review, MediaWiki-extensions-FlexDiagrams
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

Well, as far as tasks for GSoC applicants to show their coding skills, we trying to limit people to just one each, to make things fair. And that task you linked to is indeed bigger than a microtask. With that said, you (and anyone else) are of course free to work on whatever you want to, this being open source.

Mar 5 2024, 4:44 PM · MediaWiki-extensions-AdminLinks
Yaron_Koren added a comment to T331689: It would be cool if cargo had configuration to reduce risk of denial of service attacks.

@TK-999 - thank you for this patch! I didn't know about that pingLimiter() method. This looks like a great improvement!

Mar 5 2024, 4:03 PM · MediaWiki-extensions-Cargo
Yaron_Koren closed T327263: Add class to row's paragraph as Resolved.

Okay, this code is now merged in! @Rockingpenny4 - thank you for all your hard work on this patch!

Mar 5 2024, 4:00 PM · MediaWiki-extensions-AdminLinks

Mar 4 2024

Yaron_Koren added a comment to T327263: Add class to row's paragraph.

What specific errors are you seeing? I didn't see anything about using spaces instead of tabs.

Mar 4 2024, 11:36 PM · MediaWiki-extensions-AdminLinks
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

That sounds fine with me - let's go with "data-row-name", then.

Mar 4 2024, 8:43 PM · MediaWiki-extensions-AdminLinks
Yaron_Koren closed T358843: PHP 8.1 Deprecation errors for fields being null as Resolved.

Excellent! Thank you for this patch.

Mar 4 2024, 8:33 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

No, the value of the attribute is $this->name. Anyway, leaving aside what was said before, what do you think a good name would be for this attribute? Ideally it should be simple but also non-ambiguous.

Mar 4 2024, 8:31 PM · MediaWiki-extensions-AdminLinks
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

Right, we talked about "data-row-name", but now it's just "data-row". It's not a big change, and it's not necessarily bad - I was just wondering why you made the change.

Mar 4 2024, 8:26 PM · MediaWiki-extensions-AdminLinks
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

This generally looks good! But there's something wrong with the tabs and spaces, as you can see in the diff.

Mar 4 2024, 8:21 PM · MediaWiki-extensions-AdminLinks
Yaron_Koren added a comment to T358843: PHP 8.1 Deprecation errors for fields being null.

Great! The code looks very simple now. But I think there's a way to make CargoTemplateFormat.php even simpler! (Let me know if you want a hint.)

Mar 4 2024, 6:58 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T358843: PHP 8.1 Deprecation errors for fields being null.

@Jayanthvikashs - this looks great! And it will definitely work. But to make this a little more of a challenge: I think it would be slightly better if the code in CargoTemplateFormat.php and CargoStore.php did not modify the original array in each case. Could you change the code so that these arrays don't get modified? (For CargoTemplateFormat.php, this could have the nice effect of simplifying the code in general.)

Mar 4 2024, 6:41 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T355950: Add "inlinecomments-view" permission.

It looks better! I added my comments there. Also, please "abandon" the two other patches - the MediaWiki core patch, and 1008409.

Mar 4 2024, 4:39 PM · MediaWiki-extensions-InlineComments
Yaron_Koren added a comment to T327263: Add class to row's paragraph.

That sounds logical.

Mar 4 2024, 3:21 PM · MediaWiki-extensions-AdminLinks
Yaron_Koren closed T358629: Improper handling of Coord in "join on" queries as Invalid.

I'm marking this as invalid, based on what I currently know. If you think there's a Cargo bug there, feel free to re-open this.

Mar 4 2024, 3:20 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T358843: PHP 8.1 Deprecation errors for fields being null.

@Schtom - thank you for this work! These are some great improvements.

Mar 4 2024, 3:15 PM · MediaWiki-extensions-Cargo
Yaron_Koren added a comment to T356436: Improve InlineComments extension.

I just added T358843 as another microtask.

Mar 4 2024, 3:15 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren updated the task description for T356436: Improve InlineComments extension.
Mar 4 2024, 3:15 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)
Yaron_Koren added a comment to T356436: Improve InlineComments extension.

@Destiny - that sounds good. I think there are still two available microtasks: T353094 and T324173 (the latter had a patch submitted for it, but it wasn't quite correct). Feel free to take one of them. (If we run out of microtasks, I can add a few more.)

Mar 4 2024, 2:56 PM · MediaWiki-extensions-InlineComments, Google-Summer-of-Code (2024)