User Details
- User Since
- Jan 25 2021, 8:52 PM (169 w, 3 d)
- Roles
- Disabled
- LDAP User
- MewOphaswongse
- MediaWiki User
- MOphaswongse (WMF) [ Global Accounts ]
Jul 1 2022
Moving this back to in progress to track the config changes to enable the new API. The tasks to support the new API are in QA.
Jun 30 2022
For the thumbnail image showing up, this occurs only when the article has a thumbnail and only for tasks in the preloaded task queue mw.config.get( 'homepagemodules' )[ 'suggested-edits' ]['task-queue'] since thumbnailSource is removed by GrowthTasksApi.fetchTasks but not when fetching extra data.
Jun 28 2022
Add link | Add image |
This is caused by missing back button. This regressed from VE's change to use cancel command for ve.ui.MWBackTool, which is extended by MachineSuggestionsBack. GrowthExperiments maintains an allow list of commands that can be used for structured tasks, since cancel was not in the list of allowed commands, the back tool is deemed unavailable.
Jun 27 2022
Jun 24 2022
Filed T311312: Add an image: optimize ServiceImageRecommendationProvider::processApiResponseData since this is a separate change from supporting the new API.
- ServiceImageRecommendationProvider: we iterate over all 52 responses, which seems excessive
- ServiceImageRecommendationProvider: it seems to fail if a single response doesn't pass validation, which seems wrong? It should skip entries which don't pass validation but should return the set of good recommendations – or maybe just the first one?
Jun 23 2022
Jun 22 2022
Hi @Trizek-WMF, I'm planning to get the last set of changes in by the end of this week so that it can be in next week's train. Will let you know if anything changes.
Jun 17 2022
Jun 15 2022
Jun 14 2022
Declining as this is due to iOS's rubberband scrolling
Task type | Desktop | Mobile |
Add image | ||
Add link |
Jun 13 2022
Hi @KStoller-WMF — could you confirm the wikis where this change should be deployed to? I know the description mentions "our four pilot wikis and French" but let's spell this out since the list does change over time so I wanted to be sure.
Jun 10 2022
Jun 9 2022
On mwmaint1002:
Jun 8 2022
Hi @Sgs, the different messages are from different browsers so the fix should address all of them.
Jun 7 2022
Hi @nettrom_WMF, I wanted to confirm with you the additional field we will be sending for this. I was thinking of adding other_reason field to action_data so that the possible responses for rejection_reason field are uniform regardless of whether this free text field is enabled or not. Does that sound good to you?
Jun 6 2022
A couple of related issues:
- When additional tasks are being fetched, the next button is not disabled.
- When navigating to the next task while additional tasks are being fetched, "No more suggestions" is shown and doesn't go away even when there are additional tasks.
On mwmaint1002:
Jun 3 2022
This regressed from T308542: Suggested edits: Populate task queue from server-side. Previously the quality gate config is set when the first task is populated. When the logic was changed to be a task queue, the quality gate config was not set.
Jun 2 2022
With fix:
Jun 1 2022
This was fixed recently in 1.39.0-wmf.14; 2022-05-30.