For teams/users to track issues related to their browser tests.
What is needed is the next step after a developer has submitted patch: the browser testing piece.
Change #702665 abandoned by Zfilipin:
[mediawiki/skins/MinervaNeue@master] WIP Selenium: redirect
Reason:
Change #1020215 merged by jenkins-bot:
[mediawiki/core@master] selenium: Fix selenium-daily-beta(commons)-MediaWiki Jenkins jobs
Change #1020215 had a related patch set uploaded (by Zfilipin; author: Zfilipin):
[mediawiki/core@master] selenium: Fix selenium-daily-beta(commons)-MediaWiki Jenkins jobs
Apparently this was still open and assigned to me… let’s assume it’s fixed, feel free to reopen otherwise. (There’s been some movement in these browser tests anyways, e.g. they’ve been ported to async mode in T300807.)
Change #1019084 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] selenium: Skipping test that fails on betacluster
Change #1019084 had a related patch set uploaded (by Vaughn Walters; author: Vaughn Walters):
[mediawiki/extensions/CampaignEvents@master] selenium: Skipping test that fails on betacluster
I assume that there's nothing else to do here, but feel free to reopen if you disagree. It seems to me that adding a helper mechanism for soft dependencies is not needed right now, given that it's easy enough to implement already, as discussed above.
@Peter it's usually way simpler to update one major version at a time. But since we had trouble with v8, maybe giving v9 a try might be a good idea.
Change #721790 abandoned by Zfilipin:
[mediawiki/core@master] WIP selenium: Find flaky tests
Reason:
Let’s just close it – if anyone else sees it, please reopen.
Change #1013023 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] [Cypress] Unskip tests
Note that the entire file does need to be wrapped by the skip per-se. Something like following could work as well.
You could wrap that in a function, right?
QUnit.moduleSkipIf = function ( name, cond, body ) {
( !cond ? QUnit.module : QUnit.module.skip )( name, body );
};
QUnit.moduleSkipIf( 'cite.and.popups', mw.loader.getState( 'ext.popups.main' )..., ... )I'm not sure what the problem is at this point. Even without that, it seems clear enough for me. I don't feel like adding a helper in core would be helpful here, at least not until we see this pattern in several extensions.
Change #1013023 had a related patch set uploaded (by WMDE-Fisch; author: Mareike Heuer):
[mediawiki/extensions/Cite@master] [Cypress] Unskip tests
That makes sense, but my question is how to do this dynamically? The only workaround I've come up with is quite an eyesore: T359409#9623218 . Maybe it will look nicer if I assign the module contents to a variable and write the conditional something like this:
The "Start editing" piece doesn't exist any more since https://gerrit.wikimedia.org/r/1011114.
Change 1012679 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Skip tests causing trouble in the wild