Centralised notice extension (Homepage)
To make a confidential Fundraising task, visible only to members of acl*WMF-FR click here: https://phabricator.wikimedia.org/maniphest/task/create/?template=89899
Centralised notice extension (Homepage)
To make a confidential Fundraising task, visible only to members of acl*WMF-FR click here: https://phabricator.wikimedia.org/maniphest/task/create/?template=89899
@Jdlrobson You say banner errors would go to "their own channel" - where is that, how would we view them? Would it just be a page in logstash.wikimedia.org?
@AKanji-WMF I would be more comfortable with someone from Fundraising Tech reviewing the actual patch, since I don't tend to touch Centralnotice internals and know nothing about our error logging
@AKanji-WMF could somebody in fundraising tech please review the associated patch? I see you moved it into "Blocked or not fr-tech" but I am waiting for fundraising tech to guide on next steps.
In T361992#9727377, @Aklapper wrote:Thanks. (Text in videos cannot be searched for, things in videos cannot be read by a screenreader software.)
Thanks. (Text in videos cannot be searched for, things in videos cannot be read by a screenreader software.)
We don't use separate banners for mobile, but we use the CN banner that Seddon has created. Therefore I think that this issues has been resolved.
In T361992#9694688, @Aklapper wrote:@Mystrixo: Thanks for reporting this. For future reference, please use the bug report form (linked from the top of the task creation page) to create a bug report, and fill in the sections in the template, instead of deleting them.
Is there any error in your web browser's developer tools' "console" or "network" tab? Does this also happen in safe mode? See https://www.mediawiki.org/wiki/Help:Locating_broken_scripts
Removing VE (not uses) and TemplateData (only use is a parser test dependent on core functionality).
@bwang could you please create a task for next sprint or submit a patch that captures what has been agreed?
Okay sounds good. If we did want to run a banner in the night theme I guess the banner itself could remove the class?
We'd need to add the class to both Vector and Minerva skins. Alternatively perhaps Skin::getSiteNotice could contain this logic..?
In T361680#9684611, @Pcoombe wrote:Is it possible to log the banner name as well? That would be really helpful
@Pcoombe and I just met, we agreed the immediate solution would be for the Web team to apply the .notheme class and a default text color to the #siteNotice element. We chose to do this instead of modifying CentralNotice because #siteNotice can contain many types of content, i.e. the example in the description from korean wiki has its own custom #siteNoticeLocal element that needs to be handled.
Is it possible to log the banner name as well? That would be really helpful
@Pcoombe looks like a duplicate to me. Feel free to merge the two descriptions as you see fit. Patch above shows what this entails.
@Dwisehaupt recommends shutting off the buster in favour of the bullseye
In T360668#9656234, @Tacsipacsi wrote:Extensions using JavaScript to create message box should either switch to Codex
Is there any way to switch to Codex without using Vue? Extensions (and gadgets!) may have complex JavaScript, which would take quite some time to be completely rewritten in Codex/Vue, blocking phase 2 longer than necessary.
Extensions using JavaScript to create message box should either switch to Codex