Page MenuHomePhabricator

MediaWiki-File-managementComponent
ActivePublic

Members (10)

Watchers (5)

Details

Description

Management of multimedia files in the core MediaWiki software itself, including:

  • File backend.
  • File repositories.
  • Media handlers.
  • Thumbnail generation (but not on Wikimedia wikis, see Thumbor instead)
  • Misc display handling (File description page, Special:ListFiles).

Parent project: MediaWiki-General

For uploading, see MediaWiki-Uploading.

Recent Activity

Yesterday

tstarling added a comment to T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal.

If there is some aspect of this that is not addressed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1010344/ , feel free to reopen.

Fri, Apr 26, 12:55 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Commons, MediaWiki-File-management, Unstewarded-production-error, Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error
tstarling merged task T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Fri, Apr 26, 12:54 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Commons, MediaWiki-File-management, Unstewarded-production-error, Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error
tstarling merged T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Fri, Apr 26, 12:52 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
tstarling merged task T206252: Spike of HTTP errors from SwiftFileBackend::doStoreInternal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Fri, Apr 26, 12:51 AM · MediaWiki-File-management, Multimedia, Commons, Wikimedia-production-error
tstarling merged T206252: Spike of HTTP errors from SwiftFileBackend::doStoreInternal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Fri, Apr 26, 12:50 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
tstarling closed T358830: Uploads fail due to 401 error from swift on wednesdays as Resolved.
Fri, Apr 26, 12:48 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage

Wed, Apr 24

Maintenance_bot added a project to T50519: Add basic WebP upload support with JPEG/PNG thumbnails: Commons.
Wed, Apr 24, 4:30 PM · Commons, WMF-deploy-2015-06-30_(1.26wmf12), MW-1.26-release, Multimedia, Patch-For-Review, MediaWiki-File-management
SacredSum added a comment to T308386: WebP uploads always use "im" scaler (/usr/bin/convert), even when $wgUseImageMagick and $wgUseImageResize are false.

I forgot that I had opened this task and almost went to open another one today. Anyway, a little more information: the problem still exists in 1.39.7. In addition to ignoring $wgUseImageMagick, the hardcoded getScalerType for webp also ignores $wgUseImageResize.

Wed, Apr 24, 3:42 PM · MediaWiki-File-management
SacredSum renamed T308386: WebP uploads always use "im" scaler (/usr/bin/convert), even when $wgUseImageMagick and $wgUseImageResize are false from WebP uploads use "im" scaler (/usr/bin/convert) even when $wgUseImageMagick is false to WebP uploads always use "im" scaler (/usr/bin/convert), even when $wgUseImageMagick and $wgUseImageResize are false.
Wed, Apr 24, 3:26 PM · MediaWiki-File-management

Tue, Apr 23

larissagaulia added a project to T214319: In File and FileRepo, replace usage of Title with usage of LinkTarget and PageIdentity : MediaWiki-core-Hackathon-2024.
Tue, Apr 23, 1:49 PM · MediaWiki-core-Hackathon-2024, Patch-Needs-Improvement, Platform Team Workboards (MW Expedition), MediaWiki-File-management, Commons

Mon, Apr 22

Maintenance_bot added a project to T263301: Old image unexpectedly overwritten by a revision several years later (after Internal server error): Commons.
Mon, Apr 22, 9:30 PM · Commons, MediaWiki-File-management, Unstewarded-production-error, Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, Wikimedia-production-error, MediaWiki-Uploading
Krinkle added a project to T263301: Old image unexpectedly overwritten by a revision several years later (after Internal server error): MediaWiki-File-management.
Mon, Apr 22, 9:01 PM · Commons, MediaWiki-File-management, Unstewarded-production-error, Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, Wikimedia-production-error, MediaWiki-Uploading
Krinkle added a project to T198177: Due to PHP fatal, a new version upload overwrote a file (the original is gone): MediaWiki-File-management.
Mon, Apr 22, 9:01 PM · MediaWiki-File-management, Multimedia, Wikimedia-production-error, SRE-swift-storage, Commons

Fri, Apr 19

Bawolff closed T360032: Cannot upload webm of 3.6G: "The server did not respond within the expected time" as Resolved.

my understanding is that this worked after retrying.

Fri, Apr 19, 4:35 PM · MediaWiki-File-management, UploadWizard, Commons
Clement_Goubert closed T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes as Resolved.

Marking this resolved as you just confirmed a big file upload going through correctly. Thanks for your help in debugging this!

Fri, Apr 19, 4:25 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Bawolff added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Seems like this is fixed! We just had File:OBR_Hafignnover_6-2024.webm (4.88 GB) successfully uploaded (req-id: c1a5aab7-6e6b-4ef5-b20d-f9ddb095577f ). The job took 5 minutes 20 seconds to complete, so went beyond the previous 202 second limit.

Fri, Apr 19, 4:22 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management

Thu, Apr 18

brennen moved T360596: Figure out a plan to move forward with regarding Redis License changes from Inbox to Infrastructure on the GitLab board.
Thu, Apr 18, 6:27 PM · GitLab (Infrastructure), Patch-For-Review, User-aborrero, serviceops, MediaWiki-Platform-Team (Radar), collaboration-services, Release-Engineering-Team (Radar), Quarry, Toolforge, Software-Licensing, Infrastructure-Foundations, netbox, Platform Team Initiatives (API Gateway), ChangeProp, MediaWiki-File-management, SRE
Bawolff added a comment to T360032: Cannot upload webm of 3.6G: "The server did not respond within the expected time".

Can you try uploading again. The issue might be fixed now

Thu, Apr 18, 3:17 PM · MediaWiki-File-management, UploadWizard, Commons
Clement_Goubert added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

[...]
So it seems like two separate issues.

I guess sometimes the job runner pod gets terminated in the middle of a job. That would be fine if something like https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1008403 got merged)

Thu, Apr 18, 11:58 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Clement_Goubert added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

request_terminate_timeout for mw-jobrunners should now be set to 86400, as it was on bare metal.

Thu, Apr 18, 11:33 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1021427 merged by jenkins-bot:

[operations/deployment-charts@master] mw-debug: fix php.timeout

https://gerrit.wikimedia.org/r/1021427

Thu, Apr 18, 11:31 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Stashbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Mentioned in SAL (#wikimedia-operations) [2024-04-18T11:29:19Z] <cgoubert@deploy1002> Finished scap: Redeploy mw-on-k8s with full rebuild - Fix setting php.timeout - T358308 (duration: 37m 04s)

Thu, Apr 18, 11:29 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1021427 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/deployment-charts@master] mw-debug: fix php.timeout

https://gerrit.wikimedia.org/r/1021427

Thu, Apr 18, 11:02 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Stashbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Mentioned in SAL (#wikimedia-operations) [2024-04-18T10:52:15Z] <cgoubert@deploy1002> Started scap: Redeploy mw-on-k8s with full rebuild - Fix setting php.timeout - T358308

Thu, Apr 18, 10:52 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1021418 merged by jenkins-bot:

[operations/deployment-charts@master] mediawiki: Fix php.timeout

https://gerrit.wikimedia.org/r/1021418

Thu, Apr 18, 10:50 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Stashbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Mentioned in SAL (#wikimedia-operations) [2024-04-18T10:45:15Z] <claime> Rebuild php7.4-fpm production images - T358308

Thu, Apr 18, 10:45 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1021415 merged by Clément Goubert:

[operations/docker-images/production-images@master] php7.4-fpm: Actually use FPM__request_terminate_timeout

https://gerrit.wikimedia.org/r/1021415

Thu, Apr 18, 10:43 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1021418 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/deployment-charts@master] mediawiki: Fix php.timeout

https://gerrit.wikimedia.org/r/1021418

Thu, Apr 18, 10:20 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1021415 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/docker-images/production-images@master] php7.4-fpm: Actually use FPM__request_terminate_timeout

https://gerrit.wikimedia.org/r/1021415

Thu, Apr 18, 10:05 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Clement_Goubert added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

I think I found it

Thu, Apr 18, 9:59 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Clement_Goubert added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

How can I get into a pod in job runners namespace(?) via shell.php? I want to try some stuff

Thu, Apr 18, 9:50 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management

Wed, Apr 17

Bawolff added a comment to T360032: Cannot upload webm of 3.6G: "The server did not respond within the expected time".

Yes, this is due to T358308. Until that is fixed, you can upload large (>3GB) files via https://commons.wikimedia.org/wiki/Help:Server_side_upload

Wed, Apr 17, 11:56 PM · MediaWiki-File-management, UploadWizard, Commons
Bawolff added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Ok, i did some more digging in logstash.

Wed, Apr 17, 11:35 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Ladsgroup added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

How can I get into a pod in job runners namespace(?) via shell.php? I want to try some stuff

Wed, Apr 17, 9:05 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
hnowlan added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Looking at recent logs, it does seem like some of the failures might be caused by things other than a timeout (There was one recently that failed after 17 seconds). However i still think the larger files are failing due to some sort of timeout as they tend to fail at around 202 second mark, which is pretty suspicious. Sample size is pretty low since users know large uploads don't work so they don't try and upload large files.

Wed, Apr 17, 3:06 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management

Tue, Apr 16

Clement_Goubert added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

We can exclude a bad setting of the async trait for mw-jobrunner.
From a pod in production via shell.php

> use Wikimedia\MWConfig\ClusterConfig;
> ClusterConfig::getInstance()->isK8s()
= true
Tue, Apr 16, 3:54 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
hnowlan triaged T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes as High priority.
Tue, Apr 16, 3:05 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
TheDJ added a comment to T360032: Cannot upload webm of 3.6G: "The server did not respond within the expected time".

It means that a request was sent but then the server didn't respond within x seconds and the servers cut off the connection, failing the request.

Tue, Apr 16, 1:01 PM · MediaWiki-File-management, UploadWizard, Commons
TheDJ renamed T360032: Cannot upload webm of 3.6G: "The server did not respond within the expected time" from Cannot upload webm of 3.6G: "The server did not respond withing the expected time" to Cannot upload webm of 3.6G: "The server did not respond within the expected time".
Tue, Apr 16, 12:59 PM · MediaWiki-File-management, UploadWizard, Commons
vitaly-zdanevich added a comment to T360032: Cannot upload webm of 3.6G: "The server did not respond within the expected time".

Still cannot upload, I think this is a serious problem.

Tue, Apr 16, 12:22 PM · MediaWiki-File-management, UploadWizard, Commons
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1019823 merged by jenkins-bot:

[operations/deployment-charts@master] mw-jobrunner: set more php-specific settings to match metal instances

https://gerrit.wikimedia.org/r/1019823

Tue, Apr 16, 9:42 AM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management

Mon, Apr 15

Bugreporter added a comment to T121797: Implement perceptual/visual image hashing/fingerprinting in MediaWiki for detection of non-exact duplicate files.

Note there are several kinds of perceptual hashes and before we do any actual development we need to first compare the effectiveness and performance of different kinds of hashes.

Mon, Apr 15, 6:37 PM · Multimedia, Commons, MediaWiki-File-management
Mitar added a comment to T121797: Implement perceptual/visual image hashing/fingerprinting in MediaWiki for detection of non-exact duplicate files.

Not sure if we would be able to do that kind of comparison in a SQL query

Mon, Apr 15, 3:40 PM · Multimedia, Commons, MediaWiki-File-management
Cparle added a comment to T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).

This one too T362352

Mon, Apr 15, 3:37 PM · Patch-Needs-Improvement, Platform Engineering Roadmap, Commons, Multimedia, Schema-change, MediaWiki-File-management
Jdforrester-WMF updated subscribers of T28741: Migrate file tables to a modern layout (image/oldimage; file/file_revision; add primary keys).

Dropping a note here after a chat with @Cparle that we'd ideally want to add the proposed new column for perceptual hashes (T121797 / T251026) as part of this work, rather than migrating the tables twice.

Mon, Apr 15, 2:41 PM · Patch-Needs-Improvement, Platform Engineering Roadmap, Commons, Multimedia, Schema-change, MediaWiki-File-management
gerritbot added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Change #1019823 had a related patch set uploaded (by Hnowlan; author: Hnowlan):

[operations/deployment-charts@master] mw-jobrunner: set more php-specific settings to match metal instances

https://gerrit.wikimedia.org/r/1019823

Mon, Apr 15, 2:37 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management
Wargo renamed T352014: Sessions are disabled for load entry point (DeferredUpdates/ForeignAPIRepo) from Sessions are disabled for load entry point (DeferredUpdates/ForgeingAPIRepo) to Sessions are disabled for load entry point (DeferredUpdates/ForeignAPIRepo).
Mon, Apr 15, 12:11 PM · Commons, MediaWiki-General, affects-translatewiki.net, MediaWiki-File-management
Samwalton9-WMF merged task T302545: Double nuked some files on betacommons into T173825: Double-deletion on Commons.
Mon, Apr 15, 8:05 AM · Commons, MediaWiki-File-management, MediaWiki-extensions-Nuke, Beta-Cluster-reproducible

Sat, Apr 13

Bawolff added a comment to T358308: AssembleUploadChunksJob & PublishStashedFile jobs seem to be timing out at about 3 minutes, but should be ~20 minutes.

Looking at recent logs, it does seem like some of the failures might be caused by things other than a timeout (There was one recently that failed after 17 seconds). However i still think the larger files are failing due to some sort of timeout as they tend to fail at around 202 second mark, which is pretty suspicious. Sample size is pretty low since users know large uploads don't work so they don't try and upload large files.

Sat, Apr 13, 9:43 PM · Patch-For-Review, WMF-JobQueue, MediaWiki-File-management

Fri, Apr 12

Aklapper edited projects for T255618: thumb.php should convert width param to integer if does not end with "px", added: Patch-Needs-Improvement; removed Patch-For-Review.
Fri, Apr 12, 11:13 AM · Patch-Needs-Improvement, Commons, MediaWiki-File-management