Page MenuHomePhabricator

Performance IssueTag
ActivePublic

Members (4)

Watchers (3)

Details

Description

Generic tag for current issues that are causing slow server responses or slow/costly client-side payloads.

This is a form of Technical-Debt (use that workboard).

(For the workboard of the Performance Team, see Performance-Team.)

Recent Activity

Yesterday

stjn added a comment to T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users.

Another option for ruWP might be to turn on the ‘basic’ experience by default since we don't seem to show the ‘advanced’ version to IP users and I would argue ‘advanced’ option is pretty, for the lack of the technical term, shit for everyone else as well. That whole interface really needs a redesign, but in the case of Russian Wikipedia, I think switching it off might be a proper solution as well.

Mon, Apr 15, 7:30 PM · Performance Issue, MediaWiki-extensions-FlaggedRevs
Jdlrobson closed T361672: mediawiki.diff page should not load oojs-ui on page load - causing performance issues on FlaggedRevisions sites, a subtask of T350514: Projects with FlaggedRevisions installed load the entire Codex library and OOUI and 10kb more CSS, over 500kb of JavaScript and likely have higher first paint, as Resolved.
Mon, Apr 15, 7:18 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Design-System-Team, Codex, MediaWiki-extensions-FlaggedRevs, Performance Issue
Jdlrobson closed T361672: mediawiki.diff page should not load oojs-ui on page load - causing performance issues on FlaggedRevisions sites, a subtask of T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users, as Resolved.
Mon, Apr 15, 7:18 PM · Performance Issue, MediaWiki-extensions-FlaggedRevs
Samwalton9-WMF added a comment to T197940: Special:Nuke takes a long time to display.

I can't reproduce this - searching for users, whether they've created a large number of pages or not, returns results almost immediately.

Mon, Apr 15, 8:03 AM · Performance Issue, MediaWiki-extensions-Nuke
gerritbot added a project to T359010: OCR preferences are saved too often: Patch-For-Review.
Mon, Apr 15, 4:57 AM · Patch-For-Review, Performance Issue, Wikimedia OCR
gerritbot added a comment to T359010: OCR preferences are saved too often.

Change #1019436 had a related patch set uploaded (by Kolakachi; author: Kolakachi):

[mediawiki/extensions/Wikisource@master] Fixed OCR preferences are saved too often

https://gerrit.wikimedia.org/r/1019436

Mon, Apr 15, 4:57 AM · Patch-For-Review, Performance Issue, Wikimedia OCR
Samwilson added a comment to T359010: OCR preferences are saved too often.

This could be done by only saving the preferences when the config popup is closed.

Mon, Apr 15, 4:24 AM · Patch-For-Review, Performance Issue, Wikimedia OCR

Sat, Apr 13

Pppery closed T165935: "Lua error: not enough memory" on certain en.wiktionary pages as Resolved.
Sat, Apr 13, 4:41 PM · Performance Issue, Scribunto, All-and-every-Wiktionary
Theknightwho added a comment to T165935: "Lua error: not enough memory" on certain en.wiktionary pages.

It does seem to happen again, e.g. https://en.wiktionary.org/wiki/opistho- . It's not a particularly problematic page though, still the whole page is one big 'not enough memory' error

image.png (783×1 px, 110 KB)

Also see https://en.wiktionary.org/wiki/Wiktionary:Grease_pit/2024/April#Lua_error

Sat, Apr 13, 4:40 PM · Performance Issue, Scribunto, All-and-every-Wiktionary

Thu, Apr 11

ReleaseTaggerBot added a project to T341319: RecentChanges: Improve performance of Special:RecentChanges rendering : MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).
Thu, Apr 11, 10:00 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
gerritbot added a comment to T341319: RecentChanges: Improve performance of Special:RecentChanges rendering .

Change #938220 merged by jenkins-bot:

[mediawiki/core@master] Permissions: Avoid RestrictionStore lookup for unsupported actions

https://gerrit.wikimedia.org/r/938220

Thu, Apr 11, 9:26 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Krinkle edited projects for T341319: RecentChanges: Improve performance of Special:RecentChanges rendering , added: MediaWiki-Platform-Team (Radar); removed MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).
Thu, Apr 11, 9:12 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Krinkle updated subscribers of T341319: RecentChanges: Improve performance of Special:RecentChanges rendering .
Thu, Apr 11, 8:52 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Krinkle added a comment to T341319: RecentChanges: Improve performance of Special:RecentChanges rendering .

Change 938220 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/core@master] PermissionManager: Avoid restrictions lookup for unsupported actions

https://gerrit.wikimedia.org/r/938220

Thu, Apr 11, 8:50 PM · MW-1.43-notes (1.43.0-wmf.1; 2024-04-16), MediaWiki-Platform-Team (Radar), Wikimedia-Performance-recommendation, Anti-Harassment, Performance Issue, Patch-For-Review, Growth-Team, MediaWiki-Recent-changes
Jdforrester-WMF changed the status of T362271: Make wikilambda_fetch cacheable from Open to In Progress.
Thu, Apr 11, 4:49 PM · Patch-For-Review, Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
Jdforrester-WMF moved T362273: Let Action API classes to setCacheMode('public') even if the caller hasn't set 'uselang' to 'content' or whatever from To triage to No current plans / External on the Abstract Wikipedia team board.
Thu, Apr 11, 4:48 PM · Performance Issue, MediaWiki-Action-API, Abstract Wikipedia team
Jdforrester-WMF triaged T362271: Make wikilambda_fetch cacheable as Medium priority.
Thu, Apr 11, 4:48 PM · Patch-For-Review, Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
Lucas_Werkmeister_WMDE moved T76156: [Story] mw.wikibase: Use __index to lazy load entity contents from Incoming to Other Projects on the wmde-wikidata-tech board.
Thu, Apr 11, 12:22 PM · wmde-wikidata-tech, Wikibase-Lua, Story, Performance Issue, Wikidata, MediaWiki-extensions-WikibaseClient

Wed, Apr 10

CodeReviewBot added a comment to T362271: Make wikilambda_fetch cacheable.

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/157

Wed, Apr 10, 7:46 PM · Patch-For-Review, Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
Maintenance_bot removed a project from T85635: API initializes user preferences on every request: Patch-For-Review.
Wed, Apr 10, 6:30 PM · MediaWiki-Core-Team, Performance Issue, MediaWiki-Action-API
CodeReviewBot added a comment to T362271: Make wikilambda_fetch cacheable.

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/157

Wed, Apr 10, 6:08 PM · Patch-For-Review, Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
gerritbot added a project to T362271: Make wikilambda_fetch cacheable: Patch-For-Review.
Wed, Apr 10, 6:02 PM · Patch-For-Review, Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
gerritbot added a comment to T362271: Make wikilambda_fetch cacheable.

Change #1018757 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] APIs: Set most of our APIs to emit a cache header for 24 hours

https://gerrit.wikimedia.org/r/1018757

Wed, Apr 10, 6:01 PM · Patch-For-Review, Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
Jdforrester-WMF edited projects for T362271: Make wikilambda_fetch cacheable, added: Performance Issue; removed Performance-Device-Lab.
Wed, Apr 10, 5:48 PM · Patch-For-Review, Performance Issue, Abstract Wikipedia Fix-It tasks, WikiLambda, Abstract Wikipedia team
Jdforrester-WMF created T362273: Let Action API classes to setCacheMode('public') even if the caller hasn't set 'uselang' to 'content' or whatever.
Wed, Apr 10, 5:47 PM · Performance Issue, MediaWiki-Action-API, Abstract Wikipedia team
MusikAnimal moved T360163: Slow query in ApiQueryAllUsers with new block schema from Review/Feedback 💬 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
Wed, Apr 10, 4:35 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Performance Issue, Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks

Tue, Apr 9

NickK added a comment to T165935: "Lua error: not enough memory" on certain en.wiktionary pages.

It does seem to happen again, e.g. https://en.wiktionary.org/wiki/opistho- . It's not a particularly problematic page though, still the whole page is one big 'not enough memory' error

image.png (783×1 px, 110 KB)

Also see https://en.wiktionary.org/wiki/Wiktionary:Grease_pit/2024/April#Lua_error

Tue, Apr 9, 11:20 PM · Performance Issue, Scribunto, All-and-every-Wiktionary
gerritbot added a project to T356208: RequestTimeoutException trying to load Special:Transcode_statistics: Patch-For-Review.
Tue, Apr 9, 8:49 PM · Patch-For-Review, Unstewarded-production-error, TimedMediaHandler-Transcode, Wikimedia-production-error, Performance Issue
gerritbot added a comment to T356208: RequestTimeoutException trying to load Special:Transcode_statistics.

Change #1018347 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/TimedMediaHandler@master] WIP transcode table updates

https://gerrit.wikimedia.org/r/1018347

Tue, Apr 9, 8:49 PM · Patch-For-Review, Unstewarded-production-error, TimedMediaHandler-Transcode, Wikimedia-production-error, Performance Issue
Lydia_Pintscher removed a project from T179010: [C-DIS][SW] Re-enable Wikidata Recent Changes integration on Commons: Wikidata Dev Team.

Removing it from WD dev team board as this will need to be handled by WIT.

Tue, Apr 9, 2:30 PM · wmde-wikidata-tech, Wikidata Change Dispatching & Watchlists, Wikibase change dispatching scripts to jobs, Growth-Team-Filtering, Growth-Team, User-Marostegui, Wikidata-Sprint-2018-02-14, Wikidata-Sprint-2018-01-31, Wikidata, Wikidata-Former-Sprint-Board, Commons, Performance Issue, MediaWiki-Watchlist

Mon, Apr 8

bvibber added a subtask for T356208: RequestTimeoutException trying to load Special:Transcode_statistics: T362123: Retool transcode table with a status column.
Mon, Apr 8, 11:18 PM · Patch-For-Review, Unstewarded-production-error, TimedMediaHandler-Transcode, Wikimedia-production-error, Performance Issue

Fri, Apr 5

Aklapper added a comment to T360484: Submitting actions taking ~10 seconds to load after making changes.

Hi, see my previous comment which data is needed

Fri, Apr 5, 4:28 PM · Release-Engineering-Team (Priority Backlog 📥), User-brennen, Performance Issue, Phabricator
JWheeler-WMF added a comment to T360484: Submitting actions taking ~10 seconds to load after making changes.

I can verify I'm seeing a similar issue. When I change a task, there's a 400 error, initiator: core.pkg.js:233

Fri, Apr 5, 3:21 PM · Release-Engineering-Team (Priority Backlog 📥), User-brennen, Performance Issue, Phabricator
Jdlrobson triaged T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users as High priority.

Since this is impacting performance (and thus likely SEO) anonymous page views on certain wikis bumping to high priority. I can help out with this week of 9th if needed. We can switch to Codex markup without loading Vue.js by using the CSS only version (https://doc.wikimedia.org/codex/latest/components/demos/button.html#css-only-version)
I'm also attending the hackathon if we want to do this in person.

Fri, Apr 5, 3:12 AM · Performance Issue, MediaWiki-extensions-FlaggedRevs

Thu, Apr 4

Aklapper added a comment to T360484: Submitting actions taking ~10 seconds to load after making changes.

Getting the payload/response for that request in a private paste might be helpful for troubleshooting.

Thu, Apr 4, 6:34 PM · Release-Engineering-Team (Priority Backlog 📥), User-brennen, Performance Issue, Phabricator

Wed, Apr 3

thcipriani edited projects for T360484: Submitting actions taking ~10 seconds to load after making changes, added: Release-Engineering-Team (Priority Backlog 📥); removed Release-Engineering-Team.

@HNordeenWMF and @JWheeler-WMF I added you both to the acl*Batch-Editors as a grasping-at-straws-thought. Let me know if that changes anything for you all. Otherwise: still investigating. Recreating this has been tricky.

Wed, Apr 3, 5:48 PM · Release-Engineering-Team (Priority Backlog 📥), User-brennen, Performance Issue, Phabricator
Reedy updated the task description for T19993: Option on API lists to only have count of links/categories/whatever returned, rather than a full resultset.
Wed, Apr 3, 4:04 PM · Performance Issue, MediaWiki-Action-API
Pppery moved T268166: Special:PagesWithProp could be slow with high limit of pages to show from To triage to Maintenance reports on the MediaWiki-Special-pages board.
Wed, Apr 3, 2:26 PM · Performance Issue, MediaWiki-Special-pages
Reedy renamed T353891: https://lists.wikimedia.org is often slow to load from https://lists.wikimedia.org/postorius is sloooow to https://lists.wikimedia.org is often slow to load.
Wed, Apr 3, 1:32 PM · Upstream, SRE, Performance Issue, Wikimedia-Mailing-lists
fnegri added a comment to T353891: https://lists.wikimedia.org is often slow to load.

It's very slow for me as well, I hadn't opened it in a while but it was barely usable both yesterday and today.

Wed, Apr 3, 1:13 PM · Upstream, SRE, Performance Issue, Wikimedia-Mailing-lists
Ladsgroup added a comment to T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users.

{{ec}}

As far as I understand, it powers the review state box visible on the top right on https://ru.wikipedia.org/wiki/%D0%97%D0%B0%D0%B3%D0%BB%D0%B0%D0%B2%D0%BD%D0%B0%D1%8F_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D0%B0?safemode=1 – ruwiki uses Common.css to hide the box, but FlaggedRevs cannot know this in advance. I see two options:

  • Introduce a LocalSettings.php variable that allows hiding the box on the main page. I don’t know how complicated this would be, and it would only help on the main page (although the main page is probably the most performance-sensitive one, so it may still make sense).
  • Try to split the module to download only the absolutely necessary parts. This decreases the amount of JS downloaded by the module, but increases the number of RL modules.

Wonder if we can turn ext.flaggedRevs.basic to include js as well and move those parts there.

And in any case, migrate it from OOUI to Codex if possible, so that OOUI doesn’t have to be downloaded at all.

Wed, Apr 3, 12:25 PM · Performance Issue, MediaWiki-extensions-FlaggedRevs
Tacsipacsi added a comment to T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users.

As far as I understand, it powers the review state box visible on the top right on https://ru.wikipedia.org/wiki/%D0%97%D0%B0%D0%B3%D0%BB%D0%B0%D0%B2%D0%BD%D0%B0%D1%8F_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D0%B0?safemode=1 – ruwiki uses Common.css to hide the box, but FlaggedRevs cannot know this in advance. I see two options:

Wed, Apr 3, 12:22 PM · Performance Issue, MediaWiki-extensions-FlaggedRevs
Ladsgroup added a comment to T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users.

There is one thing that seems to be utilized. When I change the advanced to be loaded only for reviwers, loading a page locally logged out doesn't show the tooltip when you hover over the icon:

grafik.png (107×136 px, 2 KB)

Wed, Apr 3, 12:13 PM · Performance Issue, MediaWiki-extensions-FlaggedRevs
Jdlrobson added a comment to T350514: Projects with FlaggedRevisions installed load the entire Codex library and OOUI and 10kb more CSS, over 500kb of JavaScript and likely have higher first paint.

Are you sure this code runs on article views? It’s in a method called onProtectionFormAddFormFields, a ProtectionFormAddFormFields hook handler, so it should run only on action=protect.

Wed, Apr 3, 9:27 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Design-System-Team, Codex, MediaWiki-extensions-FlaggedRevs, Performance Issue
Jdlrobson added a comment to T350514: Projects with FlaggedRevisions installed load the entire Codex library and OOUI and 10kb more CSS, over 500kb of JavaScript and likely have higher first paint.

Are you sure this code runs on article views? It’s in a method called onProtectionFormAddFormFields, a ProtectionFormAddFormFields hook handler, so it should run only on action=protect.

Wed, Apr 3, 9:26 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Design-System-Team, Codex, MediaWiki-extensions-FlaggedRevs, Performance Issue
Tacsipacsi added a comment to T350514: Projects with FlaggedRevisions installed load the entire Codex library and OOUI and 10kb more CSS, over 500kb of JavaScript and likely have higher first paint.
Wed, Apr 3, 9:18 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Design-System-Team, Codex, MediaWiki-extensions-FlaggedRevs, Performance Issue
Jdlrobson added a subtask for T350514: Projects with FlaggedRevisions installed load the entire Codex library and OOUI and 10kb more CSS, over 500kb of JavaScript and likely have higher first paint: T361672: mediawiki.diff page should not load oojs-ui on page load - causing performance issues on FlaggedRevisions sites.
Wed, Apr 3, 7:14 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Design-System-Team, Codex, MediaWiki-extensions-FlaggedRevs, Performance Issue
Jdlrobson added a subtask for T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users: T361672: mediawiki.diff page should not load oojs-ui on page load - causing performance issues on FlaggedRevisions sites.
Wed, Apr 3, 7:13 AM · Performance Issue, MediaWiki-extensions-FlaggedRevs
Jdlrobson added a subtask for T350514: Projects with FlaggedRevisions installed load the entire Codex library and OOUI and 10kb more CSS, over 500kb of JavaScript and likely have higher first paint: T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users.
Wed, Apr 3, 7:04 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Design-System-Team, Codex, MediaWiki-extensions-FlaggedRevs, Performance Issue
Jdlrobson added a parent task for T361671: Large ext.flaggedRevs.advanced module is loaded for anonymous users: T350514: Projects with FlaggedRevisions installed load the entire Codex library and OOUI and 10kb more CSS, over 500kb of JavaScript and likely have higher first paint.
Wed, Apr 3, 7:04 AM · Performance Issue, MediaWiki-extensions-FlaggedRevs