I'm closing this @taavi, feel free to ping me if you run in any trouble!

In T362909#9727661, @Aklapper wrote:

@bd808: Does this error still appear after 2024-04-16 15:30UTC? If not, then this is likely a duplicate of T355644 (which reverted T352530 which I ideally would have never merged but lots of undocumented custom changes make it hard to foresee unwanted breakage).

@bd808: Does this error still appear after 2024-04-16 15:30UTC? If not, then this is likely a duplicate of T355644 (which reverted T352530 which I ideally would have never merged but lots of undocumented custom changes make it hard to foresee unwanted breakage).

I was able to create R3385 bd808-testing-T362909 via the Phabricator UI. Is it only the Conduit API that is failing? Are the failures intermittent?

This is basically a missing integration with the system that @Andrew built for T170355: Figure out process for deleting an unused tool (wikitech docs). There is also nothing currently deleting or otherwise marking GitLab projects and their associated Diffusion mirrors as abandoned or archived when the tool that created them is deleted.

The tool in question is https://toolsadmin.wikimedia.org/tools/id/api-docs. Things are definitely goofy here with there being no toolinfo record. There are several related log events in logstash, and they seem to start with this error that seems to echo the name validation failure.

Traceback (most recent call last):
  File "/srv/app/striker/tools/views/tool.py", line 83, in create
    tool = utils.create_tool(form.cleaned_data["name"], req.user)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/app/striker/tools/utils.py", line 86, in create_tool
    sudoers.save()
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/django/db/models/base.py", line 743, in save
    self.save_base(using=using, force_insert=force_insert,
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/django/db/models/base.py", line 780, in save_base
    updated = self._save_table(
              ^^^^^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldapdb/models/base.py", line 120, in _save_table
    connection.add_s(new_dn, new_values)
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldapdb/backends/ldap/base.py", line 317, in add_s
    return cursor.connection.add_s(dn, modlist)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldap/ldapobject.py", line 236, in add_s
    return self.add_ext_s(dn,modlist,None,None)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldap/ldapobject.py", line 1012, in add_ext_s
    return self._apply_method_s(SimpleLDAPObject.add_ext_s,*args,**kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldap/ldapobject.py", line 972, in _apply_method_s
    return func(self,*args,**kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldap/ldapobject.py", line 222, in add_ext_s
    resp_type, resp_data, resp_msgid, resp_ctrls = self.result3(msgid,all=1,timeout=self.timeout)
                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldap/ldapobject.py", line 543, in result3
    resp_type, resp_data, resp_msgid, decoded_resp_ctrls, retoid, retval = self.result4(
                                                                           ^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldap/ldapobject.py", line 553, in result4
    ldap_result = self._ldap_call(self._l.result4,msgid,all,timeout,add_ctrls,add_intermediates,add_extop)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/lib/poetry/striker-2uZo5AhP-py3.11/lib/python3.11/site-packages/ldap/ldapobject.py", line 128, in _ldap_call
    result = func(*args,**kwargs)
             ^^^^^^^^^^^^^^^^^^^^
ldap.ALREADY_EXISTS: {'msgtype': 105, 'msgid': 17, 'result': 68, 'desc': 'Already exists', 'ctrls': []}

Change #1021407 merged by Majavah:

[operations/puppet@production] hieradata: Update striker_toolsbeta database name

https://gerrit.wikimedia.org/r/1021407

Change #1021407 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] hieradata: Update striker_toolsbeta database name

https://gerrit.wikimedia.org/r/1021407

@taavi you can replace all occurrences of striker_toolsbeta by strikertoolsbeta (i.e. striker_toolsbeta_admin → strikertoolsbeta_admin). I've also updated credentials in the previous location
@jcrespo database has been properly renamed, good catch!

Change #1020709 had a related patch set uploaded (by Arnaudb; author: Arnaudb):

[operations/puppet@production] mariadb: removes underscore on striker database name

https://gerrit.wikimedia.org/r/1020709

In T360149#9716836, @ABran-WMF wrote:

@taavi would you be OK to drop & recreate that db so we discard the underscore?

Sure, just let me know what the new name is so I can update the app config.

@taavi would you be OK to drop & recreate that db so we discard the underscore?

There is now support for configuring a banner, and the demo server is currently down (T329687).

Change #1018656 merged by Majavah:

[operations/dns@master] Add toolsadmin-toolsbeta

https://gerrit.wikimedia.org/r/1018656

No need. I just wanted to warn the DBAs- althought you may find it interesting, as the last issue was with wikireplicas. No need to change anything at the moment (actual data and name), but the current grants providing access.

Oops - sorry about that. If you prefer a version without underscores, from my side it's totally fine to rename the database or just drop it and re-create the tables with a new name. Up to you.

Please see my last comment. Other than that, my work is done.

Change #1019069 merged by Jcrespo:

[operations/puppet@production] dbbackups: Add striker_toolsbeta to the list of m5 backups

https://gerrit.wikimedia.org/r/1019069

There is some issues on the already provided user grants. I don't think we should create databases with underscores or percentage signs on the name- but if we have to do it, let's use the proper escaping on grants to avoid things like this:

Change #1019069 had a related patch set uploaded (by Jcrespo; author: Jcrespo):

[operations/puppet@production] dbbackups: Add striker_toolsbeta to the list of m5 backups

https://gerrit.wikimedia.org/r/1019069

Change #1018665 merged by Majavah:

[operations/puppet@production] hieradata: Add CDN config for toolsadmin-toolsbeta.wikimedia.org

https://gerrit.wikimedia.org/r/1018665

I have a hacky script for this kind of stuff at cloudweb1003:/home/bd808/projects/striker/debug-striker.sh. It was inspired by the hacky script I had to make to manage Toolhub.

#!/usr/bin/env bash
# Run the Striker container locally.
# Typical usage:
#   ./debug-striker.sh -it --entrypoint=/bin/bash
set -euxo pipefail

Change #1018730 merged by Majavah:

[operations/puppet@production] hieradata: Update striker container to add staging env warning

https://gerrit.wikimedia.org/r/1018730

Change #1018730 merged by Majavah:

[operations/puppet@production] hieradata: Update striker container to add staging env warning

https://gerrit.wikimedia.org/r/1018730

Change #1018730 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] hieradata: Update striker container to add staging env warning

https://gerrit.wikimedia.org/r/1018730

Change #1018730 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] hieradata: Update striker container to add staging env warning

https://gerrit.wikimedia.org/r/1018730

Change #1018720 merged by jenkins-bot:

[labs/striker@master] Add option to show a environment-specific banner

https://gerrit.wikimedia.org/r/1018720